[GitHub] coveralls edited a comment on issue #20: RNG-70: Add new XoShiRo generators

coveralls edited a comment on issue #20: RNG-70: Add new XoShiRo generators URL: https://github.com/apache/commons-rng/pull/20#issuecomment-463829859 [](https://coveralls.io/builds/21664435) Coverage increased (+0.3%)

Re: [All, Math, Statistics] MathJax support

On 15/02/2019 02:56, Gilles Sadowski wrote: Le jeu. 14 févr. 2019 à 16:54, Alex Herbert a écrit : Commons RNG uses MathJax as a script to add support for rendering equations in the Javadocs. This support was originally included using the tag of the maven-javadoc-plugin. This was valid for 2

Re: [All, Math, Statistics] MathJax support

Le ven. 15 févr. 2019 à 12:15, Alex Herbert a écrit : > > > On 15/02/2019 02:56, Gilles Sadowski wrote: > > Le jeu. 14 févr. 2019 à 16:54, Alex Herbert a > > écrit : > >> Commons RNG uses MathJax as a script to add support for rendering > >> equations in the Javadocs. > >> > >> This support was

[VOTE] Release Apache Commons DBCP 2.6.0 based on RC1

We have fixed quite a few bugs and added some significant enhancements since Apache Commons DBCP 2.5.0 was released, so I would like to release Apache Commons DBCP 2.6.0. Apache Commons DBCP 2.6.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1 (

Re: [VOTE] Release Apache Commons DBCP 2.6.0 based on RC1

I forgot to add that on Java 11, the test setup fails: [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.03 s <<< FAILURE! - in org.apache.commons.dbcp2.managed.TestSynchronizationOrder [ERROR] testInterposedSynchronization(org.apache.commons.dbcp2.managed.TestSynchronizati

[DISCUSS] Change github notifications for all commons sub-projects

Hey all, There was a recent thread ([1]) with a brief discussion about the number of github updates that are currently ending up in the dev@ mailing list. Personally I find that a little too noisy (especially since I get 2 e-mails for repos that I'm subscribed to), and it seems others also don't

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257357531 ## File path: src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRa

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257357843 ## File path: src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRa

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257355590 ## File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c ##

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257357402 ## File path: src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRa

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257357499 ## File path: src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRa

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257356945 ## File path: src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRa

Re: [DISCUSS] Change github notifications for all commons sub-projects

+1 for moving github notifications to issues@ Am 15.02.2019 um 20:02 schrieb Marcelo Vanzin: Hey all, There was a recent thread ([1]) with a brief discussion about the number of github updates that are currently ending up in the dev@ mailing list. Personally I find that a little too noisy (esp

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257416150 ## File path: src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257416308 ## File path: src/main/native/org/apache/commons/crypto/org_apache_commons_cry

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257416282 ## File path: src/main/native/org/apache/commons/crypto/org_apache_commons_cry

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257416454 ## File path: src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRa

[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257416402 ## File path: src/main/native/org/apache/commons/crypto/org_apache_commons_cry

[GitHub] coveralls edited a comment on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

coveralls edited a comment on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-449676652 [](https://coveralls.io/buil

[GitHub] aremily commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

aremily commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-464273910 I think I got all the changes. I finally changed my c file formatter to stop defaulting with tabs. Sh

[GitHub] coveralls edited a comment on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

coveralls edited a comment on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-449676652 [](https://coveralls.io/buil

Re: [VOTE] Release Apache Commons DBCP 2.6.0 based on RC1

[ x ] +1 Release these artifacts (assuming tests failing on Java10 and Java11 are OK) Built with `mvn clean test install site` on Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00) Maven home: /opt/apache-maven-3.5.4 Java version: 1.8.0_191, vendor: Orac

[GitHub] kinow commented on issue #21: Update README.md

kinow commented on issue #21: Update README.md URL: https://github.com/apache/commons-dbcp/pull/21#issuecomment-464277860 Good catch @LichKing-lee ! And sorry for taking so long to look at this PR. There is a release going on, but once it's done, I will try to sort out conflicts and merge

[GitHub] kinow commented on issue #38: Cleaned up PNG component.

kinow commented on issue #38: Cleaned up PNG component. URL: https://github.com/apache/commons-imaging/pull/38#issuecomment-464302976 Just to let you know I haven't forgotten this pull request. Just busy with other things, but Imaging 1.0 should be out soon, then next step is maintenance a

[GitHub] kinow commented on issue #69: refactor similar test cases

kinow commented on issue #69: refactor similar test cases URL: https://github.com/apache/commons-io/pull/69#issuecomment-464303616 Tests failing in Travis-CI due to Checkstyle issues. Mind having a look @yannickzj ? This is a

[GitHub] kinow commented on issue #46: travis: add java 10 to build

kinow commented on issue #46: travis: add java 10 to build URL: https://github.com/apache/commons-collections/pull/46#issuecomment-464304240 The change looks OK @grimreaper , though in commons-io, for some reason [we are using openjdk10](https://github.com/apache/commons-io/blob/30f81c47f

[GitHub] kinow commented on issue #66: Avoid Code Duplication: Reuse Sleep from ThreadMonitor

kinow commented on issue #66: Avoid Code Duplication: Reuse Sleep from ThreadMonitor URL: https://github.com/apache/commons-io/pull/66#issuecomment-464305120 Hi @DaGeRe ! Agree that code duplication is bad. But the change could perhaps be changed a little bit to make it easier to ac

[GitHub] kinow commented on issue #65: Performance Enhancement: Call toArray with Zero Array Size

kinow commented on issue #65: Performance Enhancement: Call toArray with Zero Array Size URL: https://github.com/apache/commons-io/pull/65#issuecomment-464305656 Hi @DaGeRe ! I don't know if anything changed in Java 10+, but I think this is a good change, and will mark it as approved. Alas

[GitHub] kinow commented on a change in pull request #64: Two small tweaks.

kinow commented on a change in pull request #64: Two small tweaks. URL: https://github.com/apache/commons-io/pull/64#discussion_r257450883 ## File path: src/main/java/org/apache/commons/io/TaggedIOException.java ## @@ -129,7 +129,7 @@ public Serializable getTag() { *

[GitHub] kinow commented on issue #54: Code cleanup

kinow commented on issue #54: Code cleanup URL: https://github.com/apache/commons-io/pull/54#issuecomment-464307076 Looks good to me! Much more readable! I only would need to consult the documentation (and perhaps other devs) regarding removing exception from public methods. I am not sure

[GitHub] kinow opened a new pull request #6: Fix PMD issue of unnecessary fully qualified name for class already imported

kinow opened a new pull request #6: Fix PMD issue of unnecessary fully qualified name for class already imported URL: https://github.com/apache/commons-dbutils/pull/6 Fixes only PMD issue in the project report. This is an aut