Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

2018-08-27 Thread Benedikt Ritter
Hi, - sigs and hashes are good - builds fine with maven 3.5.4 from src distribution - website looks good - release notes look good - there are some differences between the src distribution and release tag: ~/w/a/r/r/t/jcs git:(upstream ⚡ master) > diff -r commons-jcs-2.2.1-RC4/ commons-jcs-2.2.1-

Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

2018-08-27 Thread sebb
On 27 August 2018 at 17:12, Benedikt Ritter wrote: > Hi, > > - sigs and hashes are good > - builds fine with maven 3.5.4 from src distribution > - website looks good > - release notes look good > - there are some differences between the src distribution and release tag: > > ~/w/a/r/r/t/jcs git:(up

Re: [ALL] Make checkstyle:check part of default maven goal?

2018-08-27 Thread Pascal Schumacher
At least RAT and clirr/japicmp should be part of default goal. I'm personally prefer checkstyle and findbugs/spotbugs (although I prefer error-prone nowadays) to be part of the default goal. On Java 8+ it is also helpful to make javadoc part of the default goal. I think it is very convenient

Re: [ALL] Make checkstyle:check part of default maven goal?

2018-08-27 Thread Rob Tompkins
> On Aug 27, 2018, at 2:33 PM, Pascal Schumacher > wrote: > > At least RAT and clirr/japicmp should be part of default goal. > > I'm personally prefer checkstyle and findbugs/spotbugs (although I prefer > error-prone nowadays) to be part of the default goal. > > On Java 8+ it is also helpf