asfgit closed pull request #7: Polar and Spherical Coordinates
URL: https://github.com/apache/commons-geometry/pull/7
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull reque
Github user asfgit closed the pull request at:
https://github.com/apache/commons-pool/pull/8
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Github user kinow commented on the issue:
https://github.com/apache/commons-pool/pull/8
Merged. Thanks!!!
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@com
Github user kinow commented on the issue:
https://github.com/apache/commons-collections/pull/42
Hi @sfuhrm , thanks for your contribution.
I had a look running `mvn clean site` against master, and checkstyle report
is empty. How did you get the warnings?
Note that the
Github user sfuhrm closed the pull request at:
https://github.com/apache/commons-collections/pull/42
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.
Github user sfuhrm commented on the issue:
https://github.com/apache/commons-collections/pull/42
Hi @kinow
well I'm a little bit confused, neither
```
mvn checkstyle:checkstyle
```
nor
```
mvn clean site
```
bring an error.
Github user sfuhrm closed the pull request at:
https://github.com/apache/commons-collections/pull/42
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/85#discussion_r204208775
--- Diff:
src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java ---
@@ -270,12 +270,6 @@ private static int limitedCompare(CharSequenc
Github user kinow commented on the issue:
https://github.com/apache/commons-collections/pull/42
I was confused too. Maybe it was fixed recently, or it was run with the IDE
or with some other setting.
Thanks for updating the issue so quickly. And feel free to submit other
pull
Github user kinow commented on the issue:
https://github.com/apache/commons-collections/pull/35
@saleem-akbar, thanks for taking your time to prepare a pull request.
Looks like, actually, there are two pull requests from you, for the same
issue. #34 and #35. This one has confl
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/10
When I apply this match to master, I get:
[INFO] Running org.apache.commons.pool2.impl.TestGenericObjectPool
[ERROR] Tests run: 82, Failures: 0, Errors: 3, Skipped: 0, Time elaps
Github user sunsuk7tp commented on the issue:
https://github.com/apache/commons-pool/pull/10
@garydgregory Oh, really? I tried that from latest master brach and it
passed with no error.
Could you tell me your jdk version and stuff? (mine is `1.8.0_171`)
BTW this PR didn't modi
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/10
I am using:
```
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T12:33:14-06:00)
Maven home: C:\Java\apache-maven-3.5.4\bin\..
Java version: 1.8.0_172
Github user sunsuk7tp commented on the issue:
https://github.com/apache/commons-pool/pull/10
Hmm.. I tried many times but it always succeeded like below:
https://gist.github.com/sunsuk7tp/c6ad1c73c77403c32bab546ca86198ff
Also, test all passed on travis ci:
https://tr
Github user kinow commented on the issue:
https://github.com/apache/commons-imaging/pull/37
>As much as I love tests I'm not sure how to proceed. So what do you think?
Maybe it we could get at least one or two tests, maybe using that
`groovy-1.7.5/bin/groovy.icns` file? That'd
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/34#discussion_r204226800
--- Diff: pom.xml ---
@@ -209,6 +209,12 @@
2.6
test
+
+
+ com.github.jai-imageio
+ jai
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/36#discussion_r204226858
--- Diff:
src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java ---
@@ -312,7 +312,12 @@ private void dumpSegments(final List v) {
17 matches
Mail list logo
