Re: [compress] close() and writing invalid streams

2018-06-29 Thread Stefan Bodewig
Hi Gary I'm afraid I don't really follow you here. close() doesn't open any resources so I'm not sure what try-with-resources can do here. Stefan On 2018-06-28, Gary Gregory wrote: > I'm for making it obvious and keeping clean ups localized, meaning add > try-with-resources blocks to all close(

Re: [compress] close() and writing invalid streams

2018-06-29 Thread Gary Gregory
I am saying that I prefer the option: public void close() throws IOException { try { finishFormatSpecificStuff(); } finally { closeUnderlyingStreamsOrChannelsAndOtherResources(); } } Gary On Fri, Jun 29, 2018 at 10:45 AM Stefan Bodewig wrote: > Hi Gary > > I'm