Re: [VOTE] Release Apache Commons Daemon 1.1.0 based on RC3

2017-11-16 Thread Mark Thomas
On 15/11/17 12:35, Mark Thomas wrote: > The proposed 1.1.0 release based on RC3 is: > [ ] Broken - do not release because... > [X] Approved - go ahead and release as 1.1.0 Windows with Tomcat 7.0.82 Tested by replacing the Windows binaries with those from Commons Daemon 1.1.0. - Digital signa

Re: commons-io git commit: += isLegalFile(CharSequence)

2017-11-16 Thread Gary Gregory
s/candidate.length() == 0/candidate.isEmpty() ? On Nov 16, 2017 05:44, wrote: > Repository: commons-io > Updated Branches: > refs/heads/master dcf6e82f8 -> 84a0d9078 > > > += isLegalFile(CharSequence) > > Project: http://git-wip-us.apache.org/repos/asf/commons-io/repo > Commit: http://git-w

Re: commons-io git commit: += isLegalFile(CharSequence)

2017-11-16 Thread sebb
On 16 November 2017 at 14:46, Gary Gregory wrote: > s/candidate.length() == 0/candidate.isEmpty() > Since the other check is also a length check I thought it was more consistent. > ? > > > > On Nov 16, 2017 05:44, wrote: > >> Repository: commons-io >> Updated Branches: >> refs/heads/master dc

Re: [apache/commons-io] [IO-553] Add (0603303)

2017-11-16 Thread Pascal Schumacher
Thanks for fixing! :) Cheers, Pascal Am 15.11.2017 um 21:09 schrieb Gary Gregory: Fixed, thank you! Gary On Wed, Nov 15, 2017 at 12:47 PM, Pascal Schumacher < notificati...@github.com> wrote: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:javadoc (defau

prevent registering JCSAdminBean multiple times

2017-11-16 Thread Tim Cronin
we have a few webapps running on the same server that use JCS. when moving the 2.x we started getting the following error on tomcat startup javax.management.InstanceAlreadyExistsException: org.apache.commons.jcs:type=JCSAdminBean at com.sun.jmx.mbeanserver.Repository.addMBean(Repository.jav

Re: prevent registering JCSAdminBean multiple times

2017-11-16 Thread Romain Manni-Bucau
Hi Tim Setting the jmxName to null on the composite cache manager should do the trick but depending the api you use is more or less easy. Can you have a look? Le 16 nov. 2017 21:54, "Tim Cronin" a écrit : we have a few webapps running on the same server that use JCS. when moving the 2.x we sta