[GitHub] commons-io pull request #43: Make code style of hasBOM() consistent with get...

2017-09-15 Thread mernst
GitHub user mernst opened a pull request: https://github.com/apache/commons-io/pull/43 Make code style of hasBOM() consistent with getBOMCharsetName() This is a minor, stylistic patch. Background fact: After the first call to `getBOM()`, the expressions `getBOM()` and `byt

Re: [VOTE] Release Apache Commons BCEL 6.1 based on RC1

2017-09-15 Thread Oliver Heger
Build works fine with Java 1.7 and 1.8 on Windows 10. Artifacts and site look good. The two errors reported by Clirr are explained in the release notes; I think this is fine. There are about 20 Findbugs errors, but probably no new ones. +1 Oliver Am 14.09.2017 um 22:29 schrieb Benedikt Ritter:

[Math][Numbers] Move Field, etc. to numbers?

2017-09-15 Thread Raymond DeCampo
So I was trying to work through MATH-1416, which is to remove code from CM which has been moved to CN and I ran into a snag when trying to replace o.a.c.math4.f.BigFraction with the version from CN in the KolmogorovSmirnovTest class. This class uses o.a.c.m.f.BigFraction as an implementation of Fi

Re: [VOTE] Release Apache Commons BCEL 6.1 based on RC1

2017-09-15 Thread Gary Gregory
+1 >From src zip: ASC, MD5, SHA1 OK (no SHA-512?) Builds fine with 'mvn clean verify site' and: Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T13:39:06-06:00) Maven home: C:\Java\apache-maven-3.5.0\bin\.. Java version: 1.8.0_144, vendor: Oracle Corporation Java home: C:

Re: [Math][Numbers] Move Field, etc. to numbers?

2017-09-15 Thread Gilles
On Fri, 15 Sep 2017 17:30:26 -0400, Raymond DeCampo wrote: So I was trying to work through MATH-1416, which is to remove code from CM which has been moved to CN and I ran into a snag when trying to replace o.a.c.math4.f.BigFraction with the version from CN in the KolmogorovSmirnovTest class. T