Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/57#discussion_r129102692
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -747,45 +750,29 @@ public static boolean containsAllWords(final
CharSequence wo
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/57#discussion_r129102634
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -747,45 +750,29 @@ public static boolean containsAllWords(final
CharSequence wo
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r129106989
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex()
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r129108740
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex()
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r129109286
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex()
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/56
[](https://coveralls.io/builds/12526449)
Coverage increased (+0.9%) to 98.163% when pulling
**12129b2beafc74f8f04957
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/56
[](https://coveralls.io/builds/12526449)
Coverage increased (+0.9%) to 98.163% when pulling
**12129b2beafc74f8f04957
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-text/pull/56
Obviously a problem occurred with Travis:
> The command "eval mvn install -DskipTests=true -Dmaven.javadoc.skip=true
-B -V " failed. Retrying, 2 of 3.
> Error: JAVA_HOME is not d
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/57
@ameyjadiye I want to remove the isDelimiter method. I would be surprised
if someone uses isDelimiter separately because all it does is to check if a
given element is present in an array or
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/57
@arunvinudss While I agree that `isDelimiter` should have been private, it
is public and was released with commons-text `1.1`. Due to the strict binary
compatibilities promise of common
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/56
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user asfgit closed the pull request at:
https://github.com/apache/commons-text/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/57
@arunvinudss , just addition to @PascalSchumacher comment , at this point
we don't know other than Commons text who else having dependancy on
`isDelimiter` so better we can make it depricated
13 matches
Mail list logo
