[TEXT] Review of the code base

Hi all, I've looked through the code base of [text] and I already did some clean up. However there are a few things, that need more work IMHO: 1. IP clearance! There are several comments talking about code adapted from PHP libraries. This needs to be listed in NOTICE.txt. For an example see the N

Re: [TEXT] Review of the code base

Thanks for the thorough code review Benedikt! Comments inline. > 1. IP clearance! There are several comments talking about code adapted from >PHP libraries. This needs to be listed in NOTICE.txt. For an example see >the NOTICE.txt in [lang]. Filed https://issues.apache.org/jira/browse/SANDBOX-497

Re: [math] threading redux

Hello. On Sat, 18 Apr 2015 22:25:20 -0400, James Carman wrote: I think I got sidetracked when typing that email. I was trying to say that we need an abstraction layer above raw threads in order to allow for different types of parallelism. The Future abstraction is there in order to support

Re: [TEXT] Review of the code base

Hello Bruno, 2015-04-19 12:15 GMT+02:00 Bruno P. Kinoshita : > Thanks for the thorough code review Benedikt! Comments inline. > > > 1. IP clearance! There are several comments talking about code adapted > from > >PHP libraries. This needs to be listed in NOTICE.txt. For an example see > >the NOTI

Re: [TEXT] Review of the code base

2015-04-19 17:24 GMT+02:00 Benedikt Ritter : > Hello Bruno, > > 2015-04-19 12:15 GMT+02:00 Bruno P. Kinoshita > : > >> Thanks for the thorough code review Benedikt! Comments inline. >> >> > 1. IP clearance! There are several comments talking about code adapted >> from >> >PHP libraries. This need

Re: [TEXT] Review of the code base

2015-04-19 17:29 GMT+02:00 Benedikt Ritter : > > > 2015-04-19 17:24 GMT+02:00 Benedikt Ritter : > >> Hello Bruno, >> >> 2015-04-19 12:15 GMT+02:00 Bruno P. Kinoshita > >: >> >>> Thanks for the thorough code review Benedikt! Comments inline. >>> >>> > 1. IP clearance! There are several comments tal

Re: [LANG] Next steps

Hi, 3.4 has been released. GitHub badges have been activated. Now we can start the migration to git. Here is the Infra ticket [1] Regards, Benedikt [1] https://issues.apache.org/jira/browse/INFRA-9478 2015-03-13 20:21 GMT+01:00 Gary Gregory : > I like you'd plan! > > Gary :-) > > Orig

Re: svn commit: r1674710 - /commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/CloseShieldOutputStream.java

Hello, Am Mon, 20 Apr 2015 00:25:55 - schrieb ggreg...@apache.org: > commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/CloseShieldOutputStream.java > (original) +++ > commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/CloseShieldOutputStream.java > Mon Apr 20 0

Re: svn commit: r1674710 - /commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/CloseShieldOutputStream.java

On Sun, Apr 19, 2015 at 6:05 PM, Bernd Eckenfels wrote: > Hello, > > Am Mon, 20 Apr 2015 00:25:55 - > schrieb ggreg...@apache.org: > > > commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/CloseShieldOutputStream.java > > (original) +++ > > > commons/proper/io/trunk/src/main/ja

Re: svn commit: r1674710 - /commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/CloseShieldOutputStream.java

Hello, commons-io has multiple Java 8 doclint warnings and errors (mostly missing references and self closing and @inheritDoc) in the current revision, but "CloseShieldOutputStream without the closing tag is not in that list. What command did you run and what error it is reporting? I tried java

Re: [2/3] [text] SANDBOX-497 IP clearance for the names package

On 4/19/15 6:52 AM, brit...@apache.org wrote: > SANDBOX-497 IP clearance for the names package > > Make clear that Commons Text only includes ported code from the > HumanNameParser PHP library. > HumanNameParser library is licensed under MIT. > > > Project: http://git-wip-us.apache.org/repos/asf/co

Re: svn commit: r1674710 - /commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/CloseShieldOutputStream.java

Javadoc 8 does not allow for XHTML tags to not be closed (in the default mode). When I run 'mvn clean site', I get, more of these errors and others: 9 errors 6 warnings [INFO] [INFO] BUILD FAILURE [INFO]