Re: [LANG] Save to remove @SuppressWarnings("null") from StrBuilder?

2013-05-03 Thread Emmanuel Bourg
Le 02/05/2013 21:54, sebb a écrit : > But the code can be (has been) rewritten to avoid the issue, as per > > URL: http://svn.apache.org/r1478506 > Log: > Rewrite to avoid (im)possible NPE warning With IntelliJ I don't get a warning when @SuppressWarnings("null") is removed (with both forms).

Re: [VOTE] Release of Commons Logging 1.1.3 based on RC1

2013-05-03 Thread Thomas Neidhart
Tbh, I do not know if the ant scripts still work. I also did not touch them when doing the 1.1.2 release afair. On Thu, May 2, 2013 at 9:56 PM, Emmanuel Bourg wrote: > Thank you for managing this release Thomas. The build.xml file still > contains "1.1.2-SNAPSHOT" > > Emmanuel Bourg > > > Le 02

Re: [VOTE] Release of Commons Logging 1.1.3 based on RC1

2013-05-03 Thread Emmanuel Bourg
Le 03/05/2013 10:01, Thomas Neidhart a écrit : > Tbh, I do not know if the ant scripts still work. I also did not touch them > when doing the 1.1.2 release afair. It is used to build the Debian package for Commons Logging and it works well. But the Debian team has to maintain a patch to fix this m

Re: svn commit: r1478655 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java

2013-05-03 Thread sebb
On 3 May 2013 07:40, Benedikt Ritter wrote: > The format field in Lexer is now only used by CSVLexer1 in the test > directory. It may therefore be removed. > I wonder if the isXXX methods really belong to CSVFormat. > > WDYT? > > The CSVLexerN entries in the test directory are copies of the origi

Re: [LANG] Save to remove @SuppressWarnings("null") from StrBuilder?

2013-05-03 Thread sebb
On 3 May 2013 08:44, Emmanuel Bourg wrote: > Le 02/05/2013 21:54, sebb a écrit : > > > But the code can be (has been) rewritten to avoid the issue, as per > > > > URL: http://svn.apache.org/r1478506 > > Log: > > Rewrite to avoid (im)possible NPE warning > > > With IntelliJ I don't get a warning

Commons sorting?

2013-05-03 Thread Adrien Grand
Hi, I'm working on an abstraction to sort random-access data-structures for Lucene[1] and would like to know if you think this is interesting enough for inclusion in Apache Commons. The reason for such an abstraction is that we often need to sort parallel arrays and the JDK provides no way to do

[CSV] Move isXXX(int) Methods from Lexer to CSVFormat? (was: Re: svn commit: r1478655 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java)

2013-05-03 Thread Benedikt Ritter
(moving this to a new thread) Hi, I did a very small refactoring in Lexer just to realize that the isXXX(int) methods (like boolean isDelimiter(int c)) really belong to CSVFormat rather than to the Lexer. How do you feel about this? Benedikt 2013/5/3 sebb > On 3 May 2013 07:40, Benedikt Ritte

Re: svn commit: r1478655 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java

2013-05-03 Thread Benedikt Ritter
2013/5/3 sebb > On 3 May 2013 07:40, Benedikt Ritter wrote: > > > The format field in Lexer is now only used by CSVLexer1 in the test > > directory. It may therefore be removed. > > I wonder if the isXXX methods really belong to CSVFormat. > > > > WDYT? > > > > > The CSVLexerN entries in the tes

Re: Commons sorting?

2013-05-03 Thread Matt Benson
Without putting too much importance on what I, personally, think, know that any ASF committer can have access to hack on a Commons-style library in our sandbox, just by asking for it. From my personal POV, I'm not sure if what we're talking about sounds like it has enough "surface area" to warrant

Re: Commons sorting?

2013-05-03 Thread Adrien Grand
Hi Matt, On Fri, May 3, 2013 at 4:30 PM, Matt Benson wrote: > Without putting too much importance on what I, personally, think, know that > any ASF committer can have access to hack on a Commons-style library in our > sandbox, just by asking for it. From my personal POV, I'm not sure if what > w

Re: [VOTE] Release of Commons Logging 1.1.3 based on RC1

2013-05-03 Thread Thomas Neidhart
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2013 11:15 AM, Emmanuel Bourg wrote: > Le 03/05/2013 10:01, Thomas Neidhart a écrit : >> Tbh, I do not know if the ant scripts still work. I also did not >> touch them when doing the 1.1.2 release afair. > > It is used to build the Debian pac

[CANCEL][VOTE] Release of Commons Logging 1.1.3 based on RC1

2013-05-03 Thread Thomas Neidhart
On 05/02/2013 08:43 PM, Thomas Neidhart wrote: > Hi, > > I'd like to call a vote for releasing Commons Logging 1.1.3 based on RC1. > > This release candidate has the following changes compared to 1.1.2: > > * Change Bundle-SymbolicName in the manifest to >"org.apache.commons.logging" > > T