Re: issues with org.apache.commons.pool2.performance. PerformanceTest

2011-01-20 Thread Simone Tripodi
Hi Zoly, thanks a lot for your contribution, it would be better if you can fill an issue providing a patch, I'll take care of it as soon as possible. Thanks in advance, Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Thu, Jan 20, 2011 at 3:13 AM, zoly farkas wrote: > th

issues with org.apache.commons.pool2.performance. PerformanceTest

2011-01-19 Thread zoly farkas
the use volatiles : waiting,complete,totalBorrowTime, totalReturnTime, nrSamples is not correct. for ex the following totalBorrowTime += borrowTime is not atomic resulting in a race condition. one way to fix this is using the java.util.concurent Atomic variants or even better, make these var