Re: [math] incompatible change in r936295

2010-06-01 Thread Gilles Sadowski
> > OK. So there is indeed an incompatible change between 2.1 and current (to > > become 2.2). Is this really a problem? I mean, it could be seen as a bug > > fix (i.e. it was a mistake to return the super-class type)! > > Does the policy forbid such kind of fixes even if prevents the development

Re: [math] incompatible change in r936295

2010-06-01 Thread Phil Steitz
Gilles Sadowski wrote: > Hi. > >> Some compiled client code can break if it extends the method, and >> returns something which is a BivariateRealFunction, but not a >> BicubicSplineInterpolatingFunction. >> Since the super class method contract has changed, the client code >> does not respect the

Re: [math] incompatible change in r936295

2010-06-01 Thread Gilles Sadowski
Hi. > Some compiled client code can break if it extends the method, and > returns something which is a BivariateRealFunction, but not a > BicubicSplineInterpolatingFunction. > Since the super class method contract has changed, the client code > does not respect the contract (return > BicubicSpline

Re: [math] incompatible change in r936295

2010-06-01 Thread James Carman
On Tue, Jun 1, 2010 at 8:37 AM, Gilles Sadowski wrote: > I don't understand. > Supposing that some (compiled) client code refers to > >  BivariateRealFunction interpolate(...) > > Since "BivariateRealFunction" is an interface, then, by definition, the > code cannot contain information about the sp

Re: [math] incompatible change in r936295

2010-06-01 Thread Julien Aymé
Hi, Some compiled client code can break if it extends the method, and returns something which is a BivariateRealFunction, but not a BicubicSplineInterpolatingFunction. Since the super class method contract has changed, the client code does not respect the contract (return BicubicSplineInterpolatin

Re: [math] incompatible change in r936295

2010-06-01 Thread Gilles Sadowski
> >>> Sorry I did not notice this before. I see it now flagged by the > >>> Clirr report. The problem is here: > >>> > >>> -public BivariateRealFunction interpolate(final double[] xval, > >>> - final double[] yval, > >>> -

Re: [math] incompatible change in r936295

2010-06-01 Thread Phil Steitz
Gilles Sadowski wrote: >>> Sorry I did not notice this before. I see it now flagged by the >>> Clirr report. The problem is here: >>> >>> -public BivariateRealFunction interpolate(final double[] xval, >>> - final double[] yval, >>> -

Re: [math] incompatible change in r936295

2010-06-01 Thread Gilles Sadowski
> > Sorry I did not notice this before.  I see it now flagged by the > > Clirr report.  The problem is here: > > > > -    public BivariateRealFunction interpolate(final double[] xval, > > -                                             final double[] yval, > > -                                      

Re: [math] incompatible change in r936295

2010-05-31 Thread Julius Davies
On Mon, May 31, 2010 at 5:36 PM, Phil Steitz wrote: > Sorry I did not notice this before.  I see it now flagged by the > Clirr report.  The problem is here: > > -    public BivariateRealFunction interpolate(final double[] xval, > -                                             final double[] yval, >