Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-23 Thread Rob Tompkins
Here’s my +1. > On Sep 23, 2017, at 11:37 AM, Gary Gregory wrote: > > Tally time! :-) > > On Wed, Sep 20, 2017 at 7:36 AM, Rob Tompkins wrote: > >> Hello, >> >> Commons Jelly 1.0.1 RC6 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision >> 217

Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-23 Thread Gary Gregory
Tally time! :-) On Wed, Sep 20, 2017 at 7:36 AM, Rob Tompkins wrote: > Hello, > > Commons Jelly 1.0.1 RC6 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision > 21718) > > The tag is here (tag commit 1808993): > https://svn.apache.org/repos/asf/c

Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-21 Thread Rob Tompkins
> On Sep 20, 2017, at 1:10 PM, Gary Gregory wrote: > > Yep, that does it! Bug in the BUILDING.md then. Not a blocker but should be > fixed in the repo ASAP. > > Gary > >> On Wed, Sep 20, 2017 at 11:03 AM, Rob Tompkins wrote: >> >> I think the "x" on the volume mount with /root/commons-jelly

Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-20 Thread Gary Gregory
On Wed, Sep 20, 2017 at 1:45 PM, Oliver Heger wrote: > Hi Rob, > > build works fine with jdk1.5.0_21 on Windows 10. Artifacts look good. > > The only minor nit I found is that the release notes state "This is the > first stable release of Jelly.", which is not true; but no blocker. > Fixed in SV

Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-20 Thread Oliver Heger
Hi Rob, build works fine with jdk1.5.0_21 on Windows 10. Artifacts look good. The only minor nit I found is that the release notes state "This is the first stable release of Jelly.", which is not true; but no blocker. So +1, great work! Oliver Am 20.09.2017 um 15:36 schrieb Rob Tompkins: > Hell

Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-20 Thread Rob Tompkins
> On Sep 20, 2017, at 1:10 PM, Gary Gregory wrote: > > Yep, that does it! Bug in the BUILDING.md then. Not a blocker but should be > fixed in the repo ASAP. > Fixed in the 1.X branch. Cheers, -Rob > Gary > > On Wed, Sep 20, 2017 at 11:03 AM, Rob Tompkins wrote: > >> I think the "x" on the

Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-20 Thread Gary Gregory
+1 >From src zip: ASC, MD5, SHA1 OK. Apache RAT check OK Apache CLIRR check OK OK: docker run -v C:\temp\rc\commons-jelly-1.0.1-src:/root/commons-jelly-1.x commons-jelly-build-env ant dist Docker version 17.06.2-ce, build cec0b72 Gary On Wed, Sep 20, 2017 at 7:36 AM, Rob Tompkins wrote: >

Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-20 Thread Gary Gregory
Yep, that does it! Bug in the BUILDING.md then. Not a blocker but should be fixed in the repo ASAP. Gary On Wed, Sep 20, 2017 at 11:03 AM, Rob Tompkins wrote: > I think the "x" on the volume mount with /root/commons-jelly-1.X needs to > be capitalized. > > > On Sep 20, 2017, at 12:44 PM, Gary G

Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-20 Thread Rob Tompkins
I think the "x" on the volume mount with /root/commons-jelly-1.X needs to be capitalized. > On Sep 20, 2017, at 12:44 PM, Gary Gregory wrote: > > Should the answer.txt and install.sh files be in the src zip file? > > Gary > > On Wed, Sep 20, 2017 at 10:42 AM, Gary Gregory > wrote: > >> Hi,

Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-20 Thread Gary Gregory
Should the answer.txt and install.sh files be in the src zip file? Gary On Wed, Sep 20, 2017 at 10:42 AM, Gary Gregory wrote: > Hi, > > I think I missed a step... I get: > > C:\temp\rc\commons-jelly-1.0.1-src>docker run -v > C:\temp\rc\commons-jelly-1.0.1-src:/root/commons-jelly-1.x > commons-j

Re: [VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-20 Thread Gary Gregory
Hi, I think I missed a step... I get: C:\temp\rc\commons-jelly-1.0.1-src>docker run -v C:\temp\rc\commons-jelly-1.0.1-src:/root/commons-jelly-1.x commons-jelly-build-env ant dist Buildfile: build.xml does not exist! Build failed Here is my session: https://pastebin.com/y7kFnNfn Help? Gary On