Re: [VOTE] Release commons-email-1.2 based on RC2

2009-06-22 Thread Phil Steitz
Siegfried Goeschl wrote: Hi Emmanuel, see my comments below ... Cheers, Siegfried Goeschl Emmanuel Bourg wrote: A few comments: - 1.0-rc6-SNAPSHOT is still mentioned as "in svn" in the change notes. I guess the changes for the two 1.0-rc could be merged into the changes for 1.0 I g

Re: [VOTE] Release commons-email-1.2 based on RC2

2009-06-22 Thread Siegfried Goeschl
Hi Emmanuel, see my comments below ... Cheers, Siegfried Goeschl Emmanuel Bourg wrote: > A few comments: > > - 1.0-rc6-SNAPSHOT is still mentioned as "in svn" in the change notes. > I guess the changes for the two 1.0-rc could be merged into the > changes for 1.0 I guess that would be bending o

Re: [VOTE] Release commons-email-1.2 based on RC2

2009-06-22 Thread sebb
On 22/06/2009, Mark Struberg wrote: > > Hi Ziggi! > > > > +) using "http://example.invalid"; for a bad url > > > hmm, sorry if I missed the point, but what exactly is wrong with that very > URI? The 'invalid' tld? What about 'local' URIs for e.g. company internal > resources? Remember our mave

Re: [VOTE] Release commons-email-1.2 based on RC2

2009-06-21 Thread Emmanuel Bourg
A few comments: - 1.0-rc6-SNAPSHOT is still mentioned as "in svn" in the change notes. I guess the changes for the two 1.0-rc could be merged into the changes for 1.0 - Commons Logging is listed in the test dependencies, but it's not used - the clirr report is generated against Commons Email