Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-29 Thread Gary Gregory
On Sat, Sep 29, 2018 at 6:57 PM Rob Tompkins wrote: > > > > On Sep 29, 2018, at 8:42 PM, Gary Gregory > wrote: > > > >> On Sat, Sep 29, 2018 at 6:24 AM Rob Tompkins > wrote: > >> > >> > >> > >>> On Sep 28, 2018, at 9:36 PM, Gary Gregory > >> wrote: > >>> > >>> Hi, > >>> > >>> It looks like I d

Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-29 Thread Rob Tompkins
> On Sep 29, 2018, at 8:42 PM, Gary Gregory wrote: > >> On Sat, Sep 29, 2018 at 6:24 AM Rob Tompkins wrote: >> >> >> >>> On Sep 28, 2018, at 9:36 PM, Gary Gregory >> wrote: >>> >>> Hi, >>> >>> It looks like I did not spot what Spotbugs found :-( >>> >>> >> https://dist.apache.org/repo

Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-29 Thread Gary Gregory
On Sat, Sep 29, 2018 at 6:24 AM Rob Tompkins wrote: > > > > On Sep 28, 2018, at 9:36 PM, Gary Gregory > wrote: > > > > Hi, > > > > It looks like I did not spot what Spotbugs found :-( > > > > > https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/spotbugs.html > > > > > > The only re

Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-29 Thread Rob Tompkins
> On Sep 28, 2018, at 9:36 PM, Gary Gregory wrote: > > Hi, > > It looks like I did not spot what Spotbugs found :-( > > https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/spotbugs.html > > > The only real worrisome one IMO is: > "org.apache.commons.text.lookup.PropertiesStrin

Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-29 Thread Pascal Schumacher
+1 Am 29.09.2018 um 03:36 schrieb Gary Gregory: Hi, It looks like I did not spot what Spotbugs found :-( https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/spotbugs.html The only real worrisome one IMO is: "org.apache.commons.text.lookup.PropertiesStringLookup.lookup(String) ma

Re: [VOTE] Release Apache Commons Text 1.5 based on RC1

2018-09-28 Thread Gary Gregory
Hi, It looks like I did not spot what Spotbugs found :-( https://dist.apache.org/repos/dist/dev/commons/text/1.5-RC1/site/spotbugs.html The only real worrisome one IMO is: "org.apache.commons.text.lookup.PropertiesStringLookup.lookup(String) may fail to close stream" If we fix one, we might as