On Fri, Jul 6, 2018 at 2:53 AM Bruno P. Kinoshita
wrote:
>
>
> [ X ] +1 Release these artifacts
> Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
> 2017-10-18T20:58:13+13:00)
> Maven home: /opt/apache-maven-3.5.2
> Java version: 1.8.0_171, vendor: Oracle Corporation
> Java home: /us
My +1. Always looking for more reviews ;-)
Gary
On Tue, Jul 3, 2018 at 4:27 PM Gary Gregory wrote:
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Pool 2.5.0 was released, so I would like to release
> Apache Commons Pool 2.6.0.
>
> Apache Commons
[ X ] +1 Release these artifacts
Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
2017-10-18T20:58:13+13:00)
Maven home: /opt/apache-maven-3.5.2
Java version: 1.8.0_171, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_NZ, platform enco
+1,
builds/tests on java 7, 8, 10.0.1
site works on 7 and 8.
Signatures, Rat ok.
Agree with Oliver’s nits.
-Rob
> On Jul 4, 2018, at 3:51 PM, Oliver Heger wrote:
>
> Build works fine with Java 8 on Windows 10. Artifacts and site look good.
>
> +1
>
> One minor point I noticed is that th
On Wed, Jul 4, 2018 at 1:51 PM Oliver Heger
wrote:
> Build works fine with Java 8 on Windows 10. Artifacts and site look good.
>
> +1
>
Thank you for your review Oliver.
>
> One minor point I noticed is that the release notes say that "Version 2
> requires JDK level 1.6 or above", but the mini
Build works fine with Java 8 on Windows 10. Artifacts and site look good.
+1
One minor point I noticed is that the release notes say that "Version 2
requires JDK level 1.6 or above", but the minimum JDK for 2.6 is 1.7.
There are also a few checkstyle errors that could be fixed with not too
much
