Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

> On 27 May 2019, at 12:37, Gary Gregory wrote: > > Hi Alex, > > Thank you for your review. Please my comments see below. > > On Sun, May 26, 2019 at 5:03 PM Alex Herbert > > wrote: > >> Hi Gary, >> >> +0.5 >> >> I get build failures to do with environment

Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

My +1 Gary On Thu, May 23, 2019 at 9:39 PM Gary Gregory wrote: > To: dev@commons.apache.org > Subject: [VOTE] Release Apache Commons Configuration 2.5 based on RC1 > > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Configuration 2.4 was released, s

Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

Hi Alex, Thank you for your review. Please my comments see below. On Sun, May 26, 2019 at 5:03 PM Alex Herbert wrote: > Hi Gary, > > +0.5 > > I get build failures to do with environment properties look-up because one > of my environment properties is resolved with current known variables. > > I

Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

Signatures good, site good, java8 (check), java11 (check) [builds done on: $ mvn -version Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00) Maven home: /usr/local/Cellar/maven/3.6.0/libexec Java version: 11.0.2, vendor: Amazon.com Inc., runtime: /Library/Ja

Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

Hi Gary, +0.5 I get build failures to do with environment properties look-up because one of my environment properties is resolved with current known variables. It can be reproduced using this (on a linux-type build with a bash shell): export BAD_VAR='${USER}@${HOSTNAME}’ mvn -V clean package

Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

> On May 26, 2019, at 10:47 AM, Gary Gregory wrote: > > Hi all, are any of you available to review this RC? I’ll try to get to it before the end of the day. -Rob > > Gary > >> On Thu, May 23, 2019 at 9:39 PM Gary Gregory wrote: >> >> To: dev@commons.apache.org >> Subject: [VOTE] Release A

Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

Hi all, are any of you available to review this RC? Gary On Thu, May 23, 2019 at 9:39 PM Gary Gregory wrote: > To: dev@commons.apache.org > Subject: [VOTE] Release Apache Commons Configuration 2.5 based on RC1 > > We have fixed quite a few bugs and added some significant enhancements > since Ap

Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

Funny, I think I hit some wrong key when writing the command for Java 11 and did not pay attention to the message or command line, sorry. Build passing with `mvn clean test install site` with Java 11: Maven home: /opt/apache-maven-3.5.4 Java version: 11.0.2, vendor: Oracle Corporation, runtime:

Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

On Fri, May 24, 2019 at 8:53 AM Bruno P. Kinoshita wrote: >[x] +1 Release these artifacts > > > Build failed on JDK 11, but passed with `mvn clean test install site` > using the tag on > Note that the Java 11 build passes on https://travis-ci.org/apache/commons-configuration, only Java 13-EA

Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

  [x] +1 Release these artifacts Build failed on JDK 11, but passed with `mvn clean test install site` using the tag on Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00) Maven home: /opt/apache-maven-3.5.4 Java version: 1.8.0_212, vendor: Oracle Corpora