Due to important changes delivered by this release, which will be
detailed here ASAP, I am abbreviating the voting period from 72 to 24
hours.
This vote thread passes with the following binding vote:
+1 Bruno Kinoshita
+1 Gary Gregory
+1 Rob Tompkins
In addition, the following non-binding votes w
+1 - all looks good
> On Feb 17, 2024, at 7:14 PM, Gary Gregory wrote:
>
> [VOTE] Release Apache Commons Compress 1.26.0 based on RC1
>
> We have fixed a few bugs and added some enhancements since Apache
> Commons Compress 1.25.0 was released, so I would like to release
> Apache Commons Compres
The problem with CTR (Commit Then Review) instead of RTC (Review Then
Commit) is that CTR too often turns into Commit Never Review. The
problem with RTC is that it slows code velocity.
For major projects at the base of a lot of the Java ecosystem like
many Apache Commons libraries, I'm willing to
On Sun, Feb 18, 2024 at 9:51 AM Gary Gregory wrote:
> > There seem to have been a lot of needless deprecations of constructors
> > and replacement with builder patterns.
>
> The use of the builder pattern avoids constructor inflation. For
> example, we had fourteen (14) constructors for ZipFile,
On Sun, Feb 18, 2024 at 1:22 PM Elliotte Rusty Harold
wrote:
>
> Meta issue: the use of direct git commits without PRs or code review
> makes releases harder to review.
Hello Elliotte,
Meta issue:
- This project uses CTR, not RTC. We welcome PRs but do not _require_
them of project committers.
-
Meta issue: the use of direct git commits without PRs or code review
makes releases harder to review.
Specific issues:
https://github.com/apache/commons-compress/commit/9f2f97925fdb52b5a3a32da6337ea1f113a3be82
is wonky and rates a -1 from me. An encoding error is not necessarily
an I/O error, and
My +1
Gary
On Sun, Feb 18, 2024 at 12:14 AM Gary Gregory wrote:
>
> [VOTE] Release Apache Commons Compress 1.26.0 based on RC1
>
> We have fixed a few bugs and added some enhancements since Apache
> Commons Compress 1.25.0 was released, so I would like to release
> Apache Commons Compress 1.26.0
+1, binding
Build is OK
Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /opt/apache-maven-3.8.5
Java version: 17.0.9, vendor: Private Build, runtime:
/usr/lib/jvm/java-17-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-94-
* checked the zip and tar.gz match the sha512sum above
* checked the zip and tar.gz match the code at the tag
* checked they were signed with 2DB4F1EF0FA761ECC4EA935C86FDC7E2A11262CB
* built with 'mvn clean install'
* checked the built commons-compress-1.26.0.pom was bit-by-bit identical to
the one
