Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC1

2024-05-19 Thread Gary Gregory
RC2 out. Gary On Sat, May 18, 2024, 12:52 PM Claude Warren wrote: > I would be OK with not making the additional method public. > > On Sat, May 18, 2024 at 3:38 PM Gary Gregory > wrote: > >> Thank you Claude. >> >> I'm OK either way. I've commented on the PR. I'd like to know what others >> th

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC1

2024-05-18 Thread Claude Warren
I would be OK with not making the additional method public. On Sat, May 18, 2024 at 3:38 PM Gary Gregory wrote: > Thank you Claude. > > I'm OK either way. I've commented on the PR. I'd like to know what others > think. > > The change proposed only makes sense if we cancel this RC othewise it > w

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC1

2024-05-18 Thread Gary Gregory
Thank you Claude. I'm OK either way. I've commented on the PR. I'd like to know what others think. The change proposed only makes sense if we cancel this RC othewise it would be a breaking change or would clutter up the API with an additional public method. Gary On Sat, May 18, 2024 at 9:04 AM

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC1

2024-05-18 Thread Claude Warren
-1 There is a design issue. The HelpFormatter now takes a BiFunction to format the description for deprecated Options. However, it is simple to implement Function instead. I think this makes for a cleaner interface. Since this interface is public facing, I would like to merge the change in #2