Re: [VOTE] Release Codec 1.4 based on RC4

2009-08-08 Thread Phil Steitz
Niall Pemberton wrote: +1 Phil I have prepared a fourth release candidate for Codec 1.4 following the feedback from the third. [ ] +1 Yes go ahead an release based on RC4 [ ] -1 No, because... The tag for RC4 is here: http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC4/ The

Re: [VOTE] Release Codec 1.4 based on RC4

2009-08-07 Thread Niall Pemberton
On Fri, Aug 7, 2009 at 8:05 AM, Jörg Schaible wrote: > Hi Niall, > > there are 7 issues in JIRA set to resolved: > https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310464&status=5. > IF they're part of 1.4, they should be closed now. OK I've reviewed and closed all these.

Re: [VOTE] Release Codec 1.4 based on RC4

2009-08-07 Thread Jörg Schaible
Hi Niall, there are 7 issues in JIRA set to resolved: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310464&status=5. IF they're part of 1.4, they should be closed now. What makes me wonder is that all fixed are part of http://people.apache.org/~niallp/codec-1.4-rc4/sit

RE: [VOTE] Release Codec 1.4 based on RC4

2009-08-06 Thread Gary Gregory
[X] +1 Yes go ahead an release based on RC4 Tested -src.zip with ant and mvn builds on Sun Java 1.6.0_15 on Windows XP 32-bits. Gary PS Nits: I just noticed this in the Ant build output: [javadoc] C:\test\commons-codec-1.4-src\src\java\org\apache\commons\codec\digest\DigestUtils.java:68: wa

Re: [VOTE] Release Codec 1.4 based on RC4

2009-08-06 Thread Luc Maisonobe
Niall Pemberton a écrit : > I have prepared a fourth release candidate for Codec 1.4 following the > feedback from the third. > > [ ] +1 Yes go ahead an release based on RC4 > [ ] -1 No, because... +1 I'm really impressed by test coverage, its amazing! Luc > > The tag for RC4 is here: > http:

Re: [VOTE] Release Codec 1.4 based on RC4

2009-08-06 Thread Niall Pemberton
+1 Niall On Thu, Aug 6, 2009 at 6:02 PM, Niall Pemberton wrote: > I have prepared a fourth release candidate for Codec 1.4 following the > feedback from the third. > > [ ] +1 Yes go ahead an release based on RC4 > [ ] -1 No, because... > > The tag for RC4 is here: > http://svn.apache.org/viewvc/c

Re: [VOTE] Release Codec 1.4 based on RC4

2009-08-06 Thread Niall Pemberton
On Thu, Aug 6, 2009 at 6:13 PM, Gary Gregory wrote: > The CLIRR page reminded me that there is no automated way to make sure we > have added @since 1.4 tags in all the right places. > > For example, Hex.DEFAULT_CHARSET_NAME was missing its @since 1.4, now in SVN. OK, but it missed RC4 - but no bi

RE: [VOTE] Release Codec 1.4 based on RC4

2009-08-06 Thread Gary Gregory
The CLIRR page reminded me that there is no automated way to make sure we have added @since 1.4 tags in all the right places. For example, Hex.DEFAULT_CHARSET_NAME was missing its @since 1.4, now in SVN. Gary > -Original Message- > From: Niall Pemberton [mailto:niall.pember...@gmail.co