Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-13 Thread Gary Gregory
On Tue, Feb 13, 2018 at 11:06 AM, Pascal Schumacher < pascalschumac...@gmx.net> wrote: > Am 12.02.2018 um 21:53 schrieb Gary Gregory: > >> On Mon, Feb 12, 2018 at 12:53 PM, Gary Gregory >> wrote: >> >> On Mon, Feb 12, 2018 at 12:30 PM, Pascal Schumacher < >>> pascalschumac...@gmx.net> wrote: >>>

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-13 Thread Pascal Schumacher
Am 12.02.2018 um 21:53 schrieb Gary Gregory: On Mon, Feb 12, 2018 at 12:53 PM, Gary Gregory wrote: On Mon, Feb 12, 2018 at 12:30 PM, Pascal Schumacher < pascalschumac...@gmx.net> wrote: please revert "Update actual Checkstyle from 6.19 to 8.8.", as Checkstyle 7+ requries Java 8+. Done. T

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-12 Thread Gary Gregory
On Mon, Feb 12, 2018 at 12:53 PM, Gary Gregory wrote: > > > On Mon, Feb 12, 2018 at 12:30 PM, Pascal Schumacher < > pascalschumac...@gmx.net> wrote: > >> Am 12.02.2018 um 18:52 schrieb Gary Gregory: >> >>> I agree 100% and will proceed. I thought about it overnight and it does >>> not >>> make se

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-12 Thread Gary Gregory
On Mon, Feb 12, 2018 at 12:30 PM, Pascal Schumacher < pascalschumac...@gmx.net> wrote: > Am 12.02.2018 um 18:52 schrieb Gary Gregory: > >> I agree 100% and will proceed. I thought about it overnight and it does >> not >> make sense to leave a mix of abstract classes and interfaces in >> StrSubstit

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-12 Thread Pascal Schumacher
Am 12.02.2018 um 18:52 schrieb Gary Gregory: I agree 100% and will proceed. I thought about it overnight and it does not make sense to leave a mix of abstract classes and interfaces in StrSubstitutor. +1, but please revert "Update actual Checkstyle from 6.19 to 8.8.", as Checkstyle 7+ requrie

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-12 Thread Gary Gregory
On Sun, Feb 11, 2018 at 8:12 PM, Chas Honton wrote: > Definitely create interfaces. > I agree 100% and will proceed. I thought about it overnight and it does not make sense to leave a mix of abstract classes and interfaces in StrSubstitutor. Gary > > Chas > > > On Feb 11, 2018, at 1:57 PM, Ga

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Chas Honton
Definitely create interfaces. Chas > On Feb 11, 2018, at 1:57 PM, Gary Gregory wrote: > > On Sun, Feb 11, 2018 at 2:46 PM, Gary Gregory > wrote: > >> >> >> On Sun, Feb 11, 2018 at 12:05 PM, Pascal Schumacher < >> pascalschumac...@gmx.net> wrote: >> Am 11.02.2018 um 19:24 schrieb Gary

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Gary Gregory
On Sun, Feb 11, 2018 at 2:46 PM, Gary Gregory wrote: > > > On Sun, Feb 11, 2018 at 12:05 PM, Pascal Schumacher < > pascalschumac...@gmx.net> wrote: > >> Am 11.02.2018 um 19:24 schrieb Gary Gregory: >> >>> I'd like a code review and then a release of 1.3. Right now we only >>> depend >>> on java.b

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Gary Gregory
On Sun, Feb 11, 2018 at 12:05 PM, Pascal Schumacher < pascalschumac...@gmx.net> wrote: > Am 11.02.2018 um 19:24 schrieb Gary Gregory: > >> I'd like a code review and then a release of 1.3. Right now we only depend >> on java.base and Commons Lang, so let's keep it that way for 1.3 I think. >> > My

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Pascal Schumacher
Am 11.02.2018 um 19:24 schrieb Gary Gregory: I'd like a code review and then a release of 1.3. Right now we only depend on java.base and Commons Lang, so let's keep it that way for 1.3 I think. My comments: - Given "TEXT-80: StrLookup API confusing generic type parameter" I think we should depr

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Rob Tompkins
>> >>>>> >>>>>> On Dec 14, 2017, at 4:11 PM, Gary Gregory >>>>>>> >>>>>> wrote: >>>>>> >>>>>>> I think I'll pick Commons Config as the starting point, unless someone >>>>>>> >>

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Pascal Schumacher
Am 11.02.2018 um 19:10 schrieb Gary Gregory: Done but there is one checkstyle "Error" left for a TODO comment I left in the code. Thanks! - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Gary Gregory
gt;> else >>>>> >>>>>> has a stronger POV. >>>>>> >>>>> +1 >>>>> >>>>> Gary >>>>>> >>>>>> On Thu, Dec 14, 2017 at 12:59 PM, Jan Matèrne (jhm) < &g

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Gary Gregory
>>> Gary >>>>> >>>>> On Thu, Dec 14, 2017 at 12:59 PM, Jan Matèrne (jhm) >>>> > >>>>> wrote: >>>>> >>>>> If I see a syntax like ${prefix:key} I could think of having a map of >>>>>> >>>>> &quo

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Pascal Schumacher
ia a "Datasource". And Tamaya will also have one, I think ... Jan -Ursprüngliche Nachricht- Von: Ralph Goers [mailto:ralph.go...@dslextreme.com] Gesendet: Donnerstag, 14. Dezember 2017 16:41 An: Commons Developers List Betreff: Re: [text] Adapt the Log4j 2 Interpolator to [t

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-10 Thread Gary Gregory
n values via a "Datasource". >> >> >> >> And Tamaya will also have one, I think ... >> >> >> >> >> >> Jan >> >> >> >> >> >> >> >>> -Ursprüngliche Nachricht- >> >&

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-10 Thread Gary Gregory
urce". > >> > >> And Tamaya will also have one, I think ... > >> > >> > >> Jan > >> > >> > >> > >>> -Ursprüngliche Nachricht- > >>> Von: Ralph Goers [mailto:ralph.go...@dslextreme.com]

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2017-12-14 Thread Rob Tompkins
But maybe also have a look at Apache Deltaspike which supports >> configurtion values via a "Datasource". >> >> And Tamaya will also have one, I think ... >> >> >> Jan >> >> >> >>> -Ursprüngliche Nachricht----- >>> Vo

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2017-12-14 Thread Gary Gregory
t; > And Tamaya will also have one, I think ... > > > Jan > > > > > -Ursprüngliche Nachricht- > > Von: Ralph Goers [mailto:ralph.go...@dslextreme.com] > > Gesendet: Donnerstag, 14. Dezember 2017 16:41 > > An: Commons Developers List > > Betreff: Re: [text] Ad

AW: [text] Adapt the Log4j 2 Interpolator to [text]

2017-12-14 Thread jhm
which supports configurtion values via a "Datasource". And Tamaya will also have one, I think ... Jan > -Ursprüngliche Nachricht- > Von: Ralph Goers [mailto:ralph.go...@dslextreme.com] > Gesendet: Donnerstag, 14. Dezember 2017 16:41 > An: Commons Developers List

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2017-12-14 Thread Ralph Goers
Yes, the Interpolator was borrowed from Commons Configuration. Ralph > On Dec 14, 2017, at 5:20 AM, Jörg Schaible > wrote: > > Hi Gary, > > Am Wed, 13 Dec 2017 15:17:56 -0700 schrieb Gary Gregory: > >> Hi All, >> >> Log4j 2 provides it's own copy of our StrSubstitutor/StrLookup framework >>

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2017-12-14 Thread Jörg Schaible
Hi Gary, Am Wed, 13 Dec 2017 15:17:56 -0700 schrieb Gary Gregory: > Hi All, > > Log4j 2 provides it's own copy of our StrSubstitutor/StrLookup framework > enhanced for Log4j's needs. In addition it provides a custom StrLookup > called Interpolator which allows for lookups like: > > ${sys:java.v

[text] Adapt the Log4j 2 Interpolator to [text]

2017-12-13 Thread Gary Gregory
Hi All, Log4j 2 provides it's own copy of our StrSubstitutor/StrLookup framework enhanced for Log4j's needs. In addition it provides a custom StrLookup called Interpolator which allows for lookups like: ${sys:java.version} and ${env:MY_VAR} to look up system properties and environment variables r