Re: [ALL] Commit log messages (was: [scxml-eclipse] Commit messages)

2010-05-17 Thread Rahul Akolkar
On Mon, May 17, 2010 at 6:25 PM, sebb wrote: > I largely agree with what was said about commit messages, but I > think it's important to ensure that code comments aren't thereby > neglected. > Indeed, the former isn't meant to take the place of the latter. For a commit (especially larger ones),

[ALL] Commit log messages (was: [scxml-eclipse] Commit messages)

2010-05-17 Thread sebb
I largely agree with what was said about commit messages, but I think it's important to ensure that code comments aren't thereby neglected. [BTW, I'm not implying anything about the scxml code - this is a general point] AIUI commit log messages are not versioned so if they are changed, that's it

[scxml-eclipse] Commit messages

2010-05-17 Thread Rahul Akolkar
When checking in code, please include commit messages that describe the changes. Again, this can be easily fixed by modifying the commit messages later, and I recommend that we fix the commit messages from earlier today. Ideally, large commits are to be avoided (but since you just got access you c