Re: [pool] POOL-97 timer patch

2007-12-29 Thread Phil Steitz
Thanks. I will apply this when I am back online. One thing I don't understand is why the unit tests (which test eviction) do not hang. Any ideas on that or tests we can add to pick this up? On 12/29/07, Mark Thomas <[EMAIL PROTECTED]> wrote: > Mark Thomas wrote: > > Phil Steitz wrote: > >> Yes, I

Re: [pool] POOL-97 timer patch

2007-12-29 Thread Phil Steitz
Thanks. I will apply this when I am back online. One thing I don't understand is why the unit tests (which test eviction) do not hang. Any ideas on that or tests we can add to pick this up? On 12/29/07, Mark Thomas <[EMAIL PROTECTED]> wrote: > Mark Thomas wrote: > > Phil Steitz wrote: > >> Yes, I

Re: [pool] POOL-97 timer patch

2007-12-29 Thread Mark Thomas
Mark Thomas wrote: > Phil Steitz wrote: >> Yes, I saw this with both the pool and dbcp tests when I set the >> timeBetweenEvictionRuns to a positive number > > Sorry. My bad. I was being stupid. I see this now with 1.5.0_13 and > 1.6.0_03. I'll see if I can figure out why. Found it. My new Evicti

Re: [pool] POOL-97 timer patch

2007-12-29 Thread Mark Thomas
Phil Steitz wrote: > Yes, I saw this with both the pool and dbcp tests when I set the > timeBetweenEvictionRuns to a positive number Sorry. My bad. I was being stupid. I see this now with 1.5.0_13 and 1.6.0_03. I'll see if I can figure out why. Mark -

Re: [pool] POOL-97 timer patch

2007-12-28 Thread Phil Steitz
Yes, I saw this with both the pool and dbcp tests when I set the timeBetweenEvictionRuns to a positive number On 12/28/07, Mark Thomas <[EMAIL PROTECTED]> wrote: > Phil Steitz wrote: > > I am not sure whether this is actually a bug, or worth reopening > > POOL-97, but want to be safe rather than s

Re: [pool] POOL-97 timer patch

2007-12-28 Thread Mark Thomas
Phil Steitz wrote: > I am not sure whether this is actually a bug, or worth reopening > POOL-97, but want to be safe rather than sorry before releasing 1.4. > > I am getting JVM hangs with the current code when I fail to close the > pool. This did not happen with the 1.3 code. The (admittedly sl

[pool] POOL-97 timer patch

2007-12-27 Thread Phil Steitz
I am not sure whether this is actually a bug, or worth reopening POOL-97, but want to be safe rather than sorry before releasing 1.4. I am getting JVM hangs with the current code when I fail to close the pool. This did not happen with the 1.3 code. The (admittedly sloppy) code in trunks-sandbox/