Re: [pool] 1.5-RC2 available for review

2009-06-02 Thread sebb
Ah, OK, I had not realised the allocation queue was separate. GOP does not have a numIdle count - it uses _pool.size() - so is probably OK. GKOP has a _totalIdle field, but it looks like it is being maintained. I'll try adding getNumIdle() ==0 checks after all clear() method calls. On 02/06/20

Re: [pool] 1.5-RC2 available for review

2009-06-02 Thread Phil Steitz
Sorry for top-post (degraded client ;) My understanding - which I guess could be made clearer in tha javadoc - is that clear is an operation on the *idle instance pool* and does not affect instances checked out or pending requests (allocation queue). Therefore, numActive should be unchanged by thi

Re: [pool] 1.5-RC2 available for review

2009-06-02 Thread sebb
On 02/06/2009, Phil Steitz wrote: > sebb wrote: > > > On 02/06/2009, Phil Steitz wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I just tried using the fixed numbers from a failed run (instead of > > > > > using random ones), and it fails every time with the followi

Re: [pool] 1.5-RC2 available for review

2009-06-02 Thread Phil Steitz
sebb wrote: On 02/06/2009, Phil Steitz wrote: > I just tried using the fixed numbers from a failed run (instead of using random ones), and it fails every time with the following settings: runs=26 Lengths=12,12,28 So it's clearly some kind of logic error - looks like it occurs

Re: [pool] 1.5-RC2 available for review

2009-06-02 Thread sebb
On 02/06/2009, Phil Steitz wrote: > > > > > > > > > > > > > > > > > I just tried using the fixed numbers from a failed run (instead of > > > using random ones), and it fails every time with the following > > > settings: > > > > > > runs=26 > > > Lengths=12,12,28 > > > > > > So it's clearly s

Re: [pool] 1.5-RC2 available for review

2009-06-01 Thread Phil Steitz
> I just tried using the fixed numbers from a failed run (instead of using random ones), and it fails every time with the following settings: runs=26 Lengths=12,12,28 So it's clearly some kind of logic error - looks like it occurs where "runs" is an exact multiple of "totalInstances".

Re: [pool] 1.5-RC2 available for review

2009-06-01 Thread sebb
On 01/06/2009, sebb wrote: > On 01/06/2009, sebb wrote: > > On 01/06/2009, sebb wrote: > > > On 01/06/2009, Phil Steitz wrote: > > > > Phil Steitz wrote: > > > > > > > > > sebb wrote: > > > > > > > > > > > On 31/05/2009, sebb wrote: > > > > > > > > > > > > > > > > >

Re: [pool] 1.5-RC2 available for review

2009-06-01 Thread sebb
On 01/06/2009, sebb wrote: > On 01/06/2009, sebb wrote: > > On 01/06/2009, Phil Steitz wrote: > > > Phil Steitz wrote: > > > > > > > sebb wrote: > > > > > > > > > On 31/05/2009, sebb wrote: > > > > > > > > > > > > > > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > sebb

Re: [pool] 1.5-RC2 available for review

2009-06-01 Thread sebb
On 01/06/2009, sebb wrote: > On 01/06/2009, Phil Steitz wrote: > > Phil Steitz wrote: > > > > > sebb wrote: > > > > > > > On 31/05/2009, sebb wrote: > > > > > > > > > > > > > On 31/05/2009, Phil Steitz wrote: > > > > > > sebb wrote: > > > > > > > > > > > > > On 31/05/2009, Phil St

Re: [pool] 1.5-RC2 available for review

2009-06-01 Thread sebb
On 01/06/2009, Phil Steitz wrote: > Phil Steitz wrote: > > > sebb wrote: > > > > > On 31/05/2009, sebb wrote: > > > > > > > > > > On 31/05/2009, Phil Steitz wrote: > > > > > sebb wrote: > > > > > > > > > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > > > > > > > > > > > > > sebb wrot

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread Phil Steitz
Phil Steitz wrote: sebb wrote: On 31/05/2009, sebb wrote: On 31/05/2009, Phil Steitz wrote: > sebb wrote: > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > sebb wrote: > > > > > > > > > > > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > > > > > > > > > > > > > > >

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread sebb
On 31/05/2009, sebb wrote: > On 31/05/2009, Phil Steitz wrote: > > sebb wrote: > > > > > On 31/05/2009, sebb wrote: > > > > > > > > > > On 31/05/2009, Phil Steitz wrote: > > > > > sebb wrote: > > > > > > > > > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > > > > > > > > >

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread sebb
On 31/05/2009, Phil Steitz wrote: > sebb wrote: > > > On 31/05/2009, sebb wrote: > > > > > > > On 31/05/2009, Phil Steitz wrote: > > > > sebb wrote: > > > > > > > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > > > > > > > > > > sebb wrote: > > > > > > > > > > > > > > > > > > > > >

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread Phil Steitz
sebb wrote: On 31/05/2009, sebb wrote: On 31/05/2009, Phil Steitz wrote: > sebb wrote: > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > sebb wrote: > > > > > > > > > > > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > > > > > > > > > > > > > > > Thanks to all who p

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread sebb
On 31/05/2009, sebb wrote: > On 31/05/2009, Phil Steitz wrote: > > sebb wrote: > > > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > > > > sebb wrote: > > > > > > > > > > > > > > > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > Thank

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread sebb
On 31/05/2009, Phil Steitz wrote: > sebb wrote: > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > sebb wrote: > > > > > > > > > > > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > > > > > > > > > > > > > > > Thanks to all who provided feedback on RC1. > > > > > > > > > > Changes in RC2

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread Phil Steitz
sebb wrote: On 31/05/2009, Phil Steitz wrote: sebb wrote: On 31/05/2009, Phil Steitz wrote: Thanks to all who provided feedback on RC1. Changes in RC2 * Fixed copyright date in NOTICE.txt * Restored development reports * Improved thread-safety and timing/reliability i

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread sebb
On 31/05/2009, Phil Steitz wrote: > sebb wrote: > > > On 31/05/2009, sebb wrote: > > > > > > > On 31/05/2009, sebb wrote: > > > > On 31/05/2009, Phil Steitz wrote: > > > > > Thanks to all who provided feedback on RC1. > > > > > > > > > > Changes in RC2 > > > > > > > > > > * Fixed c

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread sebb
On 31/05/2009, Phil Steitz wrote: > sebb wrote: > > > On 31/05/2009, Phil Steitz wrote: > > > > > > > Thanks to all who provided feedback on RC1. > > > > > > Changes in RC2 > > > > > > * Fixed copyright date in NOTICE.txt > > > * Restored development reports > > > * Improved thread-safety and

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread Phil Steitz
sebb wrote: On 31/05/2009, sebb wrote: On 31/05/2009, sebb wrote: > On 31/05/2009, Phil Steitz wrote: > > Thanks to all who provided feedback on RC1. > > > > Changes in RC2 > > > > * Fixed copyright date in NOTICE.txt > > * Restored development reports > > * Improved thr

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread Phil Steitz
sebb wrote: On 31/05/2009, Phil Steitz wrote: Thanks to all who provided feedback on RC1. Changes in RC2 * Fixed copyright date in NOTICE.txt * Restored development reports * Improved thread-safety and timing/reliability in GOP, GKOP tests - thanks, sebb! Unfortunately not enou

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread sebb
On 31/05/2009, sebb wrote: > On 31/05/2009, sebb wrote: > > On 31/05/2009, Phil Steitz wrote: > > > Thanks to all who provided feedback on RC1. > > > > > > Changes in RC2 > > > > > > * Fixed copyright date in NOTICE.txt > > > * Restored development reports > > > * Improved thr

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread Phil Steitz
Luc Maisonobe wrote: Phil Steitz a écrit : Thanks to all who provided feedback on RC1. Changes in RC2 * Fixed copyright date in NOTICE.txt * Restored development reports * Improved thread-safety and timing/reliability in GOP, GKOP tests - thanks, sebb! * Added link to release javadoc in si

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread sebb
On 31/05/2009, sebb wrote: > On 31/05/2009, Phil Steitz wrote: > > Thanks to all who provided feedback on RC1. > > > > Changes in RC2 > > > > * Fixed copyright date in NOTICE.txt > > * Restored development reports > > * Improved thread-safety and timing/reliability in GOP, GKOP tests

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread sebb
On 31/05/2009, Phil Steitz wrote: > Thanks to all who provided feedback on RC1. > > Changes in RC2 > > * Fixed copyright date in NOTICE.txt > * Restored development reports > * Improved thread-safety and timing/reliability in GOP, GKOP tests - > thanks, sebb! Unfortunately not enough, see be

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread Luc Maisonobe
Phil Steitz a écrit : > Thanks to all who provided feedback on RC1. > > Changes in RC2 > > * Fixed copyright date in NOTICE.txt > * Restored development reports > * Improved thread-safety and timing/reliability in GOP, GKOP tests - > thanks, sebb! > * Added link to release javadoc in site.xml >

Re: [pool] 1.5-RC2 available for review

2009-05-31 Thread Emmanuel Bourg
The distribution looks good. If you have to make a 3rd release candidate you may want to add a test on setConfig() and setFactory() in GenericKeyedObjectPool to improve the coverage. But don't hold the release for this. Emmanuel Bourg Phil Steitz a écrit : Thanks to all who provided feedba

[pool] 1.5-RC2 available for review

2009-05-30 Thread Phil Steitz
Thanks to all who provided feedback on RC1. Changes in RC2 * Fixed copyright date in NOTICE.txt * Restored development reports * Improved thread-safety and timing/reliability in GOP, GKOP tests - thanks, sebb! * Added link to release javadoc in site.xml * Fixed xml errors in changes.xml * Add