Re: [math] cleaning code

2011-03-28 Thread Luc Maisonobe
Le 28/03/2011 07:25, Phil Steitz a écrit : > On 3/27/11 6:31 PM, Phil Steitz wrote: >> On 3/27/11 9:47 AM, Luc Maisonobe wrote: >>> Hi all, >>> >>> I have squashed a number of findbugs and checkstyle warnings introduced >>> by recent changes (more than one hundred). >> Thanks! And sorry... >>> Ther

Re: [math] cleaning code

2011-03-27 Thread Phil Steitz
On 3/27/11 6:31 PM, Phil Steitz wrote: > On 3/27/11 9:47 AM, Luc Maisonobe wrote: >> Hi all, >> >> I have squashed a number of findbugs and checkstyle warnings introduced >> by recent changes (more than one hundred). > Thanks! And sorry... >> There are a few remaining bugs for which I would like so

Re: [math] cleaning code

2011-03-27 Thread Phil Steitz
On 3/27/11 9:47 AM, Luc Maisonobe wrote: > Hi all, > > I have squashed a number of findbugs and checkstyle warnings introduced > by recent changes (more than one hundred). Thanks! And sorry... > There are a few remaining bugs for which I would like some ideas. > > Checkstyle errors: > > In class Ma

Re: [math] cleaning code

2011-03-27 Thread Gilles Sadowski
On Sun, Mar 27, 2011 at 11:21:51PM +0200, Gilles Sadowski wrote: > [...] > It's a pity that CM cannot even rely on other Commons code (such as "Lang", > which contains a "Pair" class). > If this is still not an option (!), I'd rather remove the "SerializablePair" > class and change the code in "Mat

Re: [math] cleaning code

2011-03-27 Thread Gilles Sadowski
> In class MathUtils, method round(double x, int scale, int > roundingMethod) we catch RuntimeException to wrap it into > MathRuntimeException. I think we should not and should simply let the > RuntimeException go up. What do you think ? Agreed. > SerializablePair extends Pair which is not seria

Re: [math] cleaning code

2011-03-27 Thread Mikkel Meyer Andersen
Hi Luc, Thanks! I'll fix MannWhitneyUTestImpl. Cheers, Mikkel. Den 27/03/2011 18.48 skrev "Luc Maisonobe" : > Hi all, > > I have squashed a number of findbugs and checkstyle warnings introduced > by recent changes (more than one hundred). > > There are a few remaining bugs for which I would like

[math] cleaning code

2011-03-27 Thread Luc Maisonobe
Hi all, I have squashed a number of findbugs and checkstyle warnings introduced by recent changes (more than one hundred). There are a few remaining bugs for which I would like some ideas. Checkstyle errors: In class MannWhitneyUTestImpl, the javadoc for private method calculateAsymptoticPValue