Re: [math] Implementation of Conjugate Gradient (MATH-581)

2011-08-05 Thread Sébastien Brisard
Hi, I've attached a patch to modify the exceptions (exception.patch), and the updated files concerning the CG method. Sebastien 2011/8/4 Gilles Sadowski : >> [...] >> >> The management of the exception messages through String constants and enums >> is >> in my view a very clean thing. Should we d

Re: [math] Implementation of Conjugate Gradient (MATH-581)

2011-08-04 Thread Sébastien Brisard
2011/8/4 Gilles Sadowski : >> [...] >> >> The management of the exception messages through String constants and enums >> is >> in my view a very clean thing. Should we do the same for exception context >> keys? Have a big enum holding keys? > > I'd rather not, but I'm afraid that others will think

Re: [math] Implementation of Conjugate Gradient (MATH-581)

2011-08-04 Thread Gilles Sadowski
> [...] > > The management of the exception messages through String constants and enums is > in my view a very clean thing. Should we do the same for exception context > keys? Have a big enum holding keys? I'd rather not, but I'm afraid that others will think otherwise :-}. > Or should we define

Re: [math] Implementation of Conjugate Gradient (MATH-581)

2011-08-04 Thread Sebastien Brisard
2011/8/4 Gilles Sadowski : >> > >> >> I'm OK to define a new exception. From your PS, I understand that I should >> >> wait until what I've already submitted (MATH-581-06.zip) has been >> committed >> >> until I submit a patch containing the new exception. Is that right? >> > >> > I would have th

Re: [math] Implementation of Conjugate Gradient (MATH-581)

2011-08-04 Thread Ted Dunning
Actually if you just reattach revised files using the original names Kira will do a great job of managing which is the latest. That let's curious folk go back in history if they want to see what has changed. On Thursday, August 4, 2011, Gilles Sadowski wrote: >> > >> >> I'm OK to define a new exc

Re: [math] Implementation of Conjugate Gradient (MATH-581)

2011-08-04 Thread Gilles Sadowski
> > > >> I'm OK to define a new exception. From your PS, I understand that I should > >> wait until what I've already submitted (MATH-581-06.zip) has been > committed > >> until I submit a patch containing the new exception. Is that right? > > > > I would have thought the other way around: First co

Re: [math] Implementation of Conjugate Gradient (MATH-581)

2011-08-04 Thread Sebastien Brisard
Hi, thanks for your answer. 2011/8/4 Gilles Sadowski : > Hello. > >> I'm OK to define a new exception. From your PS, I understand that I should >> wait until what I've already submitted (MATH-581-06.zip) has been committed >> until I submit a patch containing the new exception. Is that right? > >

Re: [math] Implementation of Conjugate Gradient (MATH-581)

2011-08-04 Thread Gilles Sadowski
Hello. > I'm OK to define a new exception. From your PS, I understand that I should > wait until what I've already submitted (MATH-581-06.zip) has been committed > until I submit a patch containing the new exception. Is that right? I would have thought the other way around: First commit the excep

Re: [math] Implementation of Conjugate Gradient (MATH-581)

2011-08-04 Thread Sebastien Brisard
Hi Gilles, I'm OK to define a new exception. From your PS, I understand that I should wait until what I've already submitted (MATH-581-06.zip) has been committed until I submit a patch containing the new exception. Is that right? I don't think it's necessary to open a new JIRA ticket for this, do y

Re: [math] Implementation of Conjugate Gradient (MATH-581)

2011-08-04 Thread Gilles Sadowski
Hello. > please review a proposal for the definition of general iterative linear > solvers, as well as the implementation of the conjugate gradient method. This > is file MATH-581-06.zip attached to the JIRA MATH-581 ticket. > Thanks for your comments! > > Actually, I *do* have a comment. For the

[math] Implementation of Conjugate Gradient (MATH-581)

2011-08-03 Thread Sebastien Brisard
Hi, please review a proposal for the definition of general iterative linear solvers, as well as the implementation of the conjugate gradient method. This is file MATH-581-06.zip attached to the JIRA MATH-581 ticket. Thanks for your comments! Actually, I *do* have a comment. For the time being, new