Re: [math] Add temporary check for rare test failure.

2015-01-22 Thread sebb
On 22 January 2015 at 12:22, Thomas Neidhart wrote: > What about this change: > > if (x < 0.0) { > if (x < -746d) { > if (hiPrec != null) { > hiPrec[0] = 0.0; > hiPrec[1] = 0.0; > } > return

Re: [math] Add temporary check for rare test failure.

2015-01-22 Thread sebb
On 22 January 2015 at 11:44, sebb wrote: > On 22 January 2015 at 01:59, Phil Steitz wrote: >> On 1/21/15 4:56 PM, sebb wrote: >>> On 21 January 2015 at 20:39, Thomas Neidhart >>> wrote: On 01/21/2015 05:32 PM, Phil Steitz wrote: > On 1/21/15 3:43 AM, Thomas Neidhart wrote: >> Hi, >

Re: [math] Add temporary check for rare test failure.

2015-01-22 Thread Thomas Neidhart
What about this change: if (x < 0.0) { if (x < -746d) { if (hiPrec != null) { hiPrec[0] = 0.0; hiPrec[1] = 0.0; } return 0.0; } intVal = (int) -x; if (in

Re: [math] Add temporary check for rare test failure.

2015-01-22 Thread sebb
On 22 January 2015 at 01:59, Phil Steitz wrote: > On 1/21/15 4:56 PM, sebb wrote: >> On 21 January 2015 at 20:39, Thomas Neidhart >> wrote: >>> On 01/21/2015 05:32 PM, Phil Steitz wrote: On 1/21/15 3:43 AM, Thomas Neidhart wrote: > Hi, > > I have re-run the jenkins build for com

Re: [math] Add temporary check for rare test failure.

2015-01-21 Thread Phil Steitz
On 1/21/15 4:56 PM, sebb wrote: > On 21 January 2015 at 20:39, Thomas Neidhart > wrote: >> On 01/21/2015 05:32 PM, Phil Steitz wrote: >>> On 1/21/15 3:43 AM, Thomas Neidhart wrote: Hi, I have re-run the jenkins build for commons-math after this change several times, also on H1

Re: [math] Add temporary check for rare test failure.

2015-01-21 Thread sebb
On 21 January 2015 at 20:39, Thomas Neidhart wrote: > On 01/21/2015 05:32 PM, Phil Steitz wrote: >> On 1/21/15 3:43 AM, Thomas Neidhart wrote: >>> Hi, >>> >>> I have re-run the jenkins build for commons-math after this change several >>> times, also on H10 and it seems the test failures have disap

Re: [math] Add temporary check for rare test failure.

2015-01-21 Thread Thomas Neidhart
On 01/21/2015 05:32 PM, Phil Steitz wrote: > On 1/21/15 3:43 AM, Thomas Neidhart wrote: >> Hi, >> >> I have re-run the jenkins build for commons-math after this change several >> times, also on H10 and it seems the test failures have disappeared. >> >> Any objection to keep this? > > -0 > > Is th

Re: [math] Add temporary check for rare test failure.

2015-01-21 Thread Phil Steitz
On 1/21/15 3:43 AM, Thomas Neidhart wrote: > Hi, > > I have re-run the jenkins build for commons-math after this change several > times, also on H10 and it seems the test failures have disappeared. > > Any objection to keep this? -0 Is there a way to selectively suppress tests depending on JDK?

Re: [math] Add temporary check for rare test failure.

2015-01-21 Thread Thomas Neidhart
Hi, I have re-run the jenkins build for commons-math after this change several times, also on H10 and it seems the test failures have disappeared. Any objection to keep this? Thomas On Wed, Jan 21, 2015 at 12:42 AM, wrote: > Repository: commons-math > Updated Branches: > refs/heads/master 4