Re: [lang] Java 9 module investigations

2017-06-07 Thread Benedikt Ritter
Hi, > Am 23.05.2017 um 12:13 schrieb Emmanuel Bourg : > > Le 23/05/2017 à 00:52, Stephen Colebourne a écrit : > >> One final option is to declare an optional dependency on java.desktop, >> such that the AbstractCircuitBreaker will fail to load unless the >> end-user manually chooses to add java.

Re: [lang] Java 9 module investigations

2017-05-23 Thread Emmanuel Bourg
Le 23/05/2017 à 00:52, Stephen Colebourne a écrit : > One final option is to declare an optional dependency on java.desktop, > such that the AbstractCircuitBreaker will fail to load unless the > end-user manually chooses to add java.desktop. I don't like it, but it > may be a compromise for compat

Re: [lang] Java 9 module investigations

2017-05-22 Thread Gary Gregory
On Mon, May 22, 2017 at 3:52 PM, Stephen Colebourne wrote: > On 22 May 2017 at 23:29, Gary Gregory wrote: > > Don't you mean 4.0 since changing: > > > > - AbstractCircuitBreaker.addChangeListener(PropertyChangeListener) > > - AbstractCircuitBreaker.removeChangeListener(PropertyChangeListener) >

Re: [lang] Java 9 module investigations

2017-05-22 Thread Stephen Colebourne
On 22 May 2017 at 23:29, Gary Gregory wrote: > Don't you mean 4.0 since changing: > > - AbstractCircuitBreaker.addChangeListener(PropertyChangeListener) > - AbstractCircuitBreaker.removeChangeListener(PropertyChangeListener) > > would break BC? No. I meant 3.7. [lang] has a problem with versionin

Re: [lang] Java 9 module investigations

2017-05-22 Thread Gary Gregory
On Mon, May 22, 2017 at 1:10 PM, Stephen Colebourne wrote: > I took a stab at adding module-info.java to [lang]: > https://github.com/jodastephen/commons-lang/commit/ > 5d5dd6809eeef90ea2b6245c0d0a488fb917e30a > > Since the maven-bundle-plugin isn't working, I had to use antrun to > copy the modu

[lang] Java 9 module investigations

2017-05-22 Thread Stephen Colebourne
I took a stab at adding module-info.java to [lang]: https://github.com/jodastephen/commons-lang/commit/5d5dd6809eeef90ea2b6245c0d0a488fb917e30a Since the maven-bundle-plugin isn't working, I had to use antrun to copy the module-info.class file out and back in again. A gross hack. There are two ke