Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-26 Thread Gilles Sadowski
Hello. Le dim. 25 août 2019 à 18:08, Matt Juntunen a écrit : > > Hi Gilles, > > I like the idea of modifying the getVertices()/getVectorLoop() methods. > Perhaps we should move this discussion to JIRA so we can track it easier? Fine with me. Gilles > > > [...] ---

Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-25 Thread Matt Juntunen
Subject: Re: [geometry] GEOMTRY-32 Feedback Requested Hi. Le mer. 21 août 2019 à 04:42, Matt Juntunen a écrit : > > Gilles, > > ConvexSubPlane is the main class representing 3D facets. There are > convenience methods in the RegionBSPTree3D.Builder class for adding facets > dire

Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-21 Thread Gilles Sadowski
form)) > >.filter(f -> f.getPlane().getNormal().dot(vec) > 0) > >.forEach(tree::insert); > > > > -- or even -- > > > > RegionBSPTree3D tree; > > try (Stream stream = new > > OBJFacetSource("model.obj").facetStream()) { > >

Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-20 Thread Matt Juntunen
ances, either directly via ConvexSubPlane.fromVertexLoop() or indirectly via SubPlane.toConvex(). -Matt From: Gilles Sadowski Sent: Tuesday, August 20, 2019 8:58 AM To: Commons Developers List Subject: Re: [geometry] GEOMTRY-32 Feedback Requested Hello. Le lun. 19

Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-20 Thread Gilles Sadowski
; What do you think of this slightly modified approach? Looks neat. Regards, Gilles > > -Matt > > > From: Gilles Sadowski > Sent: Saturday, August 17, 2019 6:00 PM > To: Commons Developers List > Subject: Re: [geometry] GEOMTRY-32 Feedback

Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-18 Thread Matt Juntunen
es Sadowski Sent: Saturday, August 17, 2019 6:00 PM To: Commons Developers List Subject: Re: [geometry] GEOMTRY-32 Feedback Requested Hello. Le sam. 17 août 2019 à 04:58, Matt Juntunen a écrit : > > Hi Gilles, > > 1. I just rebased from master so hopefully that fixed the repo weirdness

Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-17 Thread Gilles Sadowski
region.getSize() + > "\nsurface area= " + region.getBoundarySize()); > > // Print out the vertices of the faces that make up the modified > // pyramid. The faces are not simplified; they represent the internal > // structure of the bsp tree. > System.out.pri

Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-16 Thread Matt Juntunen
e()); // Print out the vertices of the faces that make up the modified // pyramid. The faces are not simplified; they represent the internal // structure of the bsp tree. System.out.println("\n# Faces"); for (ConvexSubPlane face : region.boundaries()) { System.out.println(face.getVer

Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-16 Thread Gilles Sadowski
Hello Matt. Thanks for continuing to work on this. Le jeu. 15 août 2019 à 17:56, Matt Juntunen a écrit : > > Hi all, > > I've been working on the BSP tree refactor and general API cleanup for a > while now and I finally have the core and Euclidean classes complete. I have > the code in a draft

[geometry] GEOMTRY-32 Feedback Requested

2019-08-15 Thread Matt Juntunen
Hi all, I've been working on the BSP tree refactor and general API cleanup for a while now and I finally have the core and Euclidean classes complete. I have the code in a draft PR on github [1] and I'm hoping to get as much feedback on it as I can. Everything is in its final state from my poin