Re: [compress] poor test coverage of harmony code

2021-07-07 Thread PeterLee
This is great work. Thanks. cheers, Lee On Sat, Jul 3, 2021 at 10:15 PM Stefan Bodewig wrote: > On 2021-07-03, Stefan Bodewig wrote: > > > I assume the code originates from > > > https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/main/ > > and I'd look int

Re: [compress] poor test coverage of harmony code

2021-07-03 Thread Gary Gregory
Nice! Gary On Sat, Jul 3, 2021, 10:15 Stefan Bodewig wrote: > On 2021-07-03, Stefan Bodewig wrote: > > > I assume the code originates from > > > https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/main/ > > and I'd look into porting the tests from > > > htt

Re: [compress] poor test coverage of harmony code

2021-07-03 Thread Stefan Bodewig
On 2021-07-03, Stefan Bodewig wrote: > I assume the code originates from > https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack200/src/main/ > and I'd look into porting the tests from > https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/classlib/modules/pack

Re: [compress] poor test coverage of harmony code

2021-07-03 Thread Gary Gregory
Good idea, I mistakenly thought our coverage was better. Gary On Sat, Jul 3, 2021, 05:50 Stefan Bodewig wrote: > Hi > > our current pack200 tests don't seem to cover much of the pack200 code > imported from harmony and the overall test coverage of Compress as a > whole has dropped significantly

[compress] poor test coverage of harmony code

2021-07-03 Thread Stefan Bodewig
Hi our current pack200 tests don't seem to cover much of the pack200 code imported from harmony and the overall test coverage of Compress as a whole has dropped significantly (from 86% to 61%) as the new package contains quite a bit of code. I assume the code originates from https://svn.apache.or