Re: [compress] XZ support and inconsistencies in the existing compressors

2011-08-05 Thread Stefan Bodewig
Is this ? On 2011-08-04, Lasse Collin wrote: > On 2011-08-04 Stefan Bodewig wrote: >> On 2011-08-04, Lasse Collin wrote: >>> Yes. I didn't check the suggested fix though. >> Would be nice if you'd find the time to do so. > It uses in.av

Re: [compress] XZ support and inconsistencies in the existing compressors

2011-08-04 Thread Lasse Collin
On 2011-08-04 Stefan Bodewig wrote: > On 2011-08-04, Lasse Collin wrote: > > Using bits from the end of stream magic doesn't make sense, because > > then one would be forced to finish the stream. Using the bits from > > the block header magic means that one must add at least one more > > block. Thi

Re: [compress] XZ support and inconsistencies in the existing compressors

2011-08-04 Thread Stefan Bodewig
On 2011-08-04, Lasse Collin wrote: > On 2011-08-04 Stefan Bodewig wrote: >> This is in a big part due to the history of Commons Compress which >> combined several different codebases with separate APIs and provided a >> first attempt to layer a unifying API on top of it. We are aware of >> quite

Re: [compress] XZ support and inconsistencies in the existing compressors

2011-08-04 Thread Lasse Collin
On 2011-08-04 Stefan Bodewig wrote: > On 2011-08-03, Lasse Collin wrote: > > I looked at the APIs and code in Commons Compress to see how XZ > > support could be added. I was especially looking for details where > > one would need to be careful to make different compressors behave > > consistently

Re: [compress] XZ support and inconsistencies in the existing compressors

2011-08-03 Thread Stefan Bodewig
Hi Lasse and welcome On 2011-08-03, Lasse Collin wrote: > I have been working on XZ data compression implementation in Java > . I was told that it could be nice > to get XZ support into Commons Compress. Sounds interesting. > I looked at the APIs and code in Com

Re: [compress] XZ support and inconsistencies in the existing compressors

2011-08-03 Thread Simone Tripodi
Hi Lasse! I'd personally like if you could fill an Issue on Jira and submit your XZ implementation as a patch that naturally fits in the org.apache.commons.compress package and you continue contributing on maintaining it - maybe depending on an external package would be more difficult since commons

[compress] XZ support and inconsistencies in the existing compressors

2011-08-03 Thread Lasse Collin
Hi! I have been working on XZ data compression implementation in Java . I was told that it could be nice to get XZ support into Commons Compress. I looked at the APIs and code in Commons Compress to see how XZ support could be added. I was especially looking for d