Re: [compress] State of encoding support in ZIP package

2009-03-02 Thread Wolfgang Glas
Stefan Bodewig schrieb: > On 2009-03-01, Wolfgang Glas wrote: > >> My understanding from previous discussion was, that we need a mode, >> where file names not encodable by the chosen encoding are encoded in >> UTF-8, which is in turn indicated by setting the EFS flag on the >> likewise ZIP entry.

Re: [compress] State of encoding support in ZIP package

2009-03-02 Thread Stefan Bodewig
On 2009-03-01, Wolfgang Glas wrote: > My understanding from previous discussion was, that we need a mode, > where file names not encodable by the chosen encoding are encoded in > UTF-8, which is in turn indicated by setting the EFS flag on the > likewise ZIP entry. (That's the way 7-zip handles u

Re: [compress] State of encoding support in ZIP package

2009-03-01 Thread Wolfgang Glas
Stefan Bodewig schrieb: > On 2009-02-27, Wolfgang Glas wrote: > >> Additionally, my experience with WinZip shows, that WinZip writes weird >> filenames to the single-byte version of the filename when a unicode field is >> present. > > Hmm, native encoding I'd guess. Sth like this, looks like th

Re: [compress] State of encoding support in ZIP package

2009-02-27 Thread Stefan Bodewig
On 2009-02-27, Wolfgang Glas wrote: > Additionally, my experience with WinZip shows, that WinZip writes weird > filenames to the single-byte version of the filename when a unicode field is > present. Hmm, native encoding I'd guess. Wolfgang, could you do me a favor and please review what I've w

Re: [compress] State of encoding support in ZIP package

2009-02-27 Thread Wolfgang Glas
Stefan Bodewig schrieb: > On 2009-02-26, Wolfgang Glas wrote: > >> Stefan Bodewig schrieb: > >>> The question on defaults: should ZipFile look for UnicodeExtraFields >>> by default or ignore them (as it does right now)? > >> I'd do this by default, because IMHO we should have a 'smart' unzipper

Re: [compress] State of encoding support in ZIP package

2009-02-27 Thread Stefan Bodewig
On 2009-02-26, Wolfgang Glas wrote: > Stefan Bodewig schrieb: >> The question on defaults: should ZipFile look for UnicodeExtraFields >> by default or ignore them (as it does right now)? > I'd do this by default, because IMHO we should have a 'smart' unzipper in > commons-compress ;-) Convince

Re: [compress] State of encoding support in ZIP package

2009-02-26 Thread Stefan Bodewig
On 2009-02-26, Wolfgang Glas wrote: > Thanks for your tremendous work on finishing ZIP encoding support ;-) I had a good base to start from, thank you. 8-) > Stefan Bodewig schrieb: >> * documentation (will tackle that next) > May I help you at this point ? Any help anywhere is appreciated

Re: [compress] State of encoding support in ZIP package

2009-02-26 Thread Wolfgang Glas
Hi Stefan, Thanks for your tremendous work on finishing ZIP encoding support ;-) Stefan Bodewig schrieb: > Hi all, > > a quick update and a question on defaults: [snip] > * documentation (will tackle that next) May I help you at this point ? > * ZipArchiveInputStream - SANDBOX-293 Well, Z

[compress] State of encoding support in ZIP package

2009-02-26 Thread Stefan Bodewig
Hi all, a quick update and a question on defaults: ZipArchiveOutputStream now writes UTF-8 by default and sets the language encoding flag. It can be told to create InfoZIP UnicodeExtraFields but doesn't do so by default. ZipFile now recognized the language encoding flag and parses the names as