subject:"\[compress\] Marking a public Class non\-Public"

Re: [compress] Marking a public Class non-Public

2013-12-20 Thread Gary Gregory

I like the .internal. package convention (at least how Eclipse does it) but this will not stop someone from using methods in the class through inheritance but it makes it obvious if a class with a .internal. shows up in an import statement. Using "Private" or "Internal" or "Impl" in the class name

Re: [compress] Marking a public Class non-Public

2013-12-20 Thread sebb

On 20 December 2013 16:53, Stefan Bodewig wrote: > Hi > > in compress' trunk we now have to different stream classes that use > variants of LZW - the UNSHRINKING support in the zip package and the > ZCompresorInputStream. > > They looked so similar (and CPD was rightfully moaning about code > dupl

[compress] Marking a public Class non-Public

2013-12-20 Thread Stefan Bodewig

Hi in compress' trunk we now have to different stream classes that use variants of LZW - the UNSHRINKING support in the zip package and the ZCompresorInputStream. They looked so similar (and CPD was rightfully moaning about code duplication) that I decided to extract the common code into