Re: [compress] Closing Streams and System.in (COMPRESS-128)

2011-07-23 Thread Stefan Bodewig
On 2011-07-23, sebb wrote: > On 23 July 2011 12:45, Stefan Bodewig wrote: >> On 2011-07-23, Simone Tripodi wrote: >>> I personally like more the NoCloseStream approach, it would help >>> avoiding code redundancies (having the Sysout check pattern repeated >>> doesn't look nice IMHO) >> Yes, tha

Re: [compress] Closing Streams and System.in (COMPRESS-128)

2011-07-23 Thread sebb
On 23 July 2011 12:45, Stefan Bodewig wrote: > On 2011-07-23, Simone Tripodi wrote: > >> I personally like more the NoCloseStream approach, it would help >> avoiding code redundancies (having the Sysout check pattern repeated >> doesn't look nice IMHO) > > Yes, that would be my preference as well.

Re: [compress] Closing Streams and System.in (COMPRESS-128)

2011-07-23 Thread Stefan Bodewig
On 2011-07-23, Simone Tripodi wrote: > I personally like more the NoCloseStream approach, it would help > avoiding code redundancies (having the Sysout check pattern repeated > doesn't look nice IMHO) Yes, that would be my preference as well. Stefan -

Re: [compress] Closing Streams and System.in (COMPRESS-128)

2011-07-22 Thread Simone Tripodi
Hallo Stefan, I personally like more the NoCloseStream approach, it would help avoiding code redundancies (having the Sysout check pattern repeated doesn't look nice IMHO) HTH, have a nice day, all the best! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Sat, Jul 23, 20

[compress] Closing Streams and System.in (COMPRESS-128)

2011-07-22 Thread Stefan Bodewig
Hi, for reference The bzip2 inputstream checks whether its wrapped input stream is System.in before closing it. Do we want to add the same behavior to all other implementations or do we want to remove it from the bzip2 one and leave it to the