Re: [complex][math-util] dependencies

2016-12-15 Thread Gary Gregory
On Dec 15, 2016 6:03 AM, "Jörg Schaible" wrote: Hi Gary, Gary Gregory wrote: > On Tue, Dec 13, 2016 at 9:59 AM, Gilles > wrote: [snip] >> By the way, you don't need to refer to "Runtime" in the names; >> all exceptions in such codes should be unchecked. >> > > I would say "it depends". An ex

Re: [complex][math-util] dependencies

2016-12-15 Thread Jörg Schaible
Hi Gary, Gary Gregory wrote: > On Tue, Dec 13, 2016 at 9:59 AM, Gilles > wrote: [snip] >> By the way, you don't need to refer to "Runtime" in the names; >> all exceptions in such codes should be unchecked. >> > > I would say "it depends". An exception should be checked if it is > recoverable.

Re: [complex][math-util] dependencies

2016-12-13 Thread Gary Gregory
On Tue, Dec 13, 2016 at 9:59 AM, Gilles wrote: > On Tue, 13 Dec 2016 08:01:35 -0800, Gary Gregory wrote: > >> Two bad code smells: >> >> Do not use RuntimeException. Is IllegalArgumentException a possibility? >> > > Sure, the standard exception closest to the situation should be used. > > >> Don'

Re: [complex][math-util] dependencies

2016-12-13 Thread Gary Gregory
On Tue, Dec 13, 2016 at 9:59 AM, Gilles wrote: > On Tue, 13 Dec 2016 08:01:35 -0800, Gary Gregory wrote: > >> Two bad code smells: >> >> Do not use RuntimeException. Is IllegalArgumentException a possibility? >> > > Sure, the standard exception closest to the situation should be used. > > >> Don'

Re: [complex][math-util] dependencies

2016-12-13 Thread Gilles
On Tue, 13 Dec 2016 08:01:35 -0800, Gary Gregory wrote: Two bad code smells: Do not use RuntimeException. Is IllegalArgumentException a possibility? Sure, the standard exception closest to the situation should be used. Don't throw the exception in the new method, you will loose the compli

Re: [complex][math-util] dependencies

2016-12-13 Thread Gary Gregory
Two bad code smells: Do not use RuntimeException. Is IllegalArgumentException a possibility? Don't throw the exception in the new method, you will loose the complier's ability to warn you about certain code paths. You can create the exception in a new method though. Gary On Dec 13, 2016 5:57 AM

Re: [complex][math-util] dependencies

2016-12-13 Thread Eric Barnhill
On Tue, Nov 29, 2016 at 8:48 PM, Gilles wrote: > In "Commons RNG", I completely dropped all custom-made exceptions. > I suggest you do the same here. > IMO, "simple", low-level, components can do with just throwing > runtime exceptions from the standard library (with a hard-coded > _English_ mes

Re: [complex][math-util] dependencies

2016-11-30 Thread Gilles
On Tue, 29 Nov 2016 18:44:34 -0800, Gary Gregory wrote: On Tue, Nov 29, 2016 at 5:19 AM, Eric Barnhill wrote: I thought it would be good to raise a structural question here rather than in the commons-complex JIRA. The Complex library has multiple dependencies on three packages: -- commons-

Re: [complex][math-util] dependencies

2016-11-30 Thread Eric Barnhill
On Tue, Nov 29, 2016 at 8:48 PM, Gilles wrote: > Hello Eric. > > On Tue, 29 Nov 2016 14:19:54 +0100, Eric Barnhill wrote: > >> I thought it would be good to raise a structural question here rather than >> in the commons-complex JIRA. >> >> The Complex library has multiple dependencies on three pa

Re: [complex][math-util] dependencies

2016-11-29 Thread Gary Gregory
On Tue, Nov 29, 2016 at 5:19 AM, Eric Barnhill wrote: > I thought it would be good to raise a structural question here rather than > in the commons-complex JIRA. > > The Complex library has multiple dependencies on three packages: > > -- commons-math base classes (e.g. Field et al.) -- commons-m

Re: [complex][math-util] dependencies

2016-11-29 Thread Gilles
On Tue, 29 Nov 2016 12:26:53 -0800, Gary Gregory wrote: On Tue, Nov 29, 2016 at 11:39 AM, Jörg Schaible wrote: Hi Eric, Eric Barnhill wrote: > I thought it would be good to raise a structural question here rather than > in the commons-complex JIRA. > > The Complex library has multiple dep

Re: [complex][math-util] dependencies

2016-11-29 Thread Gary Gregory
On Tue, Nov 29, 2016 at 11:39 AM, Jörg Schaible wrote: > Hi Eric, > > Eric Barnhill wrote: > > > I thought it would be good to raise a structural question here rather > than > > in the commons-complex JIRA. > > > > The Complex library has multiple dependencies on three packages: > > > > -- common

Re: [complex][math-util] dependencies

2016-11-29 Thread Gary Gregory
On Tue, Nov 29, 2016 at 5:19 AM, Eric Barnhill wrote: > I thought it would be good to raise a structural question here rather than > in the commons-complex JIRA. > > The Complex library has multiple dependencies on three packages: > > -- commons-math base classes (e.g. Field et al.) > -- commons-

Re: [complex][math-util] dependencies

2016-11-29 Thread Gilles
Hello Eric. On Tue, 29 Nov 2016 14:19:54 +0100, Eric Barnhill wrote: I thought it would be good to raise a structural question here rather than in the commons-complex JIRA. The Complex library has multiple dependencies on three packages: -- commons-math base classes (e.g. Field et al.) Do y

Re: [complex][math-util] dependencies

2016-11-29 Thread Jörg Schaible
Hi Eric, Eric Barnhill wrote: > I thought it would be good to raise a structural question here rather than > in the commons-complex JIRA. > > The Complex library has multiple dependencies on three packages: > > -- commons-math base classes (e.g. Field et al.) > -- commons-math exceptions > -- c

[complex][math-util] dependencies

2016-11-29 Thread Eric Barnhill
I thought it would be good to raise a structural question here rather than in the commons-complex JIRA. The Complex library has multiple dependencies on three packages: -- commons-math base classes (e.g. Field et al.) -- commons-math exceptions -- commons-math util (numerous classes) Otherwise i