Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-13 Thread sebb
On Tue, 13 Feb 2024 at 00:40, sebb wrote: > > On Mon, 12 Feb 2024 at 16:40, Elliotte Rusty Harold > wrote: > > > > Be careful with this one. I don't have full context, but this looks > > likely to be a real bug on some code paths and perhaps not a bug on > > others. We'll need to make sure that

Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-12 Thread sebb
On Mon, 12 Feb 2024 at 16:40, Elliotte Rusty Harold wrote: > > Be careful with this one. I don't have full context, but this looks > likely to be a real bug on some code paths and perhaps not a bug on > others. We'll need to make sure that the patch for the broken code > path doesn't break a curre

Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-12 Thread Elliotte Rusty Harold
Be careful with this one. I don't have full context, but this looks likely to be a real bug on some code paths and perhaps not a bug on others. We'll need to make sure that the patch for the broken code path doesn't break a currently working path. Specifically I'm worried about where \r\n might and

Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-12 Thread Gary Gregory
Hi, Thank you for your email. I can't validate this without a test. The best path forward is for you to provide a PR in GitHub. TY! Gary On Mon, Feb 12, 2024, 10:15 AM Емельянов Юрий Владимирович wrote: > see FTPHTTPClient.tunnelHandshake > > current code is: > > if (proxyUsername !=

[commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-12 Thread Емельянов Юрий Владимирович
see FTPHTTPClient.tunnelHandshake current code is:     if (proxyUsername != null && proxyPassword != null) {     final String auth = proxyUsername + ":" + proxyPassword;     final String header = "Proxy-Authorization: Basic " + Base64.getEncoder().encodeToString(auth.getByte