Re: Feature Proposal: Add slice() utility with support for positive/negative indices and step for Collections, Arrays, and Strings

2025-07-27 Thread Glavo
nk about the whole class and how a new API fits in. Saying this lives > in > > a new class SliceUtils is not good IMO (see above on terminology). > > > > HTH, > > Gary > > > > > > > Regards, > > > Yokesh > > > > > > On Sun, Jul 27, 2025 at 10:0

Re: Feature Proposal: Add slice() utility with support for positive/negative indices and step for Collections, Arrays, and Strings

2025-07-27 Thread Yokesh Chowdary
the whole class and how a new API fits in. Saying this lives > in > > a new class SliceUtils is not good IMO (see above on terminology). > > > > HTH, > > Gary > > > > > > > Regards, > > > Yokesh > > > > > > On Sun, Jul 27, 2

Re: Feature Proposal: Add slice() utility with support for positive/negative indices and step for Collections, Arrays, and Strings

2025-07-27 Thread Peter Burka
n. Saying this lives in > a new class SliceUtils is not good IMO (see above on terminology). > > HTH, > Gary > > > > Regards, > > Yokesh > > > > On Sun, Jul 27, 2025 at 10:02 PM Gary Gregory > > wrote: > > > > > Hello Yokesh, > >

Re: Feature Proposal: Add slice() utility with support for positive/negative indices and step for Collections, Arrays, and Strings

2025-07-27 Thread Gary Gregory
bstring()). > > > > Gary > > > > On Sun, Jul 27, 2025, 12:06 Yokesh Chowdary > > wrote: > > > > > Hi All, > > > > > > I'd like to propose adding a new utility method slice() to Apache > Commons > > > Lang that brings Python-st

Re: Feature Proposal: Add slice() utility with support for positive/negative indices and step for Collections, Arrays, and Strings

2025-07-27 Thread Yokesh Chowdary
ls (substring()). > > Gary > > On Sun, Jul 27, 2025, 12:06 Yokesh Chowdary > wrote: > > > Hi All, > > > > I'd like to propose adding a new utility method slice() to Apache Commons > > Lang that brings Python-style slicing capabilities to Java for &

Re: Feature Proposal: Add slice() utility with support for positive/negative indices and step for Collections, Arrays, and Strings

2025-07-27 Thread Gary Gregory
hon-style slicing capabilities to Java for Collections, > arrays (primitive and wrapper types), and String. > The proposed method would follow the form: *slice(input, start, end, step)* > > This would be a highly reusable utility that simplifies what is currently > verbose or error-prone

Feature Proposal: Add slice() utility with support for positive/negative indices and step for Collections, Arrays, and Strings

2025-07-27 Thread Yokesh Chowdary
Hi All, I'd like to propose adding a new utility method slice() to Apache Commons Lang that brings Python-style slicing capabilities to Java for Collections, arrays (primitive and wrapper types), and String. The proposed method would follow the form: *slice(input, start, end, step)* This

[ANNOUNCE] Apache Commons Collections 4.5.0

2025-04-22 Thread Gary Gregory
The Apache Commons Collections team is pleased to announce the release of Apache Commons Collections 4.5.0. The Apache Commons Collections package contains types that extend and augment the Java Collections Framework. This is a feature and maintenance release. Java 8 or later is required. For

Re: [VOTE] Release Apache Commons Collections 4.5.0 based on RC1

2025-04-22 Thread Gary Gregory
On Tue, Apr 22, 2025 at 6:02 PM sebb wrote: > > On Tue, 22 Apr 2025 at 22:02, Samael Bate wrote: > > > > The build info says these artifacts were built with Java version: 23.0.2 > > > > That'll surely cause issues with users on earlier JDKs. Shouldn't releases > > be built with the lowest suppor

Re: [VOTE] Release Apache Commons Collections 4.5.0 based on RC1

2025-04-22 Thread sebb
On Tue, 22 Apr 2025 at 22:02, Samael Bate wrote: > > The build info says these artifacts were built with Java version: 23.0.2 > > That'll surely cause issues with users on earlier JDKs. Shouldn't releases be > built with the lowest supported JDK for maximum compatibility? I just unpacked commons

RE: [VOTE] Release Apache Commons Collections 4.5.0 based on RC1

2025-04-22 Thread Samael Bate
The build info says these artifacts were built with Java version: 23.0.2 That'll surely cause issues with users on earlier JDKs. Shouldn't releases be built with the lowest supported JDK for maximum compatibility? singingbush

[RESULT][VOTE] Release Apache Commons Collections 4.5.0 based on RC1

2025-04-22 Thread Gary Gregory
e have fixed a few bugs and added enhancements since Apache Commons > > Collections 4.5.0-M3 was released, so I would like to release Apache > > Commons Collections 4.5.0. > > > > Apache Commons Collections 4.5.0 RC1 is available for review here: > >https://dist.apache.

Re: [VOTE] Release Apache Commons Collections 4.5.0 based on RC1

2025-04-22 Thread Rob Tompkins
+1 > On Apr 19, 2025, at 10:11 AM, Gary Gregory wrote: > > We have fixed a few bugs and added enhancements since Apache Commons > Collections 4.5.0-M3 was released, so I would like to release Apache > Commons Collections 4.5.0. > > Apache Commons Collections 4.5.0 RC1 is

Re: [VOTE] Release Apache Commons Collections 4.5.0 based on RC1

2025-04-20 Thread Gary Gregory
My +1 Gary On Sun, Apr 20, 2025, 09:57 Henri Biestro wrote: > [+1] > > Build & tests ok, javadoc & changes ok, reports ok (nit: checkstyle 365 > errors, probably the same on each file). > > Built using: mvn clean install site -s "$HOME/.m2/commons-settings.xml" > On: mvn -version > Apache Mav

Re: [VOTE] Release Apache Commons Collections 4.5.0 based on RC1

2025-04-20 Thread Henri Biestro
[+1] Build & tests ok, javadoc & changes ok, reports ok (nit: checkstyle 365 errors, probably the same on each file). Built using: mvn clean install site -s "$HOME/.m2/commons-settings.xml" On: mvn -version Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home: /Users/hbiestr

[VOTE] Release Apache Commons Collections 4.5.0 based on RC1

2025-04-19 Thread Gary Gregory
We have fixed a few bugs and added enhancements since Apache Commons Collections 4.5.0-M3 was released, so I would like to release Apache Commons Collections 4.5.0. Apache Commons Collections 4.5.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/collections

Re: Commons Collections 3.2.2 End of Life?

2025-02-13 Thread Arnout Engelen
On Wed, Feb 12, 2025 at 4:22 PM Volodymyr Siedlecki wrote: > We are looking at collections4 as a possibility, but haven't determined if > we can upgrade yet. > That sounds reasonable. > The main issue is COLLECTIONS-701which is flagged by security scanners: > > ```

Re: Commons Collections 3.2.2 End of Life?

2025-02-13 Thread Julian Reschke
Am 12.02.2025 um 16:22 schrieb Volodymyr Siedlecki: We are looking at collections4 as a possibility, but haven't determined if we can upgrade yet. The main issue is COLLECTIONS-701which is flagged by security scanners: ``` The framework Apache Commons Collections before 4.3 is vulnerab

Re: Commons Collections 3.2.2 End of Life?

2025-02-12 Thread Gary Gregory
On Wed, Feb 12, 2025 at 10:10 AM sebb wrote: > > On Wed, 12 Feb 2025 at 14:53, Volodymyr Siedlecki wrote: > > > > Hello, > > > > I don't see it explicitly on the commons website, but is 3.2.2 end of Life? > > I'm assuming so (as there are no releases in 10 years), but I would like to > > double c

Re: Commons Collections 3.2.2 End of Life?

2025-02-12 Thread sebb
On Wed, 12 Feb 2025 at 15:22, Volodymyr Siedlecki wrote: > > We are looking at collections4 as a possibility, but haven't determined if we > can upgrade yet. > > The main issue is COLLECTIONS-701which is flagged by security scanners: > > ``` > The framework Apache C

Re: Commons Collections 3.2.2 End of Life?

2025-02-12 Thread Volodymyr Siedlecki
We are looking at collections4 as a possibility, but haven't determined if we can upgrade yet. The main issue is COLLECTIONS-701which is flagged by security scanners: ``` The framework Apache Commons Collections before 4.3 is vulnerable to Stack Overflow. The function add() in the file

Re: Commons Collections 3.2.2 End of Life?

2025-02-12 Thread sebb
On Wed, 12 Feb 2025 at 14:53, Volodymyr Siedlecki wrote: > > Hello, > > I don't see it explicitly on the commons website, but is 3.2.2 end of Life? > I'm assuming so (as there are no releases in 10 years), but I would like to > double check? Collections3 is no longer advertised on the download pa

Commons Collections 3.2.2 End of Life?

2025-02-12 Thread Volodymyr Siedlecki
Hello, I don't see it explicitly on the commons website, but is 3.2.2 end of Life? I'm assuming so (as there are no releases in 10 years), but I would like to double check? I ask since my team would like to backport a few fixes if there's any possibility for a 3.2.3 release. Thanks! Volodymyr

Collections. Proposition add Set over Patricia

2024-12-24 Thread Evgeniy Kuvardin
I have a proposition https://issues.apache.org/jira/browse/COLLECTIONS-873 I would like to make a MR. Please add comments if you have some thoughts or have some counterarguments. With best regards Kuvardin Evgeny

[RESULT][VOTE] Release Apache Commons Collections 4.5.0-M3 based on RC1

2024-12-18 Thread Gary Gregory
a/apache-maven-3.8.6 > Java version: 21.0.3, vendor: Azul Systems, Inc., runtime: > /Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "14.6.1", arch: "aarch64", fa

Re: [VOTE] Release Apache Commons Collections 4.5.0-M3 based on RC1

2024-12-17 Thread Henri Biestro
rch: "aarch64", family: "mac" hbiestro@D3CC9YTYXF-Henri-Biestro commons-collections-4.5.0-M3-RC1 % Cheers, Henrib - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons Collections 4.5.0-M3 based on RC1

2024-12-17 Thread Gary Gregory
My +1 Gary On Sun, Dec 15, 2024, 11:51 AM Piotr P. Karwasz wrote: > Hi Gary, > > On 15.12.2024 16:46, Gary Gregory wrote: > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > >[ ] +1 Release these artifacts > >[ ] +0 OK, but

Re: [VOTE] Release Apache Commons Collections 4.5.0-M3 based on RC1

2024-12-15 Thread Piotr P. Karwasz
Hi Gary, On 15.12.2024 16:46, Gary Gregory wrote: Please review the release candidate and vote. This vote will close no sooner than 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... * The

[VOTE] Release Apache Commons Collections 4.5.0-M3 based on RC1

2024-12-15 Thread Gary Gregory
Since Apache Commons Collections 4.5.0-M2 was released, we have fixed a few bugs and added enhancements, so I would like to release Apache Commons Collections 4.5.0-M3. Apache Commons Collections 4.5.0-M3 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons

Re: [collections] BloomFilterExtractor.flatten()

2024-11-03 Thread Gary Gregory
On Sun, Nov 3, 2024 at 4:05 AM Claude Warren wrote: > I believe I answered this elsewhere but just for clarity in the archive. > > I believe the MultidimensionalBloomFilters add a new level of complexity > that we do not want to address at this time. I also believe that > MultidimensionalBloomFi

Re: [collections] BloomFilterExtractor.flatten()

2024-11-03 Thread Claude Warren
I believe I answered this elsewhere but just for clarity in the archive. I believe the MultidimensionalBloomFilters add a new level of complexity that we do not want to address at this time. I also believe that MultidimensionalBloomFilters will not break binary compatibility. They should extend

Re: [collections] Multidimensional Bloom Filters (was BloomFilterExtractor.flatten)

2024-10-16 Thread Claude Warren
s question for a week now but time > always > > seems to get away and it is a rather long discussion. > > > > Multidimensional Bloom filters are basically any collection of Bloom > > filters. However they have very different capabilities and usages. I > wrote > >

Re: [collections] Multidimensional Bloom Filters (was BloomFilterExtractor.flatten)

2024-10-12 Thread Gary Gregory
seems to get away and it is a rather long discussion. > > Multidimensional Bloom filters are basically any collection of Bloom > filters. However they have very different capabilities and usages. I wrote > an introduction to Multidimensional Bloom filters ( > > https://github.com/

Re: [collections] Multidimensional Bloom Filters (was BloomFilterExtractor.flatten)

2024-10-12 Thread Gary Gregory
ut time always > seems to get away and it is a rather long discussion. > > Multidimensional Bloom filters are basically any collection of Bloom > filters. However they have very different capabilities and usages. I wrote > an introduction to Multidimensional Bloom filters ( > > https:/

Re: [collections] Multidimensional Bloom Filters (was BloomFilterExtractor.flatten)

2024-10-12 Thread Gary Gregory
ut time always > seems to get away and it is a rather long discussion. > > Multidimensional Bloom filters are basically any collection of Bloom > filters. However they have very different capabilities and usages. I wrote > an introduction to Multidimensional Bloom filters ( > >

Re: [collections] Multidimensional Bloom Filters (was BloomFilterExtractor.flatten)

2024-10-12 Thread Gary Gregory
; > Multidimensional Bloom filters are basically any collection of Bloom > filters. However they have very different capabilities and usages. I wrote > an introduction to Multidimensional Bloom filters ( > > https://github.com/apache/commons-collections/blob/master/src/site/markdown/

Re: [collections] Multidimensional Bloom Filters (was BloomFilterExtractor.flatten)

2024-10-12 Thread Gary Gregory
bit longer. > > > > > > Claude > > > > I have been meaning to answer this question for a week now but time always > seems to get away and it is a rather long discussion. > > Multidimensional Bloom filters are basically any collection of Bloom > filters. Howev

[collections] Multidimensional Bloom Filters (was BloomFilterExtractor.flatten)

2024-10-12 Thread Claude Warren
Bloom filters. However they have very different capabilities and usages. I wrote an introduction to Multidimensional Bloom filters ( https://github.com/apache/commons-collections/blob/master/src/site/markdown/bloomFilters/multidimensional.md) but I can’t seem to find it online. Perhaps it does not get

Re: [collections] BloomFilterExtractor.flatten()

2024-10-06 Thread Gary Gregory
Thank you Claude, the git master code now throws instead of returning null. We can delay MultidimensionalBloomFilter unless introducing it later would break binary compatibility. How beneficial would introducing this interface for users? Gary On Sun, Oct 6, 2024, 10:58 AM Claude Warren wrote:

Re: [collections] BloomFilterExtractor.flatten()

2024-10-06 Thread Claude Warren
This is starting tondelve into the realm of multidimensional bloom filters. I think throwing an exception on a null or zero length array is acceptable. We could define an interface MultidimensionalBloomFilter that could be implemented by any Bloom filter that comprises multiple filters and givr i

Re: [collections] Does WrappedBloomFilterTest make sense?

2024-10-06 Thread Claude Warren
> > final BloomFilter inner = new > > > DefaultBloomFilterTest.SparseDefaultBloomFilter(shape) { > > > @Override > > > public int characteristics() { > > > return characteristics; > > > } >

Re: [collections] Does WrappedBloomFilterTest make sense?

2024-10-05 Thread Gary Gregory
rappedBloomFilter underTest = new Fixture(inner); > > assertEquals(characteristics, underTest.characteristics()); > > } > > > > WDYT? > > > > Let's skip discussing the signature of the copy() method, I'll write a > > separate email late

Re: [collections] Does WrappedBloomFilterTest make sense?

2024-10-05 Thread Gary Gregory
ape)); > >>> } > >>> > >>> @ParameterizedTest > >>> @ValueSource(ints = {0, 1, 34}) > >>> public void testCharacteristics(final int characteristics) { > >>> final Shape shape = getTestShape(); > >>> final Blo

Re: [collections] BloomFilterExtractor.flatten()

2024-10-05 Thread Gary Gregory
On Fri, Oct 4, 2024 at 1:30 PM Alex Herbert wrote: > You cannot return an empty BloomFilter when there is no array of > BloomFilters to flatten. The BloomFilter is tied to a Shape. Without a > shape you cannot know what size filter to create. So we have to return > null or throw an exception. Wha

Re: [collections] Does WrappedBloomFilterTest make sense?

2024-10-05 Thread Claude Warren
nt characteristics) { >>> final Shape shape = getTestShape(); >>> final BloomFilter inner = new >>> DefaultBloomFilterTest.SparseDefaultBloomFilter(shape) { >>> @Override >>> public int characteristics() { >>>

Re: [collections] Does WrappedBloomFilterTest make sense?

2024-10-05 Thread Claude Warren
public int characteristics() { >> return characteristics; >> } >> }; >> final WrappedBloomFilter underTest = new Fixture(inner); >> assertEquals(characteristics, underTest.characteristics()); >> } >>

Re: [collections] Does WrappedBloomFilterTest make sense?

2024-10-05 Thread Claude Warren
return characteristics; > } > }; > final WrappedBloomFilter underTest = new Fixture(inner); > assertEquals(characteristics, underTest.characteristics()); > } > > WDYT? > > Let's skip discussing the signature of the copy() method, I'll

[collections] Does WrappedBloomFilterTest make sense?

2024-10-05 Thread Gary Gregory
TY, Gary [0] https://github.com/apache/commons-collections/blob/730d972cdebb13dd3a896eb5b90ebc9e1f594d5b/src/test/java/org/apache/commons/collections4/bloomfilter/WrappedBloomFilterTest.java#L26-L56 [1] The above link in WrappedBloomFilterTest is: @Override protected WrappedB

Re: [collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Gary Gregory
The problem with returning null is that all call sites must now check for null or end up throwing an NPE. I'd prefer to fail sooner rather than later, so I'd go with throwing an exception and updating the Javadoc. WDYT? Gary On Fri, Oct 4, 2024, 1:30 PM Alex Herbert wrote: > You cannot return

Re: [collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Alex Herbert
You cannot return an empty BloomFilter when there is no array of BloomFilters to flatten. The BloomFilter is tied to a Shape. Without a shape you cannot know what size filter to create. So we have to return null or throw an exception. Whatever choice must be documented. Note we do not currently ch

Re: [collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Gary Gregory
OK, but how do you create an empty filter? Gary On Fri, Oct 4, 2024, 12:54 PM Claude Warren wrote: > I think that it should return an empty filter as the javadoc says > > > On Fri 4 Oct 2024, 15:53 Gary D. Gregory, wrote: > > > See the new disabled test BloomFilterExtractorTest. > > > > Gary >

Re: [collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Claude Warren
I think that it should return an empty filter as the javadoc says On Fri 4 Oct 2024, 15:53 Gary D. Gregory, wrote: > See the new disabled test BloomFilterExtractorTest. > > Gary > > On 2024/10/04 14:51:55 "Gary D. Gregory" wrote: > > Hi Claude and all, > > > > The method: > > > > > org.apache.c

Re: [collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Gary D. Gregory
See the new disabled test BloomFilterExtractorTest. Gary On 2024/10/04 14:51:55 "Gary D. Gregory" wrote: > Hi Claude and all, > > The method: > > org.apache.commons.collections4.bloomfilter.BloomFilterExtractor.flatten() > > is documented as always returning a BloomFilter: > > /** >

[collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Gary D. Gregory
Hi Claude and all, The method: org.apache.commons.collections4.bloomfilter.BloomFilterExtractor.flatten() is documented as always returning a BloomFilter: /** * Create a standard (non-layered) Bloom filter by merging all of the layers. If * the filter is empty this method will re

Re: [validator] Collections 4

2024-10-01 Thread Xeno Amess
after all a nexus server is easy to setup... From: Xeno Amess Sent: Wednesday, October 2, 2024 1:41:40 AM To: Commons Developers List Subject: Re: [validator] Collections 4 well if you be very hurry you can use a fork for some months... (like what I did for

Re: [validator] Collections 4

2024-10-01 Thread Xeno Amess
well if you be very hurry you can use a fork for some months... (like what I did for tomcat&maven... From: Josh Fenlason Sent: Tuesday, October 1, 2024 11:40:58 PM To: Commons Developers List Subject: RE: [validator] Collections 4 Gary, I appreciate all the

RE: [validator] Collections 4

2024-10-01 Thread Josh Fenlason
the end of October at the latest so I can avoid having to do my own fork of the library. Thanks, Josh. -Original Message- From: Gary Gregory Sent: Wednesday, September 25, 2024 3:24 PM To: Commons Developers List Subject: Re: [validator] Collections 4 CAUTION: This email originated

Re: [validator] Collections 4

2024-09-25 Thread Gary Gregory
On Wed, Sep 25, 2024 at 4:06 PM Josh Fenlason wrote: > > Is the Validator 2.0 release still being planned for the near future? Yes, maybe within a month or so. > > Is that PR for moving the Commons Collections dependency from 3 to 4 still in > active? Or would it help for

RE: [validator] Collections 4

2024-09-25 Thread Josh Fenlason
Is the Validator 2.0 release still being planned for the near future? Is that PR for moving the Commons Collections dependency from 3 to 4 still in active? Or would it help for someone to take another pass at that? The package structure still needs to be updated from

Re: [Collections] Bad download links in the Download web page

2024-09-13 Thread Gary Gregory
Hi Cpm, The next site update will only offer the 4.5.x version for download. Please use 4.5.x. Gary On Fri, Sep 13, 2024, 9:04 AM Christian P. MOMON wrote: > >Hi, > >In the web page "Download Apache Commons Collections" > (https://commo

[Collections] Bad download links in the Download web page

2024-09-13 Thread Christian P. MOMON
Hi, In the web page "Download Apache Commons Collections" (https://commons.apache.org/collections/download_collections.cgi), only download links about version 4.5.0-M2 are ok. All other versions (4.2, 4.1 and 3.2.2) have their download links giving "404 Not Found error&

RE: [validator] Collections 4

2024-09-11 Thread Josh Fenlason
I was looking through the jira items for validator. I see one item that looks like it would be necessary for a Validator 2.X release, VALIDATOR-390, for updating to Commons Collections 4. I see a relatively recent PR, https://github.com/apache/commons-validator/pull/53, for that though. I

RE: [validator] Collections 4

2024-09-04 Thread Gary D. Gregory
eye. Gary > > -Original Message- > From: Gary Gregory > Sent: Tuesday, September 3, 2024 2:53 PM > To: Commons Developers List > Subject: Re: [validator] Collections 4 > > > CAUTION: This email originated from outside the organization. Do not click > lin

RE: [validator] Collections 4

2024-09-03 Thread Josh Fenlason
That is great to hear! Is there anything I can do to assist with that? -Original Message- From: Gary Gregory Sent: Tuesday, September 3, 2024 2:53 PM To: Commons Developers List Subject: Re: [validator] Collections 4 CAUTION: This email originated from outside the organization. Do

Re: [validator] Collections 4

2024-09-03 Thread Gary Gregory
I am planning on what will likely be a new major version as we cannot break binary compatibility. Maybe within the next few weeks. Gary On Tue, Sep 3, 2024, 3:10 PM Josh Fenlason wrote: > I have requirements to eliminate collections3 from my project. > The latest Validator released is dependent

[validator] Collections 4

2024-09-03 Thread Josh Fenlason
I have requirements to eliminate collections3 from my project. The latest Validator released is dependent on collections3 though. What are the chances of a new Validator release that is dependent on collections4? What could I do to assist with making that happen? Thanks, Josh.

Re: COLLECTIONS-701 vs 3.2.x

2024-07-30 Thread Gary Gregory
I do not think we should open up 3.x for more releases. Gary On Tue, Jul 30, 2024, 10:49 AM Julian Reschke wrote: > Hi there, > > I'm working on a project which unfortunately is stuck with > commons-collections3 for the time being (if you wonder why: somebody > exposed the cc3 Predicate class i

COLLECTIONS-701 vs 3.2.x

2024-07-30 Thread Julian Reschke
Hi there, I'm working on a project which unfortunately is stuck with commons-collections3 for the time being (if you wonder why: somebody exposed the cc3 Predicate class in our public API, and it takes time to deprecate and remove). That said, we noticed that the fix for the issue above can easi

Re: [collections] Predicate vs PredicateUtils

2024-07-11 Thread Gary Gregory
Hello Juilan, I think this should be a driver for Collections 5 because: - we don't want to break BC - what would start with copy pasta for one class could degenerate into a ton of it WDYT? Gary On Mon, Jul 8, 2024, 6:21 AM Julian Reschke wrote: > On 08.07.2024 11:18, Julian Resch

Re: [collections] Predicate vs PredicateUtils

2024-07-08 Thread Julian Reschke
On 08.07.2024 11:18, Julian Reschke wrote: On 07.07.2024 17:12, Gary Gregory wrote: We don't want to break binary compatibility within the 4.x release line. Gary ... Would we have to? OK, so this is about the return values. It's still unfortunate, because it makes it harder to convert exis

Re: [collections] Predicate vs PredicateUtils

2024-07-08 Thread Julian Reschke
On 07.07.2024 17:12, Gary Gregory wrote: We don't want to break binary compatibility within the 4.x release line. Gary ... Would we have to? Best regards, Julian - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org F

Re: [collections] Predicate vs PredicateUtils

2024-07-07 Thread sendi Tho
  you are correct. it was using some older transitive deps.. resolved.  thank you for your patience .   Sent: Sunday, July 07, 2024 at 11:12 AM From: "Gary Gregory" To: julian.resc...@gmx.de.invalid Cc: "Commons Developers List" Subject: Re: [collections] Predicate vs Pre

Re: [collections] Predicate vs PredicateUtils

2024-07-07 Thread Gary Gregory
return > commons-collections3's Predicates. > > CC4 deprecates the custom Predicate class (good!), and these just extend > JDK Predicates > ( > https://commons.apache.org/proper/commons-collections/apidocs/org/apache/commons/collections4/Predicate.html > ). > >

RE: Re: [COLLECTIONS] CartesianProductIterator

2024-07-04 Thread Oleksii Pelykh
Absolutely true that same functionality can be achieved with a nested for-loop or a flatMap, however for a 10+ nesting levels - or dynamic number/order of nesting levels - it becomes hardly manageable. On 2024/06/26 21:02:53 Peter Burka wrote: > I don't know if it's been proposed before, but I t

[collections] Predicate vs PredicateUtils

2024-07-01 Thread Julian Reschke
roper/commons-collections/apidocs/org/apache/commons/collections4/Predicate.html). However, PredicateUtils (for instance https://commons.apache.org/proper/commons-collections/apidocs/org/apache/commons/collections4/PredicateUtils.html#anyPredicate(java.util.Collection)) still require use of co

Re: [COLLECTIONS] CartesianProductIterator

2024-06-26 Thread Peter Burka
I don't know if it's been proposed before, but I think any implementation would necessarily be inefficient. I imagine such an iterator would need to produce objects of type Pair. This would lead to a lot of allocation and could create garbage collection pressure. The same functionality can be achie

[COLLECTIONS] CartesianProductIterator

2024-06-26 Thread Alexey Pelykh
G'day to all! It seems there's no Iterator that would implement the same thing as Python's itertools.product (quite literally a nested for loop) with some Java stream() capabilities. Is this intentional (as in, was considered and rejected) or a PR with such CartesianProductIterator would be wel

[ANNOUNCE] Apache Commons Collections 4.5.0-M2

2024-06-18 Thread Gary Gregory
The Apache Commons team is pleased to announce Commons Collections 4.5.0-M2, the second milestone release toward 4.5.0. Commons Collections contains types that extend and augment the Java Collections Framework. This milestone release requires Java 8 and makes small changes to the package

[RESULT][VOTE] Release Apache Commons Collections 4.5.0-M2 based on RC1

2024-06-18 Thread Gary Gregory
; We have fixed a few bugs and added enhancements since Apache Commons > > Collections 4.5.0-M1 was released, so I would like to release Apache > > Commons Collections 4.5.0-M2. > > > > Apache Commons Collections 4.5.0-M2 RC1 is available for review here: > >https:/

Re: [VOTE] Release Apache Commons Collections 4.5.0-M2 based on RC1

2024-06-16 Thread Rob Tompkins
+1 > On Jun 14, 2024, at 10:48 PM, Gary Gregory wrote: > > We have fixed a few bugs and added enhancements since Apache Commons > Collections 4.5.0-M1 was released, so I would like to release Apache > Commons Collections 4.5.0-M2. > > Apache Commons Collections 4.5.0-M2

Re: [COLLECTIONS] 4.5.0-M2 is next to capture latest bloom filter code

2024-06-16 Thread Gary D. Gregory
The RC is available :) On 2024/06/13 14:04:47 Gary Gregory wrote: > That all sounds good to me. I'll cut a release over the next few days. > > Gary > > On Thu, Jun 13, 2024, 9:48 AM Claude Warren wrote: > > > Given the hectic nature of my life at the moment, I would say longer than a > > week.

Re: [COLLECTIONS] documentation question

2024-06-15 Thread Gary Gregory
Feel free to write the docs in whatever format you want :-) It just needs to build with Maven (prefereably) Gary On Sat, Jun 15, 2024 at 12:07 PM Phil Steitz wrote: > > On Sat, Jun 15, 2024 at 8:19 AM Claude Warren wrote: > > > Greetings, > > > > I see that we support xml documents for document

Re: [COLLECTIONS] documentation question

2024-06-15 Thread Gary Gregory
We (well, not me) are revamping the Log4j site documentation using AsciiDoc. Take a look there if you're curious. Gary On Sat, Jun 15, 2024 at 12:07 PM Phil Steitz wrote: > > On Sat, Jun 15, 2024 at 8:19 AM Claude Warren wrote: > > > Greetings, > > > > I see that we support xml documents for do

Re: [VOTE] Release Apache Commons Collections 4.5.0-M2 based on RC1

2024-06-15 Thread Gary Gregory
yle report is strangely wonky. RAT is fine and headers look fine > to me, but Checkstyle is, um, confused > > Phil > > On Fri, Jun 14, 2024 at 7:49 PM Gary Gregory wrote: > > > We have fixed a few bugs and added enhancements since Apache Commons > > Collections 4.5.0

Re: [VOTE] Release Apache Commons Collections 4.5.0-M2 based on RC1

2024-06-15 Thread Gary Gregory
My +1 Gary On Fri, Jun 14, 2024 at 10:48 PM Gary Gregory wrote: > > We have fixed a few bugs and added enhancements since Apache Commons > Collections 4.5.0-M1 was released, so I would like to release Apache > Commons Collections 4.5.0-M2. > > Apache Commons Collectio

Re: [VOTE] Release Apache Commons Collections 4.5.0-M2 based on RC1

2024-06-15 Thread Phil Steitz
xed a few bugs and added enhancements since Apache Commons > Collections 4.5.0-M1 was released, so I would like to release Apache > Commons Collections 4.5.0-M2. > > Apache Commons Collections 4.5.0-M2 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/common

Re: [COLLECTIONS] documentation question

2024-06-15 Thread Phil Steitz
On Sat, Jun 15, 2024 at 8:19 AM Claude Warren wrote: > Greetings, > > I see that we support xml documents for documentation but does anyone know > if markdown is supported? I have a number of markdown based documents that > would work well for the Bloom filter documentation, but translating to X

[COLLECTIONS] documentation question

2024-06-15 Thread Claude Warren
Greetings, I see that we support xml documents for documentation but does anyone know if markdown is supported? I have a number of markdown based documents that would work well for the Bloom filter documentation, but translating to XML will be a pain. thanks, Claude

[VOTE] Release Apache Commons Collections 4.5.0-M2 based on RC1

2024-06-14 Thread Gary Gregory
We have fixed a few bugs and added enhancements since Apache Commons Collections 4.5.0-M1 was released, so I would like to release Apache Commons Collections 4.5.0-M2. Apache Commons Collections 4.5.0-M2 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons

Re: [COLLECTIONS] 4.5.0-M2 is next to capture latest bloom filter code

2024-06-13 Thread Gary Gregory
That all sounds good to me. I'll cut a release over the next few days. Gary On Thu, Jun 13, 2024, 9:48 AM Claude Warren wrote: > Given the hectic nature of my life at the moment, I would say longer than a > week. > Would it make sense to do an M2 to verify the APIs and then lock down and > comb

Re: [COLLECTIONS] 4.5.0-M2 is next to capture latest bloom filter code

2024-06-13 Thread Claude Warren
Given the hectic nature of my life at the moment, I would say longer than a week. Would it make sense to do an M2 to verify the APIs and then lock down and comb through documentation with a fine tooth comb, looking for errors and missing explanations before an M3 that has no code, just documentatio

Re: [COLLECTIONS] 4.5.0-M2 is next to capture latest bloom filter code

2024-06-13 Thread Gary Gregory
It would be better IMO to have the updated documentation for M2 but not critical, let me know if you think you can do it "soon" (say within a week) or if it's just on a longer term to-do list. TY, Gary On Thu, Jun 13, 2024, 3:39 AM Claude Warren wrote: > The only changes I am considering are to

Re: [COLLECTIONS] 4.5.0-M2 is next to capture latest bloom filter code

2024-06-13 Thread Claude Warren
The only changes I am considering are to remove any stream usage within the code, no external changes. Additionally, there may be some new documentation coming but that can wait until after M2. Thanks for all your hard work on this. Claude On Wed, Jun 12, 2024 at 7:30 PM Gary D. Gregory wrote:

[COLLECTIONS] 4.5.0-M2 is next to capture latest bloom filter code

2024-06-12 Thread Gary D. Gregory
HI All, Claude W, Alex H: I would like to cut a 4.5.0-M2 RC later this week to capture latest bloom filter code. Feel free to ask me to hold back if you plan further changes first. TY! Gary - To unsubscribe, e-mail: dev-unsubs

Re: [COLLECTIONS/Bloomfilter] A question of streams

2024-06-11 Thread Alex Herbert
You need to test it with some realistic data for a benchmark. In Commons Statistics we have a case where all elements of an array are passed to a consumer. So you have either: int[] a = ... IntConsumer c = ... Arrays.stream(a).forEach(c::accept) vs for (final int i : a) { c.accept(i); } W

[COLLECTIONS/Bloomfilter] A question of streams

2024-06-11 Thread Claude Warren
There is/was a discussion in Cassandra Dev recently about the overhead of Java Streaming vs simple loops/iteration. The consensus there is that streams should not be used in the hot path. Discussion then devolved into determining hot path or banning outright. My question is should we remove the

Re: [Collections] Implementation of EnhancedDoubleHasher

2024-06-07 Thread Claude Warren
Pull request https://github.com/apache/commons-collections/pull/501 addresses this issue - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[Collections] Implementation of EnhancedDoubleHasher

2024-05-18 Thread Juan Manuel Gimeno Illa
The code in the implementation of the EnhancedDoubleHasher is based on the wikipedia article https://en.wikipedia.org/wiki/Double_hashing. The code that appears in the article is: struct key; /// Opaque /// Use other data types when needed. (Must be unsigned for guaranteed wrapping.) extern unsi

Re: [Collections] Implementation of EnhancedDoubleHasher

2024-05-18 Thread Alex Herbert
Tracking this with: https://issues.apache.org/jira/browse/COLLECTIONS-855 On Sat, 18 May 2024 at 08:26, Alex Herbert wrote: > Thanks for highlighting this. I did not use the original paper and based > the implementation on Wikipedia. > > I think the issue is that we use i in [0

Re: [Collections] Implementation of EnhancedDoubleHasher

2024-05-18 Thread Alex Herbert
Thanks for highlighting this. I did not use the original paper and based the implementation on Wikipedia. I think the issue is that we use i in [0, k); we can correct this by using i in [1, k]. The order inside the loop would not change but we would have to decrement i to use in the assignment giv

  1   2   3   4   5   6   7   8   9   10   >