Heh - pretty sure the 2.0/1.0 bit is me :)
Given I'd written a 1.0 impl first, I think I simply didn't want to
lose the code.
If you think there's value in both, then I'm all for it. I think at
the time I was implementing something fun and didn't know if 2.0 was a
replacement for 1.0 or not. I di
I am not a SME in Caverphone land but I do see in the code comments
that guide through commenting this line in and that line out to toggle
between both versions. I would never toggle between versions like that
nor would I recommend it. This lead me to propose the two classes. In
addition, it could
Is there a need for 1.0?
On Thu, Mar 3, 2011 at 4:38 AM, Gary Gregory wrote:
> Any though on splitting the class into two subclasses. One for cav
> 1.0, the other for 2.0?
>
> Gary
>
> On Mar 3, 2011, at 1:52, Henri Yandell wrote:
>
>> Thanks Martin and Gary - sorry for my screwup.
>>
>> Very ha
Any though on splitting the class into two subclasses. One for cav
1.0, the other for 2.0?
Gary
On Mar 3, 2011, at 1:52, Henri Yandell wrote:
> Thanks Martin and Gary - sorry for my screwup.
>
> Very happy that you found the Caverphone code however Martin :)
>
> Hen
>
> On Tue, Mar 1, 2011 at 9
Thanks Martin and Gary - sorry for my screwup.
Very happy that you found the Caverphone code however Martin :)
Hen
On Tue, Mar 1, 2011 at 9:59 AM, Gary Gregory wrote:
> The fix is in SVN and scheduled for inclusion in the upcoming Codec 1.5
> release.
>
> Thank you,
> Gary
>
> On Tue, Mar 1, 20
The fix is in SVN and scheduled for inclusion in the upcoming Codec 1.5
release.
Thank you,
Gary
On Tue, Mar 1, 2011 at 6:05 AM, Martin Nybo Andersen wrote:
> Hi,
>
> On Mon, 28 Feb 2011, Matt Benson wrote:
>
> Finally, given the fact that we are discussing patches (which have to
>> be granted
Indeed. Aside from this, I've posted a new set of tests in SVN for
Caverphone. The failing tests are commented out until I or someone
else has a chance to dog in. There are no tests for the case outlined
in this case though (the mb stuff)
Gary
On Feb 28, 2011, at 11:16, Matt Benson wrote:
> Fin
Finally, given the fact that we are discussing patches (which have to
be granted IP blah blah blah anyway) as well as the fact that you are
not subscribed to the developer list, this exchange should be
conducted in JIRA.
Matt
On Mon, Feb 28, 2011 at 10:04 AM, Gary Gregory wrote:
> Would you be a
Would you be able to include a unit test patch in your diff file?
Also, it seems that the examples from
http://en.wikipedia.org/wiki/Caverphone
do not match our code:
{"Lee", "L1"},
{"Thompson", "TMPSN1"},
Hm...
Thank you,
Gary
On Mon, Feb 28, 2011 at 8:13 AM, Mar
Hi,
I've found an error in the Caverphone language codec.
According to the specs at page 2 line 6:
"If the name ends with mb make it m2".
Apparently is has been interpreted as:
"If the name _starts_ with mb make it m2".
The attached patch will fix it.
Please CC me, as I'm not subscribed.
Rega
10 matches
Mail list logo
