Re: [codec] Base64InputStream

2008-06-18 Thread Julius Davies
Hi, I decided to create a new ticket (CODEC-69) rather than attach to CODEC-8. The scope of CODEC-8 is somewhat broader (streaming for all encoders/decoders in commons-codec!), and I don't think I have enough time to take it that far. The patch attached to CODEC-69 has JUnits added for many stre

Re: [codec] Base64InputStream

2008-06-16 Thread Julius Davies
Hi, Base64InputStream and Base64OutputStream are coming along. They both have JUnit tests now: Source: http://juliusdavies.ca/codec/src/java/org/apache/commons/codec/binary/ JUnit: http://juliusdavies.ca/codec/src/test/org/apache/commons/codec/binary/ I still need to do some more javadocs bef

Re: [codec] Base64InputStream

2008-06-10 Thread Julius Davies
Hi, Sebb, Thanks for the review! I'll switch to int in the final patch. On Tue, Jun 10, 2008 at 3:30 AM, sebb <[EMAIL PROTECTED]> wrote: > Just curious - why use a byte for the chunk size? > I would have thought an int would be more usual (possibly accompanied > by a range check). > Likewise mod

Re: [codec] Base64InputStream

2008-06-10 Thread sebb
On 10/06/2008, Julius Davies <[EMAIL PROTECTED]> wrote: > Hi, > > > Here's what a streaming version of Base64 looks like (without javadocs). > > > http://juliusdavies.ca/codec/src/java/org/apache/commons/codec/binary/Base64.java > Just curious - why use a byte for the chunk size? I would have t

Re: [codec] Base64InputStream

2008-06-10 Thread Julius Davies
Hi, Here's what a streaming version of Base64 looks like (without javadocs). http://juliusdavies.ca/codec/src/java/org/apache/commons/codec/binary/Base64.java http://juliusdavies.ca/codec/src/java/org/apache/commons/codec/binary/Base64InputStream.java I'll submit a proper patch once I have the

Re: [codec] Base64InputStream

2008-06-03 Thread Julius Davies
Just to let people know: I'm writing a new Base64InputStream by using the ws-commons-util logic, but rearranging things to suit this kind of usage pattern: #1. in = new Base64InputStream(in, DECODE); #2. in = new Base64InputStream(in, ENCODE); The ws-commons-util logic is really slick. I rea

Re: [codec] Base64InputStream

2008-05-31 Thread Julius Davies
Hi, Jochen, Thanks for pointing out that method. I was looking for a static method. I didn't expect it to be an instance method! Anyway, now that I've found it, ws-commons-util is the winner! [16.203 seconds] ws-commons-util THE WINNER [21.946 seconds] not-yet-commons-ssl (For some

Re: [codec] Base64InputStream

2008-05-31 Thread Jochen Wiedmann
On Sat, May 31, 2008 at 9:06 AM, Julius Davies <[EMAIL PROTECTED]> wrote: > I also tried to test with ws-common, but the Base64 library in there > doesn't have a streaming decoder, so I don't think it can handle a > 700MB file. And what do you think that http://ws.apache.org/commons/util/ap

[codec] Base64InputStream

2008-05-31 Thread Julius Davies
Hi, I know of a good Base64InputStream for commons-codec. It can encode and decode. It uses the Base64 class from commons-codec under the hood. It works like this: --- final boolean DECODE = true; final boolean ENCODE = false; InputStream in = new File