Re: [compress] javadoc (was Re: [VOTE] Release Compress 1.20 based on RC2)

2020-02-08 Thread Gary Gregory
On Sat, Feb 8, 2020 at 3:05 PM Stefan Bodewig wrote: > On 2020-02-08, Gary Gregory wrote: > > > On Sat, Feb 8, 2020 at 11:50 AM Stefan Bodewig > wrote: > > >> On 2020-02-08, Gary Gregory wrote: > > >>> - mvn javadoc:javadoc outputs LOTS of errors. > > >> Not a single one for me (building with Ja

[compress] javadoc (was Re: [VOTE] Release Compress 1.20 based on RC2)

2020-02-08 Thread Stefan Bodewig
On 2020-02-08, Gary Gregory wrote: > On Sat, Feb 8, 2020 at 11:50 AM Stefan Bodewig wrote: >> On 2020-02-08, Gary Gregory wrote: >>> - mvn javadoc:javadoc outputs LOTS of errors. >> Not a single one for me (building with Java 8). > Did you run 'mvn javadoc:javadoc'? Yes > Please see https:/

Re: [VOTE] Release Compress 1.20 based on RC2

2020-02-08 Thread Gary Gregory
On Sat, Feb 8, 2020 at 11:50 AM Stefan Bodewig wrote: > On 2020-02-08, Gary Gregory wrote: > > > But next time: > > - On the site: it would be nice to keep all "What's new in 1.zzz?" > sections > > so users can see what's new based on the version _they_ currently have. > > Really, this is going t

Re: [VOTE] Release Compress 1.20 based on RC2

2020-02-08 Thread Stefan Bodewig
On 2020-02-08, Gary Gregory wrote: > But next time: > - On the site: it would be nice to keep all "What's new in 1.zzz?" sections > so users can see what's new based on the version _they_ currently have. Really, this is going to become a pretty long list. I've resurrected all sections since we st

Re: [VOTE] Release Compress 1.20 based on RC2

2020-02-08 Thread Gary Gregory
+1 But next time: - On the site: it would be nice to keep all "What's new in 1.zzz?" sections so users can see what's new based on the version _they_ currently have. - mvn javadoc:javadoc outputs LOTS of errors. My review is based on the git tag. - Apache RAT check OK. - JApiCmp OK. - Building O

Re: [VOTE] Release Compress 1.20 based on RC2

2020-02-08 Thread Stefan Bodewig
Making my own vote explicit. We still lack another +1, though. On 2020-02-05, Stefan Bodewig wrote: > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now, > i.e. sometime after 05:30 UTC 08-Feb 2020 +1 Stefan --

Re: [VOTE] Release Compress 1.20 based on RC2

2020-02-06 Thread Rob Tompkins
“mvn clean test install” - works properly with both java 8 and java 11. “mvn clean test install site” works properly with java 8. All reports look good: jacoco, japicmp, rat, findbugs, pmd, cpd. All signatures test out ok. +1 -Rob > On Feb 5, 2020, at 12:18 AM, Stefan Bodewig wrote: > > The

[VOTE] Release Compress 1.20 based on RC2

2020-02-04 Thread Stefan Bodewig
The only change compared to RC1 is one to a unit test which wouldn't pass unless you already had PAX Exam in your local mvn repo. Compress 1.20 RC2 is available for review here: https://dist.apache.org/repos/dist/dev/commons/compress/ (svn revision 37873) The tag is here: https://git