[CANCEL][VOTE] Release Commons JCS 2.2.1 based on RC3

2018-03-14 Thread Romain Manni-Bucau
Think I didn't send the cancel mail - gmail didn't find it at least, if I did please ignore. Since the thread is very old and was not straight forward it would be very weird to keep it now so it is probably cleaner to start fresh with a RC4 or even a 2.3 a bit later. Sorry for the delay. Romain

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-28 Thread Jean-Louis MONTEIRO
Thanks Romain for pushing this release so hard. I have yank JCS from my project and replaced with another impl. Thanks anyway. Le dim. 24 déc. 2017 à 10:23, Romain Manni-Bucau a écrit : > My own +1 (dont think the issues we found are worth blocking a release but > would be happy to get help to

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-24 Thread Romain Manni-Bucau
My own +1 (dont think the issues we found are worth blocking a release but would be happy to get help to solve them next year) And merry Xmas to everybody Romain Manni-Bucau @rmannibucau | Blog | Old Blog

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-23 Thread Jörg Schaible
Am Sat, 23 Dec 2017 09:06:41 +0100 schrieb Romain Manni-Bucau: > Hi Jorg, > > It doesnt break IDE support but has some "dead" code from my > understanding, > no? OK, I should have checked it myself. I got Oliver wrong and thought it contains only cruft, but the cruft is only additional ;-) In

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-23 Thread Romain Manni-Bucau
Hi Jorg, It doesnt break IDE support but has some "dead" code from my understanding, no? Le 23 déc. 2017 02:33, "Jörg Schaible" a écrit : > Hi Gary, > > Am Fri, 22 Dec 2017 12:34:13 -0700 schrieb Gary Gregory: > > > Hi Jörg, > > > > Thank you for taking the time to review. > > > > The -sources

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-22 Thread Jörg Schaible
Hi Gary, Am Fri, 22 Dec 2017 12:34:13 -0700 schrieb Gary Gregory: > Hi Jörg, > > Thank you for taking the time to review. > > The -sources jar are built by 'mvn deploy' I believe. We should change the parent and tie this goal to package phase. That phase is supposed to produce anything that

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-22 Thread Gary Gregory
Hi Jörg, Thank you for taking the time to review. The -sources jar are built by 'mvn deploy' I believe. How are they broken for you? Gary On Fri, Dec 22, 2017 at 12:28 PM, Jörg Schaible wrote: > Hi, > > the build from source is fine for my compiler zoo from Java 1.7 to 9. > However, if the fi

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-22 Thread Jörg Schaible
Hi, the build from source is fine for my compiler zoo from Java 1.7 to 9. However, if the final release contains broken -sources files, my vote is -1. Those files are very valuable e.g. developing with Eclipse, because they are used in the debugger to jump directly into the source, if you dep

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-19 Thread Romain Manni-Bucau
quick ping: where are we exactly - trying to close that topic before next year ;)? From my understanding current issues are not blocking and we could move forward if the release note is fixed manually after the vote. Romain Manni-Bucau @rmannibucau | Blog

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-17 Thread Romain Manni-Bucau
Le 17 déc. 2017 19:35, "Thomas Vandahl" a écrit : On 15.12.17 14:05, Romain Manni-Bucau wrote: > Here what I tested: > > 1. svn co > 2. mvn clean install > 3. mvn source:jar > > => the same trash is here > > 4. mvn clean source:jar > > => same happens > > so I guess something more fishy happ

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-17 Thread Thomas Vandahl
On 15.12.17 14:05, Romain Manni-Bucau wrote: > Here what I tested: > > 1. svn co > 2. mvn clean install > 3. mvn source:jar > > => the same trash is here > > 4. mvn clean source:jar > > => same happens > > so I guess something more fishy happens :( What is wrong with mvn -Preleas

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-15 Thread Romain Manni-Bucau
Here what I tested: 1. svn co 2. mvn clean install 3. mvn source:jar => the same trash is here 4. mvn clean source:jar => same happens so I guess something more fishy happens :( Romain Manni-Bucau @rmannibucau | Blog

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-15 Thread sebb
The other possible cause is a bad unit test that does not clear up properly. I have seen that in other releases where test output ended up in the main source archives. Try a clean checkout followed by a test and see if the files are created. On 15 December 2017 at 05:58, Romain Manni-Bucau wrote

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-14 Thread Romain Manni-Bucau
Tmp is cause i cloned it freshly from so hope not. And even if so then how can it end up with this path? Le 15 déc. 2017 01:45, "sebb" a écrit : > On 14 December 2017 at 21:58, Romain Manni-Bucau > wrote: > > Wonder how this one can happen > > Unclean workspace? > > RCs should be built from a c

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-14 Thread sebb
On 14 December 2017 at 21:58, Romain Manni-Bucau wrote: > Wonder how this one can happen Unclean workspace? RCs should be built from a clean checkout of the tag. > Le 14 déc. 2017 22:10, "Gary Gregory" a écrit : > >> On Thu, Dec 14, 2017 at 1:32 PM, Oliver Heger < >> oliver.he...@oliver-heger.

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-14 Thread Romain Manni-Bucau
Wonder how this one can happen Le 14 déc. 2017 22:10, "Gary Gregory" a écrit : > On Thu, Dec 14, 2017 at 1:32 PM, Oliver Heger < > oliver.he...@oliver-heger.de> > wrote: > > > > > > > Am 14.12.2017 um 01:38 schrieb Gary Gregory: > > > On Wed, Dec 13, 2017 at 2:03 PM, Oliver Heger < > > oliver.he

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-14 Thread Gary Gregory
On Thu, Dec 14, 2017 at 1:32 PM, Oliver Heger wrote: > > > Am 14.12.2017 um 01:38 schrieb Gary Gregory: > > On Wed, Dec 13, 2017 at 2:03 PM, Oliver Heger < > oliver.he...@oliver-heger.de> > > wrote: > > > >> Hi, > >> > >> thank you for your patience. > >> > >> Build works fine with Java 1.7 on Wi

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-14 Thread Oliver Heger
Am 14.12.2017 um 01:38 schrieb Gary Gregory: > On Wed, Dec 13, 2017 at 2:03 PM, Oliver Heger > wrote: > >> Hi, >> >> thank you for your patience. >> >> Build works fine with Java 1.7 on Windows 10 (because of the Java 8 >> Javadoc errors I built the site with 1.7). >> >> I have some minor findi

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-13 Thread Bruno P. Kinoshita
te in favor to release it (-: Thanks for preparing the release Romain Cheers Bruno From: Romain Manni-Bucau To: Commons Developers List Sent: Wednesday, 13 December 2017 9:03 PM Subject: [VOTE] Release Commons JCS 2.2.1 based on RC3 As discussed quite ve

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-13 Thread Gary Gregory
Looking at the release notes, I see junk in the text: $release.description.replaceAll(" ", " ") There is also a missing Jira reference for: o Unexpected dispose() in CompositeCacheManager.release() Thanks to athun. These are not blockers but not very "pro" either :-( If this vote pa

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-13 Thread Gary Gregory
On Wed, Dec 13, 2017 at 2:03 PM, Oliver Heger wrote: > Hi, > > thank you for your patience. > > Build works fine with Java 1.7 on Windows 10 (because of the Java 8 > Javadoc errors I built the site with 1.7). > > I have some minor findings: > - As Bruno already noticed, the release notes contain

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-13 Thread Gary Gregory
On Wed, Dec 13, 2017 at 2:03 PM, Oliver Heger wrote: > Hi, > > thank you for your patience. > > Build works fine with Java 1.7 on Windows 10 (because of the Java 8 > Javadoc errors I built the site with 1.7). > > I have some minor findings: > - As Bruno already noticed, the release notes contain

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-13 Thread Oliver Heger
Hi, thank you for your patience. Build works fine with Java 1.7 on Windows 10 (because of the Java 8 Javadoc errors I built the site with 1.7). I have some minor findings: - As Bruno already noticed, the release notes contain this strange text. - In README.md the current version for the dependen

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-13 Thread Bruno P. Kinoshita
favor to release it (-: Thanks for preparing the release Romain Cheers Bruno From: Romain Manni-Bucau To: Commons Developers List Sent: Wednesday, 13 December 2017 9:03 PM Subject: [VOTE] Release Commons JCS 2.2.1 based on RC3 As discussed quite verbosely already I'

[VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-13 Thread Romain Manni-Bucau
As discussed quite verbosely already I'd like to release JCS 2.2.1. I followed the commons procedure this time and hope it works for you. JCS 2.2.1 RC3 is available for review here: https://dist.apache.org/repos/dist/dev/commons/jcs/ (svn revision 23702) The tag is here: http://svn.apache.or