Re: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread Niall Pemberton
On Jan 16, 2008 9:16 PM, Gary Gregory <[EMAIL PROTECTED]> wrote: > > From: sebb [mailto:[EMAIL PROTECTED] > > Sent: Wednesday, January 16, 2008 1:07 PM > > > To: Jakarta Commons Developers List > > Subject: Re: [VOTE] Release Commons IO 1.4 based on RC2 >

Re: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread Oliver Heger
I found no problems with the artifacts. All build variants worked for me on JDK 1.6. The only thing I noticed is that the md5 files do not follow the default format used for most commons components (they do not contain the flags and the file name). The argument with the JDK 1.3 compatibility t

RE: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread Gary Gregory
> From: sebb [mailto:[EMAIL PROTECTED] > Sent: Wednesday, January 16, 2008 1:07 PM > To: Jakarta Commons Developers List > Subject: Re: [VOTE] Release Commons IO 1.4 based on RC2 > > On 16/01/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > On Jan 16, 2008

Re: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread sebb
ers List > > > Subject: Re: [VOTE] Release Commons IO 1.4 based on RC2 > > > > > > On 16/01/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > > > On Jan 16, 2008 3:58 PM, sebb <[EMAIL PROTECTED]> wrote: > > > > > The manifest created by

Re: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread Niall Pemberton
On Jan 16, 2008 6:04 PM, Gary Gregory <[EMAIL PROTECTED]> wrote: > > From: sebb [mailto:[EMAIL PROTECTED] > > Sent: Wednesday, January 16, 2008 8:21 AM > > To: Jakarta Commons Developers List > > Subject: Re: [VOTE] Release Commons IO 1.4 based on RC2 > > > &

RE: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread Gary Gregory
> From: sebb [mailto:[EMAIL PROTECTED] > Sent: Wednesday, January 16, 2008 8:21 AM > To: Jakarta Commons Developers List > Subject: Re: [VOTE] Release Commons IO 1.4 based on RC2 > > On 16/01/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > On Jan 16, 2008 3

Re: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread sebb
On 16/01/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > On Jan 16, 2008 3:58 PM, sebb <[EMAIL PROTECTED]> wrote: > > The manifest created by the M2 build includes the following: > > > > Build-Jdk: 1.5.0_07 > > X-Compile-Source-JDK: 1.3 > > X-Compile-Target-JDK: 1.3 > > > > so yes, the actual bu

Re: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread Niall Pemberton
On Jan 16, 2008 3:58 PM, sebb <[EMAIL PROTECTED]> wrote: > The manifest created by the M2 build includes the following: > > Build-Jdk: 1.5.0_07 > X-Compile-Source-JDK: 1.3 > X-Compile-Target-JDK: 1.3 > > so yes, the actual build JDK is shown, but so are the intended versions. > > For javac, the sou

Re: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread sebb
The manifest created by the M2 build includes the following: Build-Jdk: 1.5.0_07 X-Compile-Source-JDK: 1.3 X-Compile-Target-JDK: 1.3 so yes, the actual build JDK is shown, but so are the intended versions. For javac, the source and target setting have limited effect in that they don't affect the

Re: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread Niall Pemberton
On Jan 16, 2008 3:38 PM, Paul Benedict <[EMAIL PROTECTED]> wrote: > Only Ant can specify the actual target JDK used to compile the code in the > Manifest. Maven has an open issue for this in the jar plugin. Alot of people > want to write the target JDK to the manifest, but unfortunately the actual

Re: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread Paul Benedict
Only Ant can specify the actual target JDK used to compile the code in the Manifest. Maven has an open issue for this in the jar plugin. Alot of people want to write the target JDK to the manifest, but unfortunately the actual JDK version (e.g., 1.6) appears. Paul On Jan 16, 2008 8:58 AM, Niall P

Re: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread Niall Pemberton
On Jan 16, 2008 2:27 PM, sebb <[EMAIL PROTECTED]> wrote: > Found what appear to be some build problems: > > "ant dist" creates a Manifest entry of: > > X-Compile-Target-JDK: 1.1 > > whereas the (M2) distribution has: > > X-Compile-Target-JDK: 1.3 > > This is probably due to > > project.properties:

Re: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread sebb
Found what appear to be some build problems: "ant dist" creates a Manifest entry of: X-Compile-Target-JDK: 1.1 whereas the (M2) distribution has: X-Compile-Target-JDK: 1.3 This is probably due to project.properties: maven.compile.target = 1.1 which affects M1 builds as well. == The Ant Ma

Re: [VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread Niall Pemberton
Sorry in the changes section that should have read "Fix an error in the FileWriterWithEncoding JavaDocs" rather than just "fix an error in the". Niall On Jan 16, 2008 10:51 AM, Niall Pemberton <[EMAIL PROTECTED]> wrote: > There have been a few changes since RC1, but since they were all IMO > mino

[VOTE] Release Commons IO 1.4 based on RC2

2008-01-16 Thread Niall Pemberton
There have been a few changes since RC1, but since they were all IMO minor, I've cut a RC2 and thought would proceed straight to a vote. The changes since RC1 are: - changes to build.xml to keep gump happy - fix an error in the - upgrade to version 7 and commons-parent (and remove stuff fro