Re: [VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-11 Thread Simone Tripodi
poor me, I wonder why an RC is never perfect :'( Thanks for the deep review, alles gute! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Sun, Dec 11, 2011 at 9:59 PM, Oliver Heger wrote: > Am 11.12.

Re: [VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-11 Thread Oliver Heger
Am 11.12.2011 18:43, schrieb Simone Tripodi: Hello!!! @Oliver: thanks for reviewing! can you tell me please where did you notice about 3.0 in the release note? I was sure I fixed it on both /trunk and RC, see[1]... Thanks!! The version in [1] is alright. But then it seems that the binary and

Re: [VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-11 Thread Simone Tripodi
Hello!!! @Oliver: thanks for reviewing! can you tell me please where did you notice about 3.0 in the release note? I was sure I fixed it on both /trunk and RC, see[1]... Thanks!! @Paul: looks like the 'Gigester' name is getting more success than the Digester itself :D All the best, -Simo [1] ht

Re: [VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-11 Thread Paul Benedict
Any product called the Gigester gets my +1 vote! On Sun, Dec 11, 2011 at 10:56 AM, Oliver Heger wrote: > +1 > > Build works fine with Java 1.5 on Windows 7. Artifacts and site look good. > > One minor nit: In the release notes the following recommended dependencies > are listed: > "The Recommend

Re: [VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-11 Thread Oliver Heger
+1 Build works fine with Java 1.5 on Windows 7. Artifacts and site look good. One minor nit: In the release notes the following recommended dependencies are listed: "The Recommended Dependency Set for Digester 3.0 is: Digester 3.1 + Logging 1.1.1 + BeanUtils 1.8.3" This is a bit confusing

Re: [VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-11 Thread Gary Gregory
+1 I'm not crazy happy about the one Clirr error but it seems to have been explained away satisfactorily. Non-blockers: - "TM" in logo is too big IMO. - Some easy PMDs to fix: - Overriding method merely calls super - Avoid unused private methods such as 'npeSafeCast(Object)'. Tested m3 "cle

Re: [VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-11 Thread Simone Tripodi
> > If it is necessary, hopefully it can be added to Commons Parent.> +1 javadoc plugin allows custom footers[1], should not be a big deal. Waiting for your +1, Seb ;) best, -Simo [1] http://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#footer http://people.apache.org/~simonet

Re: [VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-11 Thread sebb
On 11 December 2011 11:24, Christian Grobmeier wrote: > On Sat, Dec 10, 2011 at 4:18 PM, Simone Tripodi > wrote: >> [X] +1 release it > > Checked sigs/checksums, looked at the site, opened stuff et al worked > all very well for me. > License is included in LICENSE.txt, NOTICE looks correct (as ex

Re: [VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-11 Thread Simone Tripodi
This is my explicit +1 Thanks a lot for reviewing Christian!!! have a nice WE, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Sun, Dec 11, 2011 at 12:24 PM, Christian Grobmeier wrote: > On Sat, De

Re: [VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-11 Thread Christian Grobmeier
On Sat, Dec 10, 2011 at 4:18 PM, Simone Tripodi wrote: > [X] +1 release it Checked sigs/checksums, looked at the site, opened stuff et al worked all very well for me. License is included in LICENSE.txt, NOTICE looks correct (as explained by Sebbs link). Just one minor thing, which is not a block

Re: [VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-10 Thread Simone Tripodi
On Sat, Dec 10, 2011 at 6:13 PM, James Carman wrote:> What is this "Gigester" you speak of?  Is it a port of Digester to the> Groovy language? ;) ROFL, it could be interesting for Groovy users :D -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter

Re: [VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-10 Thread James Carman
What is this "Gigester" you speak of? Is it a port of Digester to the Groovy language? ;) On Sat, Dec 10, 2011 at 10:18 AM, Simone Tripodi wrote: > Hi all guys,I'm writing to call for a vote to release apache > commons-digester-3.2 based on RC2. > Please take in consideration that: * broken 3.2

[VOTE] Release Apache Commons Gigester 3.2 based on RC2

2011-12-10 Thread Simone Tripodi
Hi all guys,I'm writing to call for a vote to release apache commons-digester-3.2 based on RC2. Please take in consideration that: * broken 3.2 links will be fixed once the site will be deployed; * there is a Clirr violation, but: 1) target class is used for internal use only - there is no way user