Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-08 Thread Alex Herbert
-1 It hangs on my machine when built from the git tag: mvn -version Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T19:33:14+01:00) Maven home: /usr/local/apache-maven-3.5.4 Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-8-openjdk-amd6

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-08 Thread Gilles Sadowski
Le ven. 8 févr. 2019 à 12:36, sebb a écrit : > > -1 to the release: The Javadoc does not mention that "SecureRandom" is used by default. And... where is the branch? Gilles - To unsubscribe, e-mail: dev-unsubscr...@commons.apac

[CANCEL][VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-08 Thread Rob Tompkins
I’m a -1 as well. I have some ideas here and will wok on those going forward. -Rob > On Feb 8, 2019, at 6:41 AM, Gary Gregory wrote: > > Whatever we do, let's document it as best we can in places users will find > it. > > Gary > >> On Fri, Feb 8, 2019, 06:36 sebb > >> -1 to the release: >> I

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-08 Thread Gary Gregory
Whatever we do, let's document it as best we can in places users will find it. Gary On Fri, Feb 8, 2019, 06:36 sebb -1 to the release: > I don't think we can release the code as is; it is bound to cause > significant delays on some systems. > > I think we need to establish whether using 'new Sec

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-08 Thread sebb
-1 to the release: I don't think we can release the code as is; it is bound to cause significant delays on some systems. I think we need to establish whether using 'new SecureRandom()' instead of SecureRandom.getInstanceStrong() makes the long delays go away. Then we need to establish whether we

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-08 Thread Gary Gregory
On Fri, Feb 8, 2019, 03:58 Gilles Sadowski Hello Bruno. > > Le ven. 8 févr. 2019 à 02:54, Bruno P. Kinoshita a > écrit : > > > > Hi, > > > > Had a bit of spare time to investigate this one (almost end of Friday > for me anyway, hooray!). > > > > There are two unit tests in Sha512 hanging for me i

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-08 Thread Gilles Sadowski
Le ven. 8 févr. 2019 à 11:24, Bruno P. Kinoshita a écrit : > > Ah, good point. If you prefer to use the gitbox interface, it's available > here too. > > https://gitbox.apache.org/repos/asf?p=commons-codec.git;a=blob;f=src/main/java/org/apache/commons/codec/digest/B64.java;h=4396eccbb8021164340341

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-08 Thread Bruno P. Kinoshita
Ah, good point. If you prefer to use the gitbox interface, it's available here too. https://gitbox.apache.org/repos/asf?p=commons-codec.git;a=blob;f=src/main/java/org/apache/commons/codec/digest/B64.java;h=4396eccbb80211643403419b22715b033015e452;hb=1884dc028bce8094e8ddd7a9fc192a107a64527a#l77 T

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-08 Thread Gilles Sadowski
Hi. Le ven. 8 févr. 2019 à 10:13, Bruno P. Kinoshita a écrit : > > Hi Gilles, > Sorry, forgot to mention I was talking about the code in the tag for the > release. The link which I provided is also supposed to be the code-to-be-released (branch "1_12"). Incriminated code does not appear there.

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-08 Thread Bruno P. Kinoshita
Hi Gilles, Sorry, forgot to mention I was talking about the code in the tag for the release. The random is created here https://github.com/apache/commons-codec/blob/1884dc028bce8094e8ddd7a9fc192a107a64527a/src/main/java/org/apache/commons/codec/digest/B64.java#L77 And used here https://github.c

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-08 Thread Gilles Sadowski
Hello Bruno. Le ven. 8 févr. 2019 à 02:54, Bruno P. Kinoshita a écrit : > > Hi, > > Had a bit of spare time to investigate this one (almost end of Friday for me > anyway, hooray!). > > There are two unit tests in Sha512 hanging for me in Eclipse, > testSha512CryptExplicitCall and testSha512Cryp

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread Bruno P. Kinoshita
Hi, Had a bit of spare time to investigate this one (almost end of Friday for me anyway, hooray!). There are two unit tests in Sha512 hanging for me in Eclipse, testSha512CryptExplicitCall and testSha512CryptNullData. The code that the test uses and hangs in my JVM can be simplified to: ``` S

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread Rob Tompkins
> On Feb 7, 2019, at 8:17 PM, sebb wrote: > > It builds fine on ubuntu trusty with Java 8 Agree > > https://builds.apache.org/view/A-D/view/Commons/job/Commons-Codec-Adhoc/ > > Maybe sprinkle the Sha2Crypt.sha2Crypt method with debug prints to see > where the code is hanging? > > Or can y

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread sebb
It builds fine on ubuntu trusty with Java8 https://builds.apache.org/view/A-D/view/Commons/job/Commons-Codec-Adhoc/ Maybe sprinkle the Sha2Crypt.sha2Crypt method with debug prints to see where the code is hanging? Or can you run the test in an IDE that allows you to interrupt it if it hangs? On

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread Gary Gregory
On Thu, Feb 7, 2019 at 5:18 PM Gary Gregory wrote: > On Thu, Feb 7, 2019 at 9:03 AM Gary Gregory > wrote: > >> +0 >> >> Testing RC from the git tag. >> >> Apache RAT check OK. >> Apache CLIRR check OK. >> >> Running 'mvn -V clean package site' using Oracle Java 8 and 11 on Windows >> 10.0.16299.

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread Gary Gregory
On Thu, Feb 7, 2019 at 5:21 PM Rob Tompkins wrote: > Strange, I suppose we should cancel and try to debug it? > You don't need to cancel until you know why this is failing and whether there is anything /we/ can do about. What if it's a Java bug? I suppose it could be some infinite loop bug in o

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread Rob Tompkins
Strange, I suppose we should cancel and try to debug it? -Rob > On Feb 7, 2019, at 5:18 PM, Gary Gregory wrote: > >> On Thu, Feb 7, 2019 at 9:03 AM Gary Gregory wrote: >> >> +0 >> >> Testing RC from the git tag. >> >> Apache RAT check OK. >> Apache CLIRR check OK. >> >> Running 'mvn -V cle

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread Gary Gregory
On Thu, Feb 7, 2019 at 9:03 AM Gary Gregory wrote: > +0 > > Testing RC from the git tag. > > Apache RAT check OK. > Apache CLIRR check OK. > > Running 'mvn -V clean package site' using Oracle Java 8 and 11 on Windows > 10.0.16299.904: > > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread sebb
On Thu, 7 Feb 2019 at 17:48, Gilles Sadowski wrote: > > Le jeu. 7 févr. 2019 à 17:32, Gary Gregory a écrit : > > > > On Thu, Feb 7, 2019 at 9:27 AM Gilles Sadowski wrote: > > > > > Hi. > > > > > > "mvn test" does not hang here. > > > > > > > Can you be more specific please? On what OS and Java v

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread Gilles Sadowski
Le jeu. 7 févr. 2019 à 17:32, Gary Gregory a écrit : > > On Thu, Feb 7, 2019 at 9:27 AM Gilles Sadowski wrote: > > > Hi. > > > > "mvn test" does not hang here. > > > > Can you be more specific please? On what OS and Java version? $ java -version openjdk version "10.0.1" 2018-04-17 OpenJDK Runtim

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread Gary Gregory
On Thu, Feb 7, 2019 at 9:27 AM Gilles Sadowski wrote: > Hi. > > "mvn test" does not hang here. > Can you be more specific please? On what OS and Java version? Gary > > Gilles > > Le jeu. 7 févr. 2019 à 15:22, Rob Tompkins a écrit : > > > > Definitely strange works for me. Let me try it insid

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread Gilles Sadowski
Hi. "mvn test" does not hang here. Gilles Le jeu. 7 févr. 2019 à 15:22, Rob Tompkins a écrit : > > Definitely strange works for me. Let me try it inside the maven docker > container. > > -Rob > > > On Feb 7, 2019, at 9:03 AM, Gary Gregory wrote: > > > > +0 > > > > Testing RC from the git tag.

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread Rob Tompkins
Definitely strange works for me. Let me try it inside the maven docker container. -Rob > On Feb 7, 2019, at 9:03 AM, Gary Gregory wrote: > > +0 > > Testing RC from the git tag. > > Apache RAT check OK. > Apache CLIRR check OK. > > Running 'mvn -V clean package site' using Oracle Java 8 and

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread Rob Tompkins
Curious. Looking into it. -Rob > On Feb 7, 2019, at 9:03 AM, Gary Gregory wrote: > > +0 > > Testing RC from the git tag. > > Apache RAT check OK. > Apache CLIRR check OK. > > Running 'mvn -V clean package site' using Oracle Java 8 and 11 on Windows > 10.0.16299.904: > > Apache Maven 3.6.0 (

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-07 Thread Gary Gregory
+0 Testing RC from the git tag. Apache RAT check OK. Apache CLIRR check OK. Running 'mvn -V clean package site' using Oracle Java 8 and 11 on Windows 10.0.16299.904: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00) Maven home: C:\Java\apache-maven-3.6.0\b

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-06 Thread Bruno P. Kinoshita
Hi Rob, thanks for RM'ing it. Had some time before a meeting and left a terminal window building with `mvn clean test site -e -X`... after almost 30 minutes came back, and in top/htop saw a java running jacoco report. Then had a look at .travis.yml, and tried simply running `mvn`. But after 10

[VOTE] Release Apache Commons Codec 1.12 based on RC2

2019-02-06 Thread Rob Tompkins
We have fixed quite a few bugs and added some significant enhancements since Apache Commons Codec 1.11 was released, so I would like to release Apache Commons Codec 1.12. Apache Commons Codec 1.12 RC2 is available for review here: https://dist.apache.org/repos/dist/dev/commons/codec/1.12-RC2