Re: [VOTE][RC1] Commons collections 4.3

2018-12-26 Thread Gilles
Hi. On Wed, 26 Dec 2018 08:23:03 +0700, Maxim Solodovnik wrote: This is the way Wicketstuff build is performed [1] The project consist of ~285 modules and it is wise to create tag only if build is already in Nexus :) [1] https://github.com/wicketstuff/core/wiki/Wicket-Stuff-Core-Release-Proc

Re: [VOTE][RC1] Commons collections 4.3

2018-12-25 Thread Maxim Solodovnik
This is the way Wicketstuff build is performed [1] The project consist of ~285 modules and it is wise to create tag only if build is already in Nexus :) [1] https://github.com/wicketstuff/core/wiki/Wicket-Stuff-Core-Release-Process On Wed, 26 Dec 2018 at 08:11, Rob Tompkins wrote: > > > > On De

Re: [VOTE][RC1] Commons collections 4.3

2018-12-25 Thread Rob Tompkins
> On Dec 25, 2018, at 8:04 PM, Maxim Solodovnik wrote: > > In both git and svn you need a branch to create tag > But since git has local and remote repository, steps can be: > > 1) create local branch > 2) made "release" changes > 3) create tag > 4) push the tag > > In this case only tag wil

Re: [VOTE][RC1] Commons collections 4.3

2018-12-25 Thread Maxim Solodovnik
In both git and svn you need a branch to create tag But since git has local and remote repository, steps can be: 1) create local branch 2) made "release" changes 3) create tag 4) push the tag In this case only tag will be pushed, and there will be no useless branches with minimal "release" change

[CANCELED] [VOTE][RC1] Commons collections 4.3

2018-12-25 Thread Maxim Solodovnik
Hello All, I will cancel the VOTE due to issues found in this RC Will try to create RC2 ASAP Thanks for your help! On Wed, 26 Dec 2018 at 05:40, Gilles wrote: > Hi. > > On Tue, 25 Dec 2018 22:22:43 +0700, Maxim Solodovnik wrote: > > Hello Gilles, > > > > Actually if release is made based on gi

Re: [VOTE][RC1] Commons collections 4.3

2018-12-25 Thread Gilles
Hi. On Tue, 25 Dec 2018 22:22:43 +0700, Maxim Solodovnik wrote: Hello Gilles, Actually if release is made based on git it is not necessary to perform commits ? I don't know other ways to perform the release; I follow the practice established for "svn", that was then adapted for "git" when we

Re: [VOTE][RC1] Commons collections 4.3

2018-12-25 Thread Maxim Solodovnik
Hello Gilles, Actually if release is made based on git it is not necessary to perform commits into local branch you are using to create RC tag this why I previously ask if I can drop useless branch I can fix issues with site manually, but it will be impossible to modify pom without canceling rele

Re: [VOTE][RC1] Commons collections 4.3

2018-12-24 Thread Gilles
On Tue, 25 Dec 2018 01:15:23 +0100, Gilles wrote: On Mon, 24 Dec 2018 22:11:11 +0700, Maxim Solodovnik wrote: Hello All, I'm back :) Shall I try to regenerate clirr report? and upload release_4_3.html? Personally, I'd redo all the steps needed to ensure consistency of what is used to create t

Re: [VOTE][RC1] Commons collections 4.3

2018-12-24 Thread Gilles
On Mon, 24 Dec 2018 22:11:11 +0700, Maxim Solodovnik wrote: Hello All, I'm back :) Shall I try to regenerate clirr report? and upload release_4_3.html? Personally, I'd redo all the steps needed to ensure consistency of what is used to create the release but YMMV (and others may confirm that th

Re: [VOTE][RC1] Commons collections 4.3

2018-12-24 Thread Maxim Solodovnik
Hello All, I'm back :) Shall I try to regenerate clirr report? and upload release_4_3.html? According to download page: it seems `mvn org.apache.commons:commons-build-plugin:1.10-SNAPSHOT:download-page` does nothing for me Shall I manually update download page? What need to be updated? On Fri,

Re: [VOTE][RC1] Commons collections 4.3

2018-12-20 Thread Gary Gregory
Hi all, I am unable to review for at least 3 or 4 days. I am on the road and my laptop just died... Gary On Wed, Dec 19, 2018, 08:41 Maxim Solodovnik commons-collections4-4.3-src.zip.sha256This is a [VOTE] for releasing > Apache Commons collections 4.3 > > Tag name: > collections-4.3-RC1 (signat

Re: [VOTE][RC1] Commons collections 4.3

2018-12-20 Thread Gilles
On Thu, 20 Dec 2018 10:46:46 +0700, Maxim Solodovnik wrote: My bad, Here is the analysis (please correct me if I'm wrong) Errors: [...] these errors are weird. Above classes has no changes comparing to 4.2 [1] It might the same problem which I've encountered a few eeks ago: Try to delete

Re: [VOTE][RC1] Commons collections 4.3

2018-12-19 Thread Maxim Solodovnik
My bad, Here is the analysis (please correct me if I'm wrong) Errors: 1) `org.apache.commons.collections4.BidiMap:: Method 'public java.util.Collection values()' has been added to an interface` 2) `org.apache.commons.collections4.ListValuedMap:: Method 'public java.util.Collection get(java.lang.Ob

Re: [VOTE][RC1] Commons collections 4.3

2018-12-19 Thread sebb
On Wed, 19 Dec 2018 at 16:09, Maxim Solodovnik wrote: > > Thanks for checking Gilles, > > Regarding clirr errors instruction states [1] to check errors only for > minor release That is not the understanding I have of how to handle Clirr errors, nor does the doc [1] actually say that. The cited do

Re: [VOTE][RC1] Commons collections 4.3

2018-12-19 Thread Gilles
On Wed, 19 Dec 2018 23:08:44 +0700, Maxim Solodovnik wrote: Thanks for checking Gilles, Regarding clirr errors instruction states [1] to check errors only for minor release Since it is 4.3.0 and not 4.2.1 I thought it is OK .. 4.X is a minor release ("Y.0" is a major one). Usually (with no

Re: [VOTE][RC1] Commons collections 4.3

2018-12-19 Thread Maxim Solodovnik
Thanks for checking Gilles, Regarding clirr errors instruction states [1] to check errors only for minor release Since it is 4.3.0 and not 4.2.1 I thought it is OK .. How this should be properly addressed? release_4_3.html was not genarated during build :( How can I generate it? Is it possible t

Re: [VOTE][RC1] Commons collections 4.3

2018-12-19 Thread Gilles
Hi. Congratulations for getting that far in a fairly short time. ;-) The BC report (Clirr) notes several incompatible changes: https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/clirr-report.html [No idea whether that was expected. If so, perhaps there should be a remar

[VOTE][RC1] Commons collections 4.3

2018-12-19 Thread Maxim Solodovnik
commons-collections4-4.3-src.zip.sha256This is a [VOTE] for releasing Apache Commons collections 4.3 Tag name: collections-4.3-RC1 (signature can be checked from git using 'git tag -v') Tag URL: https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4