CycloneDX for multimodule projects WAS: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

I made the changes in 55-SNAPSHOT to the Maven plugin configuration from 'makeAggregateBom' to 'makeBom'. Gary -- Forwarded message - From: Gary Gregory Date: Wed, Sep 21, 2022, 14:45 Subject: Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1 To

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

This lazy vote passes with 2 binding +1s: - Bruno Kinoshita - Gary Gregory Gary On Sun, Sep 18, 2022 at 11:46 AM Gary Gregory wrote: > > We have fixed a few bugs and added enhancements since Apache Commons > Parent 53 was released, so I would like to release Apache Commons > Parent 54. > > Apach

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

My +1 On Sun, Sep 18, 2022 at 11:46 AM Gary Gregory wrote: > > We have fixed a few bugs and added enhancements since Apache Commons > Parent 53 was released, so I would like to release Apache Commons > Parent 54. > > Apache Commons Parent 54 RC1 is available for review here: > https://dist.ap

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

Thank you Alex, My plan is to proceed with 54 as is and continue toward getting single and multiple module projects to work nicely from commons-parent for 55. Gary On Tue, Sep 20, 2022 at 5:00 PM Alex Herbert wrote: > > Hi, > > I have put together a simple project with a parent and two modules,

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

Yes. The release notes file contains the release note history. So if you update from version 1 to 54, you only have one document to consult. Gary On Wed, Sep 21, 2022, 06:44 Jochen Wiedmann wrote: > On Sun, Sep 18, 2022 at 5:47 PM Gary Gregory > wrote: > > > Details of changes since 53 are in

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

On Sun, Sep 18, 2022 at 5:47 PM Gary Gregory wrote: > Details of changes since 53 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/54-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/commons-parent/54-RC1/site/changes-re

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

Hi, I have put together a simple project with a parent and two modules, each with their own dependencies. This has the same result in that the installed bom for each module includes the dependencies of the entire project reactor. When I change the goal from 'makeAggregateBom' to 'makeBom' then I

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

Hello. > [...] The installed bom has dependency > information collated from other modules which are not actually > dependencies. So the aggregation is bringing in dependencies incorrectly. > This makes the BOM incorrect. > [...] If that's the case, I suggest that this feature is disabled by defau

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

Hi Gary, On Tue, 20 Sept 2022 at 12:59, Gary Gregory wrote: > > Maybe you had a random failure or were not running from the command > line. Some VFS tests won't run properly from IDEs because they depend > on the old VFS testing framework still in place that relies on some > JUnit 3 patterns. >

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

Alex, I just saw you posted this last message. This will need more tweaking over time it seems. It's not clear to me if we can have a commons-parent that works generically for both single and multi-module projects for CycloneDX and/or SPDX. Gary On Tue, Sep 20, 2022 at 7:56 AM Alex Herbert wrote

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

Hi Alex, Thank you for the additional testing and reporting. As a baseline, the VFS git master build is green on macOS, Windows, and Linux using Java 8, 11, and 17: https://github.com/apache/commons-vfs/actions where the current latest CI build for git master is https://github.com/apache/commons-

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

Hi Gary, I have found part of the issue. I copied the default configuration for cyclone DX maven plugin [1] into the statistics project. This worked. The only difference between this config and the config in parent is: Default: bom CP: ${project.artifactId}-${project.version}-bom Unfortunate

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

Hi Gary, I tried VFS. On my mac it did not pass the unit tests: [*ERROR*] *Errors: * [*ERROR*] * AbstractSftpProviderTestCase$SftpProviderTestSuite>AbstractTestSuite.run:239->AbstractTestSuite.lambda$run$0:234->setUp:235->AbstractTestSuite.setUp:268 » FileSystem Could not connect to SFTP server

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

Hi Alex, Thank you for the review. - .gitattributes: Yes let's do that for the next release. In addition, there has been talk about this and recent changes around these types of files on the Maven mailing list but we can and should handle these in our parent POM for now. - CycloneDX: At the time

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

Cloned and installed locally from the git tag. I updated Commons RNG to use parent 54 and tested with: mvn clean package I had to add '.gitattributes' to a list of excluded files for the apache-rat plugin. Not a blocker but this could be moved to commons-parent. The new bill of materials genera

Re: [VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

[x] +1 Release these artifacts Thanks! On Mon, 19 Sept 2022 at 03:47, Gary Gregory wrote: > We have fixed a few bugs and added enhancements since Apache Commons > Parent 53 was released, so I would like to release Apache Commons > Parent 54. > > Apache Commons Parent 54 RC1 is available for

[VOTE][LAZY] Release Apache Commons Parent 54 based on RC1

We have fixed a few bugs and added enhancements since Apache Commons Parent 53 was released, so I would like to release Apache Commons Parent 54. Apache Commons Parent 54 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/commons-parent/54-RC1 (svn revision 56878)