Re: [SANDBOX][BeanUtils2] Thoughts about AccessibleObjectsRegistry

2012-01-30 Thread Benedikt Ritter
Am 30.01.2012 12:46, schrieb Simone Tripodi: Hi Benedikt, The patch for TypeUtils has been created yesterday based on r1237257. Please have a look at SANDBOX-369. yes saw it, I am subscribed to Jira notifications ML, if I didn't have already look at it it is because, unfortunately, my paid

Re: [SANDBOX][BeanUtils2] Thoughts about AccessibleObjectsRegistry

2012-01-30 Thread Simone Tripodi
Hi Benedikt, > > The patch for TypeUtils has been created yesterday based on r1237257. Please > have a look at SANDBOX-369. > yes saw it, I am subscribed to Jira notifications ML, if I didn't have already look at it it is because, unfortunately, my paid job doesn't involve BeanUtils ATM - so I ha

Re: [SANDBOX][BeanUtils2] Thoughts about AccessibleObjectsRegistry

2012-01-30 Thread Benedikt Ritter
Am 29.01.2012 12:37, schrieb Benedikt Ritter: Hi Simo, thank you so much for your feedback! Have a look at my comments inline... Am 29.01.2012 11:30, schrieb Simone Tripodi: Hi Benedikt, I think the advantage is, that we need less local variables and that we can read through the method(s) fr

Re: [SANDBOX][BeanUtils2] Thoughts about AccessibleObjectsRegistry

2012-01-29 Thread Benedikt Ritter
Hi Simo, thank you so much for your feedback! Have a look at my comments inline... Am 29.01.2012 11:30, schrieb Simone Tripodi: Hi Benedikt, I think the advantage is, that we need less local variables and that we can read through the method(s) from> an abstract point, going deeper and deepe

Re: [SANDBOX][BeanUtils2] Thoughts about AccessibleObjectsRegistry

2012-01-29 Thread Simone Tripodi
Hi Benedikt, > I think the advantage is, that we need less local variables and that we can > read through the method(s) from > an abstract point, going deeper and deeper. > Every method should only be concerned with, well one concern > ;) and that > concern should be doing thinks on only one le

Re: [SANDBOX][BeanUtils2] Thoughts about AccessibleObjectsRegistry

2012-01-28 Thread Benedikt Ritter
Whoopse, forgot to add the patch ;-) here it is... Am 28.01.2012 15:28, schrieb Benedikt Ritter: Hi Simo, thanks for your answer! have a look at my inline comments: Am 28.01.2012 08:26, schrieb Simone Tripodi: Hi Benedikt, thanks for investing your spare time on contributing on BeanUtils2! Ple

Re: [SANDBOX][BeanUtils2] Thoughts about AccessibleObjectsRegistry

2012-01-28 Thread Benedikt Ritter
Hi Simo, thanks for your answer! have a look at my inline comments: Am 28.01.2012 08:26, schrieb Simone Tripodi: Hi Benedikt, thanks for investing your spare time on contributing on BeanUtils2! Please read my inline comments: Complex methods: I know, that BeanUtils2 is just an experiment, and

Re: [SANDBOX][BeanUtils2] Thoughts about AccessibleObjectsRegistry

2012-01-27 Thread Simone Tripodi
Hi Benedikt, thanks for investing your spare time on contributing on BeanUtils2! Please read my inline comments: > Complex methods: I know, that BeanUtils2 is just an experiment, and that the > code was written to get it working fast for this purpose. But some methods > are really hard to read. Ta

[SANDBOX][BeanUtils2] Thoughts about AccessibleObjectsRegistry

2012-01-27 Thread Benedikt Ritter
Hi, now, that I have made myself more familiar with BeanUtils2, there are a few things worth discussing regarding AccessibleObjectsRegistry. Complex methods: I know, that BeanUtils2 is just an experiment, and that the code was written to get it working fast for this purpose. But some methods