Re: [SANDBOX][BeanUtils2] Regarding BeanAccessor.populate()

2012-02-08 Thread Simone Tripodi
Hi Benedikt, having test dependencies is fine, the "restriction" is just for the main distribution. looking forward to apply more from you! alles gute, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/

Re: [SANDBOX][BeanUtils2] Regarding BeanAccessor.populate()

2012-02-08 Thread Benedikt Ritter
Hey Simo, no hurry! :-) I'm just figuring how to implement the tests for populate(). For example I want do do something like (properties is an empty map in this case): @Test public void populateEmpty() throws Exception { on( target ).populate( properties ); assertTrue( target.equal

Re: [SANDBOX][BeanUtils2] Regarding BeanAccessor.populate()

2012-02-07 Thread Simone Tripodi
Excellent :) I'll take care to apply your patches tomorrow, unfortunately I have still some task to complete today :/ alles gute, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Tue, Feb 7, 2012 at

Re: [SANDBOX][BeanUtils2] Regarding BeanAccessor.populate()

2012-02-07 Thread Benedikt Ritter
Am 07.02.2012 16:19, schrieb Simone Tripodi: Hola, I've read your email twice yesterday evening and again today. Sorry, but I honestly do not understand, what you are talking about :-) I assume, that you are referring to my comment on svn commit r1241124 on moving Assertions to a new package?!

Re: [SANDBOX][BeanUtils2] Regarding BeanAccessor.populate()

2012-02-07 Thread Simone Tripodi
Hola, > I've read your email twice yesterday evening and again today. Sorry, but I > honestly do not understand, what you are talking about :-) > I assume, that you are referring to my comment on svn commit r1241124 on > moving Assertions to a new package?! (rather then the behavior of > populate(

Re: [SANDBOX][BeanUtils2] Regarding BeanAccessor.populate()

2012-02-07 Thread Benedikt Ritter
Hi Simo, I've read your email twice yesterday evening and again today. Sorry, but I honestly do not understand, what you are talking about :-) I assume, that you are referring to my comment on svn commit r1241124 on moving Assertions to a new package?! (rather then the behavior of populate())

Re: [SANDBOX][BeanUtils2] Regarding BeanAccessor.populate()

2012-02-06 Thread Simone Tripodi
anyway, just for the record: the reason is just because I introduced a new package that needs to access to same methods, otherwise there wouldn't have been any reason to expose it. do you see a valid motivation? -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ h

Re: [SANDBOX][BeanUtils2] Regarding BeanAccessor.populate()

2012-02-05 Thread Simone Tripodi
Hi Benedikt, let's keep the `skip readonly property` behavior ATM, that is something BeanUtils users are already used to. Same for null key, skip them. Moreover, iterate over properties.entrySet()[1] instead of keySet(). all the best, -Simo [1] http://docs.oracle.com/javase/6/docs/api/java/uti

[SANDBOX][BeanUtils2] Regarding BeanAccessor.populate()

2012-02-05 Thread Benedikt Ritter
Hi, I'm working on populate and tried to stick to the convention of throwing exceptions for illegal inputs: * passing null will cause NullPointerException * passing an empty Map will have no effect * passing a Map with null keys will cause NullPointerException * passing a Map with null values