Hello.
Le dim. 3 juil. 2022 à 08:39, Avijit Basak a écrit :
>
> Hi All
>
> Please find my responses. Sorry for the delay.
>
> > Comments related to new model:
> >>
> >> 1) Hierarchy of GeneticOperator: In the proposed model the genetic
> >> operators are designed hierarchically implem
Hi All
Please find my responses. Sorry for the delay.
> Comments related to new model:
>>
>> 1) Hierarchy of GeneticOperator: In the proposed model the genetic
>> operators are designed hierarchically implementing a common interface and
>> operators are accepted as a list.
>> This ena
Responding below to some of my own questions following commit
ddfd5bf859d04cc5da604b20021ceaba9de7def6
in branch
feature__MATH-1563__genetic_algorithm
Le mar. 24 mai 2022 à 01:54, Gilles Sadowski a écrit :
>
> Hello.
>
> Le mer. 18 mai 2022 à 16:34, Avijit Basak a écrit :
> >
> > Hi All
> >
Hello.
Le mer. 18 mai 2022 à 16:34, Avijit Basak a écrit :
>
> Hi All
>
> Please find my comments below.
>
> Comments related to new model:
>
> 1) Hierarchy of GeneticOperator: In the proposed model the genetic
> operators are designed hierarchically implementing a common interface and
>
Hi All
Please find my comments below.
Comments related to new model:
1) Hierarchy of GeneticOperator: In the proposed model the genetic
operators are designed hierarchically implementing a common interface and
operators are accepted as a list.
This enables interchangeability of operators
Hello.
Le dim. 1 mai 2022 à 10:07, Avijit Basak a écrit :
>
> Hi All
>
> Please find my responses.
>
> >Currently; it prints everything on "stderr" (so that simple usage of
> >the UNIX shell's "pipe" syntax is not possible).
> -- This is the default behaviour of slf4j-simple.
> It is pos
Hi All
Please find my responses.
>Currently; it prints everything on "stderr" (so that simple usage of
>the UNIX shell's "pipe" syntax is not possible).
-- This is the default behaviour of slf4j-simple.
It is possible to provide specific system properties as VM args to redirect
the log t
Hello.
> > > [...]
(1)
o.a.c.m.ga.GeneticAlgorithmTestPermutations
(under "src/test")
As per your comment in that class, it is a usage example.
Given that its name does not end with "Test", it is not run by the
test suite. Please move it to the "examples" module.
(2)
I'm missing a high-level d
Hello.
> [...]
> -- Created a new PR https://github.com/apache/commons-math/pull/209.
Merged in branch "feature__MATH-1563__genetic_algorithm".
> > [...]
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For addition
Hello.
Le lun. 11 avr. 2022 à 07:36, Avijit Basak a écrit :
>
> [...]
>
> >I can't seem to find how the logger is configured. Currently, all
> >"INFO" messages are logged to the "standard error" console; one
> >should be able to e.g. redirect output to a file, or set the log level.
> -- There is
Hi All
Please find my comments below:
>I've merged PR #208 into the feature branch (please open a
>new one for changes entailed by the comments below).
>I again had to delete the branch (and recreate it with the merged
>changes from PR #208). [I must be missing something about the
>cor
Hello.
Le mar. 29 mars 2022 à 17:08, Avijit Basak a écrit :
>
> Hi All
>
> Please find my comments below.
>
> [...]
>
> --I have made the changes and created a new PR. Kindly review the same and
> share your thoughts.
> https://github.com/apache/commons-math/pull/208
I've merged PR #208
Hi All
Please find my comments below.
[...]
>Just quickly commenting on this point.
>IIUC, your purpose is for users to be able to run (an example
>application of) the old implementation.
>
>This can be achieved by having all the "legacy" codes within
>module
> commons-math-examples/ex
Hello.
Le lun. 28 mars 2022 à 10:15, Avijit Basak a écrit :
>
> [...]
>
> >The various "Standalone" classes also look quite similar; consolidating the
> >"examples-ga" module (including full Javadoc) is necessary.
> -- Could you please elaborate it more. IMHO as StandAlone classes are
> dedicated
Hi All
Please find my comments.
[...]
>I don't think that it's the right way to go; instantiating an
"ExecutorService"
>belongs to the GA application, not the GA library (whose relevant classes
>need "only" be thread-safe).
>There is some misunderstanding to be clarified in a dedicated dis
Hello.
Le lun. 28 févr. 2022 à 07:11, Avijit Basak a écrit :
>
> Hi All
>
> Please see my comments below.
>
> > [...]
> >I just had a very quick look.
> >IIUC, you always provide "convenience" methods (e.g. the various
> >signatures for the "evolve" functionality).
> >Prior to merging int
Hi All
Please see my comments below.
> [...]
>I just had a very quick look.
>IIUC, you always provide "convenience" methods (e.g. the various
>signatures for the "evolve" functionality).
>Prior to merging into "master", we should simplify and limit the
>discussion to the core functionalit
Hello.
Le lun. 21 févr. 2022 à 06:56, Avijit Basak a écrit :
>
> Hi All
>
> Please find my comments below:
>
> [...]
> >
> >Another misunderstanding (probably); we must figure out where
> >the parallelism will be implemented.
> >IIUC the current state of the code, optimizing multiple popu
Hello.
Le lun. 21 févr. 2022 à 06:56, Avijit Basak a écrit :
>
> Hi All
>
> Please find my comments below:
>
> >The build fails because of CheckStyle errors:
> >https://app.travis-ci.com/github/apache/commons-math/builds/246683712
> --Fixed the issues
Could you please squash all the new
Hi All
Please find my comments below:
>The build fails because of CheckStyle errors:
>https://app.travis-ci.com/github/apache/commons-math/builds/246683712
--Fixed the issues
[...]
>> >> >
>> >> >I did not suggest to remove any Javadoc, only to rephrase it as:
[...]
>> >As hinted by
Hello.
Le ven. 18 févr. 2022 à 11:32, Avijit Basak a écrit :
>
> Hi All
>
> Please see my comments below.
>
>> [...]
>
> --I have modified the exception class name to
> GeneticIllegalArgumentException.
The build fails because of CheckStyle errors:
https://app.travis-ci.com/github/apache/
Hi All
Please see my comments below.
>> Please find my comments.
>>
>> >> (2)
>> >> >The "GeneticException" class seems to mostly deal with "illegal"
>> >> >arguments; hence it should be a subclass of the JDK's standard
>> >> >"IllegalArgumentException" (and be renamed accordingly
Hello.
Le mer. 16 févr. 2022 à 17:31, Avijit Basak a écrit :
>
> Hi All
>
> Please find my comments.
>
> >> (2)
> >> >The "GeneticException" class seems to mostly deal with "illegal"
> >> >arguments; hence it should be a subclass of the JDK's standard
> >> >"IllegalArgumentException" (and
Hi All
Please find my comments.
>> (2)
>> >The "GeneticException" class seems to mostly deal with "illegal"
>> >arguments; hence it should be a subclass of the JDK's standard
>> >"IllegalArgumentException" (and be renamed accordingly).
>> >If other condition types are needed, then another
Hello.
Le lun. 14 févr. 2022 à 08:03, Avijit Basak a écrit :
>
> Hi All
>
> Thanks for the review comments. Please find my comments below.
>
> (1)
> [...]
>
> (2)
> >The "GeneticException" class seems to mostly deal with "illegal"
> >arguments; hence it should be a subclass of the JDK's s
Hi All
Thanks for the review comments. Please find my comments below.
(1)
>A commit log message should strive to be informative
>for the reviewer; saying the like of "fixed minor bugs" does
>not convey anything.
>Even minor changes, like e.g. formatting cleanup, should be
>designated as s
Hello.
A few remarks (as of PR #205) and questions:
(1)
A commit log message should strive to be informative
for the reviewer; saying the like of "fixed minor bugs" does
not convey anything.
Even minor changes, like e.g. formatting cleanup, should be
designated as such.
For this PR, the message (
27 matches
Mail list logo
