Re: [MATH] ComplexUtils pull request; some future proposals

2015-10-30 Thread Nick Burch
On Fri, 30 Oct 2015, luc wrote: In fact, pull requests are really github-specific, and we don't have a complete integration between our Apache infrastructure and github for Commons Math. As an example, the requests are not directly forwarded to our mailing lists so we may miss them (and we alre

Re: [MATH] ComplexUtils pull request; some future proposals

2015-10-30 Thread luc
Le 2015-10-30 10:58, Gilles a écrit : On Fri, 30 Oct 2015 09:20:00 +, Eric Barnhill wrote: On 30/10/15 02:15, Gilles wrote: There are some problems with the Javadoc (wrong "@return" comment). Not all local variables that are constant are declared "final". I am happy to give it all anothe

Re: [MATH] ComplexUtils pull request; some future proposals

2015-10-30 Thread Gilles
On Fri, 30 Oct 2015 09:20:00 +, Eric Barnhill wrote: On 30/10/15 02:15, Gilles wrote: There are some problems with the Javadoc (wrong "@return" comment). Not all local variables that are constant are declared "final". I am happy to give it all another proof read. I take it the procedure i

Re: [MATH] ComplexUtils pull request; some future proposals

2015-10-30 Thread Gilles
On Fri, 30 Oct 2015 09:25:07 +, Eric Barnhill wrote: On 30/10/15 02:35, Gilles wrote: Unless I'm mistaken, there is no report on the project's bug-tracking system: https://issues.apache.org/jira/browse/MATH Could you please open one? I see that I need someone to assign me the create

Re: [MATH] ComplexUtils pull request; some future proposals

2015-10-30 Thread Eric Barnhill
On 30/10/15 02:35, Gilles wrote: Unless I'm mistaken, there is no report on the project's bug-tracking system: https://issues.apache.org/jira/browse/MATH Could you please open one? I see that I need someone to assign me the create issue project permission. Can I request that here? Er

Re: [MATH] ComplexUtils pull request; some future proposals

2015-10-30 Thread Eric Barnhill
On 30/10/15 02:15, Gilles wrote: There are some problems with the Javadoc (wrong "@return" comment). Not all local variables that are constant are declared "final". I am happy to give it all another proof read. I take it the procedure is to fork the dedicated branch and then submit a pull r

Re: [MATH] ComplexUtils pull request; some future proposals

2015-10-29 Thread Gilles
On Thu, 29 Oct 2015 20:24:56 +0100, Luc Maisonobe wrote: Le 28/10/2015 17:33, Eric Barnhill a écrit : Dear all, Hi Eric, Thanks for the feedback on ComplexUtils and I have submitted a pull request with the edits. Unless I'm mistaken, there is no report on the project's bug-tracking sys

Re: [MATH] ComplexUtils pull request; some future proposals

2015-10-29 Thread Gilles
Hello. On Thu, 29 Oct 2015 20:24:56 +0100, Luc Maisonobe wrote: Le 28/10/2015 17:33, Eric Barnhill a écrit : Dear all, Hi Eric, Thanks for the feedback on ComplexUtils and I have submitted a pull request with the edits. I have pulled this request into our git repository, with minor edi

Re: [MATH] ComplexUtils pull request; some future proposals

2015-10-29 Thread Luc Maisonobe
Le 28/10/2015 17:33, Eric Barnhill a écrit : > Dear all, Hi Eric, > > Thanks for the feedback on ComplexUtils and I have submitted a pull request > with the edits. I have pulled this request into our git repository, with minor edits. The changes are mainly removing tabs and trailing blanks, and

[MATH] ComplexUtils pull request; some future proposals

2015-10-28 Thread Eric Barnhill
Dear all, Thanks for the feedback on ComplexUtils and I have submitted a pull request with the edits. I have added functionality to convert between Complex arrays and real double, real float, interleaved double, interleaved float, split double (one real, one imag) and split float arrays. Per Gill