Re: [LOGGING] Release with Java 9 Module support

2017-10-14 Thread Benedikt Ritter
> Am 01.10.2017 um 21:27 schrieb Stephen Colebourne : > > On 1 October 2017 at 11:34, Stefan Bodewig wrote: >> - only add the automatic module name to commons-logging and release api >> and adapter as they are. > > Exactly. This is the right approach. I’ll start working on the release once the

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Stephen Colebourne
On 1 October 2017 at 11:34, Stefan Bodewig wrote: > - only add the automatic module name to commons-logging and release api > and adapter as they are. Exactly. This is the right approach. Stephen - To unsubscribe, e-mail: dev-un

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Benedikt Ritter
> Am 01.10.2017 um 19:00 schrieb Ralph Goers : > > That isn’t what I suggested. Release all 3 but only turn commons-logging.jar > into a module. Yes :o) I’ll go ahead with this approach as soon as I find the time for it. Cheers, Benedikt > > Ralph > >> On Oct 1, 2017, at 1:25 AM, Benedikt

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Ralph Goers
> On Oct 1, 2017, at 2:48 AM, sebb wrote: > > On 1 October 2017 at 10:08, Pascal Schumacher > wrote: >> Looks like commons-logging-api is used by some popular projects (Hibernate, >> Hadoop, Camel): >> >> http://www.mvnrepository.com/artifact/commons-logging/co

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Ralph Goers
That isn’t what I suggested. Release all 3 but only turn commons-logging.jar into a module. Ralph > On Oct 1, 2017, at 1:25 AM, Benedikt Ritter wrote: > > Okay, so we agree to drop the api and adapters jars from the build and the > distribution? If that is the case, I think we are ready to rel

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Stefan Bodewig
On 2017-10-01, Benedikt Ritter wrote: > So what options are we left with? > - Do nothing -> logging can’t be used as a Java 9 module > - Drop api and adapters -> users have to change their dependencies and get > more code than they want - only add the automatic module name to commons-logging and

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Benedikt Ritter
> Am 01.10.2017 um 11:48 schrieb sebb : > > On 1 October 2017 at 10:08, Pascal Schumacher > wrote: >> Looks like commons-logging-api is used by some popular projects (Hibernate, >> Hadoop, Camel): >> >> http://www.mvnrepository.com/artifact/commons-logging/commons-logging-api/usages >> >> but

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread sebb
On 1 October 2017 at 10:08, Pascal Schumacher wrote: > Looks like commons-logging-api is used by some popular projects (Hibernate, > Hadoop, Camel): > > http://www.mvnrepository.com/artifact/commons-logging/commons-logging-api/usages > > but I guess they can easily switch to commons-logging. Not

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Pascal Schumacher
Looks like commons-logging-api is used by some popular projects (Hibernate, Hadoop, Camel): http://www.mvnrepository.com/artifact/commons-logging/commons-logging-api/usages but I guess they can easily switch to commons-logging. Commons-logging-adatper seem to be very rarely used: http://www.m

Re: [LOGGING] Release with Java 9 Module support

2017-10-01 Thread Benedikt Ritter
Okay, so we agree to drop the api and adapters jars from the build and the distribution? If that is the case, I think we are ready to release this. Benedikt Gary Gregory schrieb am So. 1. Okt. 2017 um 03:39: > On Sep 30, 2017 11:24, "Ralph Goers" wrote: > > Looking at the build script it appea

Re: [LOGGING] Release with Java 9 Module support

2017-09-30 Thread Gary Gregory
On Sep 30, 2017 11:24, "Ralph Goers" wrote: Looking at the build script it appears that both the api and adapters modules contain a subset of what is in commons-logging.jar. I have no idea why this is but all three of them cannot be modularized. I would suggest only modularizing commons-logging.j

Re: [LOGGING] Release with Java 9 Module support

2017-09-30 Thread Ralph Goers
Looking at the build script it appears that both the api and adapters modules contain a subset of what is in commons-logging.jar. I have no idea why this is but all three of them cannot be modularized. I would suggest only modularizing commons-logging.jar and ignoring the other two. Ralph > On

Re: [LOGGING] Release with Java 9 Module support

2017-09-30 Thread Benedikt Ritter
> Am 26.09.2017 um 23:34 schrieb Stephen Colebourne : > > The contents of pom.xml look OK. I can't seem to browse to see if you > changed anything else in that commit. > > I would suggest being extra cautious when releasing, as a newer > version of maven may have changed some of the config, and

Re: [LOGGING] Release with Java 9 Module support

2017-09-27 Thread Stephen Colebourne
On 27 September 2017 at 00:01, Emmanuel Bourg wrote: > I wonder if we should do the same for commons-lang 2.x, it's still > commonly used. Yes. This would be very helpful Stephen - To unsubscribe, e-mail: dev-unsubscr...@commons

Re: [LOGGING] Release with Java 9 Module support

2017-09-26 Thread Jörg Schaible
Hi Benedikt, Benedikt Ritter wrote: [snip] >> AFAICS we have only commons-logging. The other artifacts have not been >> part of any release in the last decade. > > It looks like those artifacts have been published to maven central under > commons-logging:commons-logging coordinates [1]. I see.

Re: [LOGGING] Release with Java 9 Module support

2017-09-26 Thread Emmanuel Bourg
Le 26/09/2017 à 23:34, Stephen Colebourne a écrit : > I would suggest being extra cautious when releasing, as a newer > version of maven may have changed some of the config, and you don't > want to release the two extra jars to maven central. (In fact, why not > just delete their creation in pom.x

Re: [LOGGING] Release with Java 9 Module support

2017-09-26 Thread Stephen Colebourne
The contents of pom.xml look OK. I can't seem to browse to see if you changed anything else in that commit. I would suggest being extra cautious when releasing, as a newer version of maven may have changed some of the config, and you don't want to release the two extra jars to maven central. (In f

Re: [LOGGING] Release with Java 9 Module support

2017-09-26 Thread Benedikt Ritter
> Am 26.09.2017 um 22:54 schrieb Stephen Colebourne : > > On 26 September 2017 at 18:48, Jörg Schaible wrote: >> AFAICS we have only commons-logging. The other artifacts have not been part >> of any release in the last decade. > > Simple then! Please review revision 1809785. The build still cr

Re: [LOGGING] Release with Java 9 Module support

2017-09-26 Thread Stephen Colebourne
On 26 September 2017 at 18:48, Jörg Schaible wrote: > AFAICS we have only commons-logging. The other artifacts have not been part > of any release in the last decade. Simple then! Stephen - To unsubscribe, e-mail: dev-unsubscr..

Re: [LOGGING] Release with Java 9 Module support

2017-09-26 Thread Benedikt Ritter
Hello Jörg, > Am 26.09.2017 um 19:48 schrieb Jörg Schaible : > > Hi Stephen, > > Stephen Colebourne wrote: > >> On 26 September 2017 at 16:06, Benedikt Ritter wrote: >>> commons-logging.jar >>> commons-logging-adapters.jar >>> commons-logging-api.jar >>> >>> All jars have org.apache.commons.l

Re: [LOGGING] Release with Java 9 Module support

2017-09-26 Thread Gary Gregory
On Tue, Sep 26, 2017 at 11:48 AM, Jörg Schaible wrote: > Hi Stephen, > > Stephen Colebourne wrote: > > > On 26 September 2017 at 16:06, Benedikt Ritter > wrote: > >> commons-logging.jar > >> commons-logging-adapters.jar > >> commons-logging-api.jar > >> > >> All jars have org.apache.commons.logg

Re: [LOGGING] Release with Java 9 Module support

2017-09-26 Thread Jörg Schaible
Hi Stephen, Stephen Colebourne wrote: > On 26 September 2017 at 16:06, Benedikt Ritter wrote: >> commons-logging.jar >> commons-logging-adapters.jar >> commons-logging-api.jar >> >> All jars have org.apache.commons.logging as root package, so if I >> understand correctly we can’t do the Automati

Re: [LOGGING] Release with Java 9 Module support

2017-09-26 Thread Stephen Colebourne
On 26 September 2017 at 16:06, Benedikt Ritter wrote: > commons-logging.jar > commons-logging-adapters.jar > commons-logging-api.jar > > All jars have org.apache.commons.logging as root package, so if I understand > correctly we can’t do the Automatic-Module-Name trick, because this would > requ

Re: [LOGGING] Release with Java 9 Module support

2017-09-26 Thread Benedikt Ritter
Hi again, > Am 26.09.2017 um 16:54 schrieb Benedikt Ritter : > > Hello, > > since LOGGING-165 [1] has been raised, I’m planning to add the > Automatic-Module-Name to logging and get a new release out of the door. Looks like I was a bit over enthusiastic here… The logging build creates three a

[LOGGING] Release with Java 9 Module support

2017-09-26 Thread Benedikt Ritter
Hello, since LOGGING-165 [1] has been raised, I’m planning to add the Automatic-Module-Name to logging and get a new release out of the door. Regards, Benedikt [1] https://issues.apache.org/jira/browse/LOGGING-165 - To unsubscr